From: Wen Congyang <wency@cn.fujitsu.com> To: Wei Liu <wei.liu2@citrix.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen devel <xen-devel@lists.xen.org> Subject: Re: [PATCH v4 3/3] libxl: rename checkpointed_stream to stream_type Date: Wed, 16 Mar 2016 09:08:52 +0800 [thread overview] Message-ID: <56E8B224.4080900@cn.fujitsu.com> (raw) In-Reply-To: <20160315125438.GD31759@citrix.com> On 03/15/2016 08:54 PM, Wei Liu wrote: > On Tue, Mar 15, 2016 at 09:58:37AM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> >> --- >> v3->v4: Remove the new macro, and updte the macro LIBXL_HAVE_CHECKPOINTED_STREAM >> tools/libxl/libxl.c | 4 ++-- >> tools/libxl/libxl.h | 4 +++- >> tools/libxl/libxl_create.c | 4 ++-- >> tools/libxl/libxl_dom_save.c | 6 +++--- >> tools/libxl/libxl_internal.h | 2 +- >> tools/libxl/libxl_save_callout.c | 4 ++-- >> tools/libxl/libxl_stream_read.c | 4 ++-- >> tools/libxl/libxl_stream_write.c | 2 +- >> tools/libxl/libxl_types.idl | 2 +- >> tools/libxl/xl_cmdimpl.c | 16 ++++++++-------- >> 10 files changed, 25 insertions(+), 23 deletions(-) >> >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c >> index 93e228d..7579dd2 100644 >> --- a/tools/libxl/libxl.c >> +++ b/tools/libxl/libxl.c >> @@ -876,7 +876,7 @@ int libxl_domain_remus_start(libxl_ctx *ctx, libxl_domain_remus_info *info, >> dss->live = 1; >> dss->debug = 0; >> dss->remus = info; >> - dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_REMUS; >> + dss->stream_type = LIBXL_CHECKPOINTED_STREAM_REMUS; >> >> assert(info); >> >> @@ -937,7 +937,7 @@ int libxl_domain_suspend(libxl_ctx *ctx, uint32_t domid, int fd, int flags, >> dss->type = type; >> dss->live = flags & LIBXL_SUSPEND_LIVE; >> dss->debug = flags & LIBXL_SUSPEND_DEBUG; >> - dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_NONE; >> + dss->stream_type = LIBXL_CHECKPOINTED_STREAM_NONE; >> >> rc = libxl__fd_flags_modify_save(gc, dss->fd, >> ~(O_NONBLOCK|O_NDELAY), 0, >> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h >> index f9e3ef5..c55094b 100644 >> --- a/tools/libxl/libxl.h >> +++ b/tools/libxl/libxl.h >> @@ -879,7 +879,9 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, libxl_mac *src); >> /* >> * LIBXL_HAVE_CHECKPOINTED_STREAM >> * >> - * If this is defined, then libxl_checkpointed_stream exists. >> + * If this is defined, then libxl_checkpointed_stream exists, and the >> + * libxl_domain_create_restore() interface's parameter checkpointed_stream >> + * is renamed to stream_type >> */ >> #define LIBXL_HAVE_CHECKPOINTED_STREAM 1 > > I just realised this patch have not provided compatibility shim for > older version of LIBXL_API. > > It now breaks backward compatibility because it changes existing API. > It's my fault for not observing this earlier, sorry. > > On the other hand, I don't think this patch is strictly necessary. > Andrew's original complain was about libxc not exporting XC_MIG_* types. > I think libxl can function just fine as is with the old name. > > So if you really wish to change the name of that field, I'm afraid > compatibility shim for all functions that accept > libxl_domain_restore_params is required. > > I suggest we drop this patch for now and focus on core COLO > functionality, what do you think? It is OK to drop this patch. Thanks Wen Congyang > > Wei. > > > . > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-16 1:08 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-15 1:58 [PATCH v4 1/3] libxc: move migration_stream's definition to xenguest.h Wen Congyang 2016-03-15 1:58 ` [PATCH v4 2/3] tools: change checkpointed_stream's type from int to xc_migration_stream_t Wen Congyang 2016-03-17 13:53 ` Ian Jackson 2016-03-15 1:58 ` [PATCH v4 3/3] libxl: rename checkpointed_stream to stream_type Wen Congyang 2016-03-15 12:54 ` Wei Liu 2016-03-16 1:08 ` Wen Congyang [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56E8B224.4080900@cn.fujitsu.com \ --to=wency@cn.fujitsu.com \ --cc=andrew.cooper3@citrix.com \ --cc=ian.campbell@citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xen.org \ --subject='Re: [PATCH v4 3/3] libxl: rename checkpointed_stream to stream_type' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).