From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] x86/hvm/viridian: fix the TLB flush hypercall
Date: Wed, 16 Mar 2016 07:31:46 -0600 [thread overview]
Message-ID: <56E96E5202000078000DD26D@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1458133226-1808-1-git-send-email-paul.durrant@citrix.com>
>>> On 16.03.16 at 14:00, <paul.durrant@citrix.com> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2576,12 +2576,9 @@ int hvm_vcpu_initialise(struct vcpu *v)
> if ( rc != 0 )
> goto fail6;
>
> - if ( is_viridian_domain(d) )
> - {
> - rc = viridian_vcpu_init(v);
> - if ( rc != 0 )
> - goto fail7;
> - }
> + rc = viridian_vcpu_init(v);
> + if ( rc != 0 )
> + goto fail7;
Well, it's only a CPU mask (i.e. right now at most 512 bytes), but
anyway - why can't this be done conditionally here as well as
when HVM_PARAM_VIRIDIAN gets set to a non-zero value? I
know you are of the opinion that the Viridian flag could (should)
always be set for HVM guests, but you also know that I disagree
(and Don't VMware patches, should they ever go in, would
support me, since iirc VMware and Viridian are exclusive of one
another).
That said, I now wonder anyway why this is a per-vCPU mask
instead of a per-pCPU one: There's no need for every vCPU in
the system to have its own afaics.
> @@ -658,6 +658,8 @@ int viridian_hypercall(struct cpu_user_regs *regs)
> if ( !cpumask_empty(pcpu_mask) )
> flush_tlb_mask(pcpu_mask);
>
> + output.rep_complete = input.rep_count;
So why would this not be necessary for the other hypercalls?
And what does a repeat count mean here in the first place?
Surely there isn't any expectation to do more then one flush?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-16 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:00 [PATCH] x86/hvm/viridian: fix the TLB flush hypercall Paul Durrant
2016-03-16 13:20 ` Andrew Cooper
2016-03-16 13:25 ` Paul Durrant
2016-03-16 13:31 ` Jan Beulich [this message]
2016-03-16 13:37 ` Andrew Cooper
2016-03-16 13:39 ` Paul Durrant
2016-03-16 13:38 ` Paul Durrant
-- strict thread matches above, loose matches on Subject: below --
2016-03-16 12:57 Paul Durrant
2016-03-16 13:09 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96E5202000078000DD26D@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).