From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig
Date: Wed, 16 Mar 2016 07:34:28 -0600 [thread overview]
Message-ID: <56E96EF402000078000DD273@prv-mh.provo.novell.com> (raw)
In-Reply-To: <56E9579F.4090702@cardoe.com>
>>> On 16.03.16 at 13:54, <cardoe@cardoe.com> wrote:
> On 3/16/16 3:47 AM, Jan Beulich wrote:
>>>>> On 15.03.16 at 21:18, <cardoe@cardoe.com> wrote:
>>> Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM
>>> option allowing users to build Xen without tmem support.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>>> ---
>>> CC: Keir Fraser <keir@xen.org>
>>> CC: Jan Beulich <jbeulich@suse.com>
>>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>
>>> changes from v1:
>>> - add description provided by Konrad (thanks!)
>>> - tweaks to Makefile suggested by Jan
>>
>> Only kind of:
>>
>>> @@ -65,7 +63,12 @@ obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz
> unlzma unlzo unlz4
>>> obj-$(perfc) += perfc.o
>>> obj-$(crash_debug) += gdbstub.o
>>>
>>> -obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o
> multicall.o tmem_xen.o xlat.o)
>>> +obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o
> multicall.o xlat.o)
>>> +
>>> +tmem-y += tmem.o
>>> +tmem-y += tmem_xen.o
>>
>> I had intentionally suggested
>>
>> tmem-y := tmem.o tmem_xen.o
>>
>> Splitting this up into two lines is a matter of taste, but not using := is
>> inefficient, as it requires make to possibly expand the variable many
>> times instead of just once.
>>
>> But anyway - since functionality wise this is fine, with or without that
>> further adjustment
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>
>> Jan
>>
>
> You're right. Its worth correcting. I'll post a v3. Can I retain your
> Acked-by?
Sure - I had said so already (see above).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-16 13:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 20:18 [PATCH v2 0/3] Allow tmem to be disabled via Kconfig Doug Goldstein
2016-03-15 20:18 ` [PATCH v2 1/3] tmem: add tmem_disable() function Doug Goldstein
2016-03-15 20:18 ` [PATCH v2 2/3] tmem: drop direct usage of opt_tmem Doug Goldstein
2016-03-16 8:41 ` Jan Beulich
2016-03-15 20:18 ` [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig Doug Goldstein
2016-03-16 7:35 ` Konrad Rzeszutek Wilk
2016-03-16 8:39 ` Jan Beulich
2016-03-16 8:55 ` Konrad Rzeszutek Wilk
2016-03-16 8:47 ` Jan Beulich
2016-03-16 12:54 ` Doug Goldstein
2016-03-16 13:34 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96EF402000078000DD273@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).