From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig Date: Wed, 16 Mar 2016 11:09:01 -0500 Message-ID: <56E9851D.3040404@cardoe.com> References: <1457376161-24982-1-git-send-email-cardoe@cardoe.com> <1457376161-24982-2-git-send-email-cardoe@cardoe.com> <56DEAD8602000078000DA45D@prv-mh.provo.novell.com> <56DEFC58.9090801@tycho.nsa.gov> <56DF112F02000078000DA884@prv-mh.provo.novell.com> <56DF138D.8080001@tycho.nsa.gov> <56E6C518.1070706@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2433039077544539966==" Return-path: In-Reply-To: <56E6C518.1070706@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Daniel De Graaf , Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2433039077544539966== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hTNU2X8VPa3DkXJjvmhOx3r8jFOuPQJ43" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hTNU2X8VPa3DkXJjvmhOx3r8jFOuPQJ43 Content-Type: multipart/mixed; boundary="01GWfJWF1GODkGrKmIvN3ttoDTdui9op2" From: Doug Goldstein To: Daniel De Graaf , Jan Beulich Cc: xen-devel@lists.xen.org Message-ID: <56E9851D.3040404@cardoe.com> Subject: Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig References: <1457376161-24982-1-git-send-email-cardoe@cardoe.com> <1457376161-24982-2-git-send-email-cardoe@cardoe.com> <56DEAD8602000078000DA45D@prv-mh.provo.novell.com> <56DEFC58.9090801@tycho.nsa.gov> <56DF112F02000078000DA884@prv-mh.provo.novell.com> <56DF138D.8080001@tycho.nsa.gov> <56E6C518.1070706@cardoe.com> In-Reply-To: <56E6C518.1070706@cardoe.com> --01GWfJWF1GODkGrKmIvN3ttoDTdui9op2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/14/16 9:05 AM, Doug Goldstein wrote: > On 3/8/16 12:01 PM, Daniel De Graaf wrote: >> On 03/08/2016 11:51 AM, Jan Beulich wrote: >>>>>> On 08.03.16 at 17:22, wrote: >>>> On 03/08/2016 04:46 AM, Jan Beulich wrote: >>>>>>>> On 07.03.16 at 19:42, wrote: >>>>>> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with >>>>>> CONFIG_ >>>>>> to use the Kconfig variable. >>>>> >>>>> Same question here: What's the benefit of doing it this way? >>>> >>>> This removes the stats tracking, which might (I have not tested) >>>> speed up >>>> the security server by avoiding the __get_cpu_var call and increment= =2E >>> >>> No, I don not think the patch removes anything. The Kconfig option >>> doesn't have a prompt. But anyway, ... >> >> Ah, I missed that: I saw the --help-- line and assumed it was the prom= pt. >> Either way, this #define is a configuration-like knob that doesn't nee= d to >> be hard-coded in a header as it currently is. >> >>> >>>> The >>>> corresponding SELinux knob is a Kconfig option in Linux. >>>> >>>> Acked-by: Daniel De Graaf >>> >>> ... if you're fine with it, we'll put it in (once the mechanical issu= es >>> got addressed). >> >=20 > Daniel, >=20 > Would you like me to make this a real configuration option? Or proceed > with the current path and we can make a configuration option later? >=20 I'll resubmit as is and we can address making that a user facing option in a follow on. --=20 Doug Goldstein --01GWfJWF1GODkGrKmIvN3ttoDTdui9op2-- --hTNU2X8VPa3DkXJjvmhOx3r8jFOuPQJ43 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW6YUfXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUqVkP/1nwvt5yOhFXs0mthrZ+53wc JDyKY21HbEA7Th9Z6xv3Bnb31q6JLb92eKNCOXR4VPukZZ8dmLKjpn6svUUuPgNP 8TArTPVLeraBS+UbUpId9OnF0ZL+a2h10Es5iMLd65Ac97pXa+tz3sKZact7fr1e dcJSdAoQAEGCI/Xx+0bW4rmBXLzc8ZWEsdRLczLEbUQcZbSCvs+2PPiRfVtolFcN 79VeFkb2AbcZDjhpaRCkO5A5+DSSC0eEdMhkVgVM2+p3Fr1MxXh1WBxfMp63X78P FSx9IpP6BG6qnvcm7mE7LMglahFLCcgvGSShZHvw8MtBzJmZ6ymhgwf9U8Hspobp Y65TFUCMAYAjuDy6BepBHXrEKszPXrZmMGWUoDl0btj7uQYOGslLY5Yv5oS5sgaj ZA/KUQjYA7PJWzCfUF+cwaVHDc+ole7200q2MZQ9/NZ7Lmup4OVy4vKcqtCb+weG fvdgcW2S6dfr4DG8al8XmM9LDMCv1FY/C2BuWvW2qg5/gqakxyhfEyZrgvPTLFMF xvSrAEFj2yjRnpn5xu97k3jT24QboYpzepG7ZPaCEm/P9YoMLxYnsTS7qpUYK5OM jzADj/XdXD/73HQstOxaDTw2tQBxqDgdNqHBmT9qdRT25ibpt9UZkawagoPhV6Ye +PGBiyIFt1Q6jsXX71lA =ZkAQ -----END PGP SIGNATURE----- --hTNU2X8VPa3DkXJjvmhOx3r8jFOuPQJ43-- --===============2433039077544539966== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2433039077544539966==--