From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/hvm/viridian: fix the TLB flush hypercall
Date: Wed, 16 Mar 2016 09:35:43 -0600 [thread overview]
Message-ID: <56E98B5F02000078000DD421@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1458138101-1466-1-git-send-email-paul.durrant@citrix.com>
>>> On 16.03.16 at 15:21, <paul.durrant@citrix.com> wrote:
> v2:
> - Move to per-pcpu ipi mask.
> - Use smp_send_event_check_mask() to IPI rather than flush_tlb_mask().
> ---
> xen/arch/x86/hvm/hvm.c | 12 ------------
> xen/arch/x86/hvm/viridian.c | 19 ++++++-------------
> xen/include/asm-x86/hvm/viridian.h | 4 ----
> 3 files changed, 6 insertions(+), 29 deletions(-)
Quite nice for a bug fix.
> @@ -656,7 +647,9 @@ int viridian_hypercall(struct cpu_user_regs *regs)
> * so we may unnecessarily IPI some CPUs.
> */
> if ( !cpumask_empty(pcpu_mask) )
> - flush_tlb_mask(pcpu_mask);
> + smp_send_event_check_mask(pcpu_mask);
> +
> + output.rep_complete = input.rep_count;
Questions on this one remain: Why only for this hypercall? And
what does "repeat count" mean in this context?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-16 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 14:21 Paul Durrant
2016-03-16 15:35 ` Jan Beulich [this message]
2016-03-16 17:35 ` Paul Durrant
2016-03-17 8:11 ` Jan Beulich
2016-03-17 8:14 ` Paul Durrant
2016-03-17 8:35 ` Jan Beulich
2016-03-17 10:30 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E98B5F02000078000DD421@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--subject='Re: [PATCH v2] x86/hvm/viridian: fix the TLB flush hypercall' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).