From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v4 02/14] libxc: Prepare a start info structure for hvmloader Date: Wed, 16 Mar 2016 14:01:38 -0400 Message-ID: <56E99F82.4080607@oracle.com> References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com> <1457978150-27201-3-git-send-email-anthony.perard@citrix.com> <20160316001849.GH29495@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160316001849.GH29495@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , Anthony PERARD , roger.pau@citrix.com Cc: Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMDMvMTUvMjAxNiAwODoxOCBQTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IE9u IE1vbiwgTWFyIDE0LCAyMDE2IGF0IDA1OjU1OjM3UE0gKzAwMDAsIEFudGhvbnkgUEVSQVJEIHdy b3RlOgo+CgoKPj4gQEAgLTYyNCw4ICs2MjgsNiBAQCBzdGF0aWMgaW50IGFsbG9jX21hZ2ljX3Bh Z2VzX2h2bShzdHJ1Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4+ICAgCj4+ICAgICAgIGlmICggIWRv bS0+ZGV2aWNlX21vZGVsICkKPj4gICAgICAgewo+PiAtICAgICAgICBzaXplX3Qgc3RhcnRfaW5m b19zaXplID0gc2l6ZW9mKHN0cnVjdCBodm1fc3RhcnRfaW5mbyk7Cj4+IC0KPj4gICAgICAgICAg IGlmICggZG9tLT5jbWRsaW5lICkKPj4gICAgICAgICAgIHsKPj4gICAgICAgICAgICAgICBkb20t PmNtZGxpbmVfc2l6ZSA9IFJPVU5EVVAoc3RybGVuKGRvbS0+Y21kbGluZSkgKyAxLCA4KTsKPj4g QEAgLTYzNSwxNyArNjM3LDI2IEBAIHN0YXRpYyBpbnQgYWxsb2NfbWFnaWNfcGFnZXNfaHZtKHN0 cnVjdCB4Y19kb21faW1hZ2UgKmRvbSkKPj4gICAgICAgICAgIC8qIExpbWl0ZWQgdG8gb25lIG1v ZHVsZS4gKi8KPj4gICAgICAgICAgIGlmICggZG9tLT5yYW1kaXNrX2Jsb2IgKQo+PiAgICAgICAg ICAgICAgIHN0YXJ0X2luZm9fc2l6ZSArPSBzaXplb2Yoc3RydWN0IGh2bV9tb2RsaXN0X2VudHJ5 KTsKPj4gLQo+PiAtICAgICAgICByYyA9IHhjX2RvbV9hbGxvY19zZWdtZW50KGRvbSwgJmRvbS0+ c3RhcnRfaW5mb19zZWcsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkhW TWxpdGUgc3RhcnQgaW5mbyIsIDAsIHN0YXJ0X2luZm9fc2l6ZSk7Cj4+IC0gICAgICAgIGlmICgg cmMgIT0gMCApCj4+IC0gICAgICAgIHsKPj4gLSAgICAgICAgICAgIERPTVBSSU5URigiVW5hYmxl IHRvIHJlc2VydmUgbWVtb3J5IGZvciB0aGUgc3RhcnQgaW5mbyIpOwo+PiAtICAgICAgICAgICAg Z290byBvdXQ7Cj4+IC0gICAgICAgIH0KPj4gICAgICAgfQo+PiAgICAgICBlbHNlCj4+ICAgICAg IHsKPj4gKyAgICAgICAgc3RhcnRfaW5mb19zaXplICs9Cj4+ICsgICAgICAgICAgICBzaXplb2Yo c3RydWN0IGh2bV9tb2RsaXN0X2VudHJ5KSAqIEhWTUxPQURFUl9NT0RVTEVfTUFYX0NPVU5UOwo+ PiArICAgICAgICAvKiBBZGQgZXh0cmEgc3BhY2UgdG8gd3JpdGUgbW9kdWxlcyBuYW1lICovCj4+ ICsgICAgICAgIHN0YXJ0X2luZm9fc2l6ZSArPQo+PiArICAgICAgICAgICAgSFZNTE9BREVSX01P RFVMRV9OQU1FX1NJWkUgKiBIVk1MT0FERVJfTU9EVUxFX01BWF9DT1VOVDsKPiBXaGF0IGFib3V0 IFwwID8gQWgsIHRoZSBzdHJuY3B5IHdlIHVzZSBhZGRzIFwwIGJ5dGUuIEJ1dCBpdCB3b3VsZCBi ZSBuaWNlCj4gdG8gbWVudGlvbiB0aGF0IHNvbWV3aGVyZS4gUGVyaGFwcyBtZW50aW9uOgo+Cj4g VGhlIEhWTUxPQURFUl9NT0RVTEVfTkFNRV9TSVpFIGFjY291bnRzIGZvciBOVUwgYnl0ZT8KPgo+ PiArICAgIH0KPj4gKwo+PiArICAgIHJjID0geGNfZG9tX2FsbG9jX3NlZ21lbnQoZG9tLCAmZG9t LT5zdGFydF9pbmZvX3NlZywKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJIVk1s aXRlIHN0YXJ0IGluZm8iLCAwLCBzdGFydF9pbmZvX3NpemUpOwo+PiArICAgIGlmICggcmMgIT0g MCApCj4+ICsgICAgewo+PiArICAgICAgICBET01QUklOVEYoIlVuYWJsZSB0byByZXNlcnZlIG1l bW9yeSBmb3IgdGhlIHN0YXJ0IGluZm8iKTsKPj4gKyAgICAgICAgZ290byBvdXQ7Cj4+ICsgICAg fQo+PiArCj4+ICsgICAgaWYgKCBkb20tPmRldmljZV9tb2RlbCApCj4+ICsgICAgewoKCkNhbiB5 b3UgZm9sZCB0aGlzIGludG8gdGhlICdlbHNlJyBjbGF1c2UgYWJvdmUgYW5kIG1vdmUgCnhjX2Rv bV9hbGxvY19zZWdtZW50KCkgZG93bj8KCgo+PiArCj4+ICAgc3RhdGljIGludCBib290bGF0ZV9o dm0oc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQo+PiAgIHsKPj4gICAgICAgdWludDMyX3QgZG9t aWQgPSBkb20tPmd1ZXN0X2RvbWlkOwo+PiAgICAgICB4Y19pbnRlcmZhY2UgKnhjaCA9IGRvbS0+ eGNoOwo+PiArICAgIHN0cnVjdCBodm1fc3RhcnRfaW5mbyAqc3RhcnRfaW5mbzsKPj4gKyAgICBz aXplX3Qgc3RhcnRfaW5mb19zaXplOwo+PiArICAgIHZvaWQgKnN0YXJ0X3BhZ2U7Cj4+ICsgICAg c3RydWN0IGh2bV9tb2RsaXN0X2VudHJ5ICptb2RsaXN0Owo+PiAgIAo+PiAtICAgIGlmICggIWRv bS0+ZGV2aWNlX21vZGVsICkKPj4gLSAgICB7Cj4+IC0gICAgICAgIHN0cnVjdCBodm1fc3RhcnRf aW5mbyAqc3RhcnRfaW5mbzsKPj4gLSAgICAgICAgc2l6ZV90IHN0YXJ0X2luZm9fc2l6ZTsKPj4g LSAgICAgICAgdm9pZCAqc3RhcnRfcGFnZTsKPj4gLQo+PiAtICAgICAgICBzdGFydF9pbmZvX3Np emUgPSBzaXplb2YoKnN0YXJ0X2luZm8pICsgZG9tLT5jbWRsaW5lX3NpemU7Cj4+IC0gICAgICAg IGlmICggZG9tLT5yYW1kaXNrX2Jsb2IgKQo+PiAtICAgICAgICAgICAgc3RhcnRfaW5mb19zaXpl ICs9IHNpemVvZihzdHJ1Y3QgaHZtX21vZGxpc3RfZW50cnkpOwo+PiArICAgIHN0YXJ0X2luZm9f c2l6ZSA9IHNpemVvZigqc3RhcnRfaW5mbykgKyBkb20tPmNtZGxpbmVfc2l6ZTsKPj4gKyAgICBp ZiAoIGRvbS0+cmFtZGlza19ibG9iICkKPj4gKyAgICAgICAgc3RhcnRfaW5mb19zaXplICs9IHNp emVvZihzdHJ1Y3QgaHZtX21vZGxpc3RfZW50cnkpOwo+PiAgIAo+PiAtICAgICAgICBpZiAoIHN0 YXJ0X2luZm9fc2l6ZSA+Cj4+IC0gICAgICAgICAgICAgZG9tLT5zdGFydF9pbmZvX3NlZy5wYWdl cyA8PCBYQ19ET01fUEFHRV9TSElGVChkb20pICkKPj4gLSAgICAgICAgewo+PiAtICAgICAgICAg ICAgRE9NUFJJTlRGKCJUcnlpbmcgdG8gbWFwIGJleW9uZCBzdGFydF9pbmZvX3NlZyIpOwo+PiAt ICAgICAgICAgICAgcmV0dXJuIC0xOwo+PiAtICAgICAgICB9Cj4+ICsgICAgaWYgKCBzdGFydF9p bmZvX3NpemUgPgo+PiArICAgICAgICAgZG9tLT5zdGFydF9pbmZvX3NlZy5wYWdlcyA8PCBYQ19E T01fUEFHRV9TSElGVChkb20pICkKPj4gKyAgICB7Cj4+ICsgICAgICAgIERPTVBSSU5URigiVHJ5 aW5nIHRvIG1hcCBiZXlvbmQgc3RhcnRfaW5mb19zZWciKTsKPj4gKyAgICAgICAgcmV0dXJuIC0x Owo+PiArICAgIH0KPj4gICAKPj4gLSAgICAgICAgc3RhcnRfcGFnZSA9IHhjX21hcF9mb3JlaWdu X3JhbmdlKHhjaCwgZG9taWQsIHN0YXJ0X2luZm9fc2l6ZSwKPj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsCj4+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb20tPnN0YXJ0X2luZm9fc2Vn LnBmbik7Cj4+IC0gICAgICAgIGlmICggc3RhcnRfcGFnZSA9PSBOVUxMICkKPj4gLSAgICAgICAg ewo+PiAtICAgICAgICAgICAgRE9NUFJJTlRGKCJVbmFibGUgdG8gbWFwIEhWTSBzdGFydCBpbmZv IHBhZ2UiKTsKPj4gLSAgICAgICAgICAgIHJldHVybiAtMTsKPj4gLSAgICAgICAgfQo+PiArICAg IHN0YXJ0X3BhZ2UgPSB4Y19tYXBfZm9yZWlnbl9yYW5nZSh4Y2gsIGRvbWlkLCBzdGFydF9pbmZv X3NpemUsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1RfUkVB RCB8IFBST1RfV1JJVEUsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGRvbS0+c3RhcnRfaW5mb19zZWcucGZuKTsKPj4gKyAgICBpZiAoIHN0YXJ0X3BhZ2UgPT0gTlVM TCApCj4+ICsgICAgewo+PiArICAgICAgICBET01QUklOVEYoIlVuYWJsZSB0byBtYXAgSFZNIHN0 YXJ0IGluZm8gcGFnZSIpOwo+PiArICAgICAgICByZXR1cm4gLTE7Cj4+ICsgICAgfQo+PiAgIAo+ PiAtICAgICAgICBzdGFydF9pbmZvID0gc3RhcnRfcGFnZTsKPj4gKyAgICBzdGFydF9pbmZvID0g c3RhcnRfcGFnZTsKPj4gKyAgICBtb2RsaXN0ID0gc3RhcnRfcGFnZSArIHNpemVvZigqc3RhcnRf aW5mbykgKyBkb20tPmNtZGxpbmVfc2l6ZTsKCkkgdGhpbmsgd2UgY2FuIGRyb3Agc3RhcnRfcGFn ZSBhbmQgdXNlIHN0YXJ0X2luZm8gb25seS4gVGhleSBhcmUgdGhlIApzYW1lLCBhcmVuJ3QgdGhl eT8KCi1ib3JpcwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6 Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=