From: George Dunlap <firstname.lastname@example.org> To: Wei Liu <email@example.com>, Xen-devel <firstname.lastname@example.org> Cc: George Dunlap <email@example.com>, Ian Jackson <firstname.lastname@example.org>, Stefano Stabellini <email@example.com> Subject: Re: [PATCH] xentrace: simplify map_page function in xenctx Date: Thu, 17 Mar 2016 11:48:39 +0000 [thread overview] Message-ID: <56EA9997.firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 03/03/16 13:10, Wei Liu wrote: > There were several problems: > > 1. Variable mapped was set to NULL so the following two "if"s were > useless. > 2. Variable previous_mfn was set but never used. mapped and previous_mfn are static, which (in this context) means they persists across invocations of the function. mapped is only set to NULL for the first call. Subsequent calls it's used to unmap the previous mapping; and previous_mfn is used to avoid unmap'ing and re-map'ing the same mfn. This change will cause xenctx to leak virtual address space. -George _______________________________________________ Xen-devel mailing list Xenfirstname.lastname@example.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-17 11:49 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-03 13:10 Wei Liu 2016-03-17 11:48 ` George Dunlap [this message] 2016-03-17 11:54 ` Wei Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56EA9997.email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] xentrace: simplify map_page function in xenctx' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).