* [PATCH] x86: put kexec_reloc in its own section
@ 2016-03-17 16:17 Jan Beulich
2016-03-17 16:19 ` Andrew Cooper
2016-03-17 17:41 ` David Vrabel
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2016-03-17 16:17 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser, David Vrabel
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Since it wants to be page aligned, this alignment would force pointless
alignment of .text in the intermediate built_in.o file(s), needlessly
growing the overall text and binary size.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_64/kexec_reloc.S
+++ b/xen/arch/x86/x86_64/kexec_reloc.S
@@ -18,7 +18,7 @@
#include <asm/page.h>
#include <asm/machine_kexec.h>
- .text
+ .section .text.kexec, "ax", @progbits
.align PAGE_SIZE
.code64
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -49,6 +49,7 @@ SECTIONS
*(.text.cold)
*(.text.unlikely)
*(.fixup)
+ *(.text.kexec)
*(.gnu.warning)
_etext = .; /* End of text section */
} :text = 0x9090
[-- Attachment #2: x86-kexec-text.patch --]
[-- Type: text/plain, Size: 841 bytes --]
x86: put kexec_reloc in its own section
Since it wants to be page aligned, this alignment would force pointless
alignment of .text in the intermediate built_in.o file(s), needlessly
growing the overall text and binary size.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_64/kexec_reloc.S
+++ b/xen/arch/x86/x86_64/kexec_reloc.S
@@ -18,7 +18,7 @@
#include <asm/page.h>
#include <asm/machine_kexec.h>
- .text
+ .section .text.kexec, "ax", @progbits
.align PAGE_SIZE
.code64
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -49,6 +49,7 @@ SECTIONS
*(.text.cold)
*(.text.unlikely)
*(.fixup)
+ *(.text.kexec)
*(.gnu.warning)
_etext = .; /* End of text section */
} :text = 0x9090
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86: put kexec_reloc in its own section
2016-03-17 16:17 [PATCH] x86: put kexec_reloc in its own section Jan Beulich
@ 2016-03-17 16:19 ` Andrew Cooper
2016-03-17 17:41 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2016-03-17 16:19 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser, David Vrabel
On 17/03/16 16:17, Jan Beulich wrote:
> Since it wants to be page aligned, this alignment would force pointless
> alignment of .text in the intermediate built_in.o file(s), needlessly
> growing the overall text and binary size.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: put kexec_reloc in its own section
2016-03-17 16:17 [PATCH] x86: put kexec_reloc in its own section Jan Beulich
2016-03-17 16:19 ` Andrew Cooper
@ 2016-03-17 17:41 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2016-03-17 17:41 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Keir Fraser, David Vrabel
On 17/03/16 16:17, Jan Beulich wrote:
> Since it wants to be page aligned, this alignment would force pointless
> alignment of .text in the intermediate built_in.o file(s), needlessly
> growing the overall text and binary size.
Acked-by: David Vrabel <david.vrabel@citrix.com>
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-17 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-17 16:17 [PATCH] x86: put kexec_reloc in its own section Jan Beulich
2016-03-17 16:19 ` Andrew Cooper
2016-03-17 17:41 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).