xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>, konrad.wilk@oracle.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] xen/events: Mask a moving irq
Date: Thu, 17 Mar 2016 13:49:42 -0400	[thread overview]
Message-ID: <56EAEE36.6050804__12613.6221843355$1458237050$gmane$org@oracle.com> (raw)
In-Reply-To: <56EAE95D.6020006@citrix.com>

On 03/17/2016 01:29 PM, David Vrabel wrote:
> On 17/03/16 16:53, Boris Ostrovsky wrote:
>> On 03/17/2016 12:03 PM, David Vrabel wrote:
>>> On 17/03/16 12:45, Boris Ostrovsky wrote:
>>>> Moving an unmasked irq may result in irq handler being invoked on both
>>>> source and target CPUs.
>>>>
>>>> With 2-level this can happen as follows:
>>>>
>>>> On source CPU:
>>>>           evtchn_2l_handle_events() ->
>>>>               generic_handle_irq() ->
>>>>                   handle_edge_irq() ->
>>>>                      eoi_pirq():
>>>>                          irq_move_irq(data);
>>>>
>>>>                          /***** WE ARE HERE *****/
>>>>
>>>>                          if (VALID_EVTCHN(evtchn))
>>>>                              clear_evtchn(evtchn);
>>>>
>>>> If at this moment target processor is handling an unrelated event in
>>>> evtchn_2l_handle_events()'s loop it may pick up our event since target's
>>>> cpu_evtchn_mask claims that this event belongs to it *and* the event is
>>>> unmasked and still pending. At the same time, source CPU will continue
>>>> executing its own handle_edge_irq().
>>>>
>>>> With FIFO interrupt the scenario is similar: irq_move_irq() may result
>>>> in a EVTCHNOP_unmask hypercall which, in turn, may make the event
>>>> pending on the target CPU.
>>>>
>>>> We can avoid this situation by moving and clearing the event while
>>>> keeping event masked.
>>> Can you do:
>>>
>>>      if (unlikely(irqd_is_setaffinity_pending(data))) {
>>>          masked = test_and_set_mask()
>>>
>>>          clear_evtchn()
>>>          irq_move_masked_irq()
>> I did think about this but then I wasn't sure whether this might open
>> some other window for things to sneak in. It shouldn't but these things
>> are rather subtle so I'd rather leave the order of how operations are
>> done unchanged.
> This is the order your patch has though.  I'm confused.

Ugh, sorry --- I misread what you wrote, I thought you wanted to clear 
before masking. Which wouldn't make any sense.

So yes, what you are suggesting is better.

-borsi

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-03-17 17:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1458218750-5202-1-git-send-email-boris.ostrovsky@oracle.com>
2016-03-17 16:03 ` David Vrabel
     [not found] ` <56EAD55A.6020801@citrix.com>
2016-03-17 16:53   ` Boris Ostrovsky
     [not found]   ` <56EAE0F7.4060703@oracle.com>
2016-03-17 17:29     ` David Vrabel
     [not found]     ` <56EAE95D.6020006@citrix.com>
2016-03-17 17:49       ` Boris Ostrovsky [this message]
2016-03-17 12:45 Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='56EAEE36.6050804__12613.6221843355$1458237050$gmane$org@oracle.com' \
    --to=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xen/events: Mask a moving irq' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).