From: Ross Philipson <ross.philipson@gmail.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block
Date: Thu, 17 Mar 2016 18:10:59 -0400 [thread overview]
Message-ID: <56EB2B73.3060905@gmail.com> (raw)
It seems the logic is meant to detect sector unaligned buffers for block
writes. The NOTing of the logic instead masks off any unaligned bits and
also would cause the function to always fail. It seems the function is not
used in any of the tools so that is probably why the problem is not seen.
In the vhd_read_block function it is correct.
Signed-off-by: Ross Philipson <ross.philipson@ainfosec.com>
---
diff --git a/tools/blktap2/vhd/lib/libvhd.c b/tools/blktap2/vhd/lib/libvhd.c
index 1fd5b4e..4ebe012 100644
--- a/tools/blktap2/vhd/lib/libvhd.c
+++ b/tools/blktap2/vhd/lib/libvhd.c
@@ -2188,7 +2188,7 @@ vhd_write_block(vhd_context_t *ctx, uint32_t block, char *data)
if (block >= ctx->bat.entries)
return -ERANGE;
- if ((unsigned long)data & ~(VHD_SECTOR_SIZE -1))
+ if ((unsigned long)data & (VHD_SECTOR_SIZE -1))
return -EINVAL;
blk = ctx->bat.bat[block];
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-03-17 22:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 22:10 Ross Philipson [this message]
2016-03-25 16:11 ` [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block Wei Liu
2016-03-25 16:34 ` Ross Philipson
2016-03-25 16:38 ` Wei Liu
2016-03-29 11:26 ` George Dunlap
2016-03-30 14:47 ` Ross Philipson
2016-04-06 16:51 ` Ross Philipson
2016-07-06 13:16 ` George Dunlap
2016-04-06 14:39 ` Ian Jackson
2016-04-06 15:25 ` Ross Philipson
2016-04-06 15:37 ` Ross Philipson
2016-04-07 16:37 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EB2B73.3060905@gmail.com \
--to=ross.philipson@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).