From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 08/34] vmap: Make the while loop less fishy. Date: Mon, 21 Mar 2016 07:26:33 -0600 Message-ID: <56F0049902000078000DED6A@prv-mh.provo.novell.com> References: <1458064616-23101-1-git-send-email-konrad.wilk@oracle.com> <1458064616-23101-9-git-send-email-konrad.wilk@oracle.com> <22250.54910.735489.888445@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahzqz-00075c-J9 for xen-devel@lists.xenproject.org; Mon, 21 Mar 2016 13:26:41 +0000 In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Keir Fraser , Andrew Cooper , Ian Jackson , Tim Deegan , mpohlack@amazon.de, Ross Lagerwall , sasha.levin@oracle.com, xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDIxLjAzLjE2IGF0IDEzOjA0LCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPiB3 cm90ZToKPiBPbiBUaHUsIE1hciAxNywgMjAxNiBhdCA0OjA4IFBNLCBJYW4gSmFja3NvbiA8SWFu LkphY2tzb25AZXUuY2l0cml4LmNvbT4gd3JvdGU6Cj4+IEtvbnJhZCBSemVzenV0ZWsgV2lsayB3 cml0ZXMgKCJbUEFUQ0ggdjQgMDgvMzRdIHZtYXA6IE1ha2UgdGhlIHdoaWxlIGxvb3AgbGVzcyBm aXNoeS4iKToKPj4+ICAgZXJyb3I6Cj4+PiAtICAgIHdoaWxlICggaS0tICkKPj4+IC0gICAgICAg IGZyZWVfZG9taGVhcF9wYWdlKG1mbl90b19wYWdlKG1mbl94KG1mbltpXSkpKTsKPj4+ICsgICAg d2hpbGUgKCBpICkKPj4+ICsgICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKG1mbl90b19wYWdlKG1m bl94KG1mblstLWldKSkpOwo+Pgo+PiBJIHF1aXRlIHN0cm9uZ2x5IGRpc2xpa2UgdGhpcy4gIEl0 IGlzIGdvb2QgcHJhY3RpY2UgdG8ga2VlcCB0aGUgbG9vcAo+PiBjb250cm9sIGNvZGUgdG9nZXRo ZXIgd2hlcmUgdGhpcyBpcyByZWFzb25hYmx5IGNvbnZlbmllbnQuCj4+Cj4+IEkgd291bGRuJ3Qg cXVpYmJsZSBvbiBzdWNoIGEgc3R5bGlzdGljIG1hdHRlciAocGFydGljdWxhcmx5IG91dHNpZGUg bXkKPj4gYmFpbGl3aWNrKSBidXQgKGEpIEkgd291bGQgbGlrZSB0byByZWluZm9yY2UgSmFuJ3Mg cG9zaXRpb24gYW5kCj4+IChiKSBpdCBzZWVtcyB3b3J0aCB3cml0aW5nIGFuIGVtYWlsIGFzIHRo ZXJlIHdpbGwgYmUgbWFueSBvY2N1cnJlbmNlcy4KPiAKPiBTaW5jZSB3ZSdyZSB0YWtpbmcgYWJv dXQgZ2VuZXJhbCBwcmluY2lwbGUgKGFuZCBJJ3ZlIGJlZW4gcmVmZXJyZWQgdG8KPiBoZXJlIGZy b20gYSBzaW1pbGFyIGRpc2N1c3Npb24gZWxzZXdoZXJlIFsxXSksIGxldCBtZSB3ZWlnaCBpbiBh cwo+IHdlbGwuCj4gCj4gSSBjYW4gc2VlIHRoZSBwb2ludCBvZiBub3Qgd2FudGluZyB0aGUgZGVj cmVtZW50IHRvIGJlIGluIHRoZSBtaWRkbGUKPiBvZiB0aGUgZXhwcmVzc2lvbiBoZXJlLiAgQnV0 IEkgYWxzbyBlbnRpcmVseSBhZ3JlZSB3aXRoIEtvbnJhZCdzCj4gYXNzZXNzbWVudCB0aGF0IHRo aXMgY29kZSBpcyBsaWtlbHkgdG8gYmUgY29uZnVzaW5nOyBhbmQgdGhlIGZhY3QgdGhhdAo+IGEg Y29tcHV0ZXIgcHJvZ3JhbSBmb2xsb3dpbmcgYSBsaXN0IG9mIHJ1bGVzICpkZXZlbG9wZWQgYnkK PiBwcm9mZXNzaW9uYWwgYnVnLWZpbmRlcnMqIGlzIGNvbmZ1c2VkIGJ5IHRoaXMga2luZCBvZiBz ZW1hbnRpY3MgSQo+IHRoaW5rIHN1cHBvcnRzIHRoaXMgYXNzZXNzbWVudC4gIEF0IHZlcnkgbGVh c3QgaXQgaGFzIHRoZSBwb3RlbnRpYWwgdG8KPiB3YXN0ZSBhIGxvdCBvZiBtZW50YWwgZW5lcmd5 IGZpZ3VyaW5nIG91dCB3aHkgY29kZSB0aGF0IGxvb2tzIHdyb25nCj4gaXNuJ3Qgd3Jvbmc7IGFu ZCBhdCB3b3JzdCB0aGVyZSdzIGEgcmlzayB0aGF0IGF0IHNvbWUgcG9pbnQgc29tZW9uZQo+IHdp bGwgImZpeCIgaXQgaW5jb3JyZWN0bHkuCj4gCj4gVGhlIGZhY3QgdGhhdCB0aGVyZSBhcmUgYWxy ZWFkeSBtYW55IGluc3RhbmNlcyBvZiB0aGlzIHBhdHRlcm4gaW4gdGhlCj4gc291cmNlIHRyZWUg d291bGQgYmUgcmVsZXZhbnQgaWYgd2UgZXhwZWN0IG5vYm9keSBidXQgcGVvcGxlIGN1cnJlbnRs eQo+IGZhbWlsaWFyIHdpdGggdGhlIGNvZGUgdG8gZXZlcnkgdHJ5IHRvIHJlYWQgb3IgbW9kaWZ5 IGl0LiAgQnV0IHNpbmNlCj4gb24gdGhlIGNvbnRyYXJ5IHdlIGhvcGUgdGhhdCBvdGhlcnMgd2ls bCBjb250cmlidXRlIHRvIHRoZSBjb2RlYmFzZSwKPiBhbmQgZXZlbiB0aGF0IHRoZXkgbWF5IGV2 ZW50dWFsbHkgYmVjb21lIG1haW50YWluZXJzLCBJIHRoaW5rIHRoZXJlIGlzCj4gc2Vuc2UgaW4g YWRkcmVzc2luZyB0aGVtLCBhdCBsZWFzdCBhcyB0aGV5IGNvbWUgdXAuCgpXZWxsLCBpZiB0YWxr IHdhcyBhYm91dCBzb21ldGhpbmcgcmVhbGx5IGNvbXBsZXggaGVyZSwgSSBtaWdodAphZ3JlZS4g QnV0IHVuYXJ5IHByZWZpeCBhbmQgcG9zdGZpeCBvcGVyYXRvcnMgYXJlIGFuIGludGVncmFsCnBh cnQgb2YgdGhlIEMgbGFuZ3VhZ2UsIGFuZCB3aGlsZSBjb2RlIHJlYWRpbmcgaW5kZWVkIHNob3Vs ZG4ndApyZXF1aXJlIG92ZXJseSBtdWNoIG1lbnRhbCBlbmVyZ3ksIEkgdGhpbmsgd2Ugc2hvdWxk IGJlCnBlcm1pdHRlZCB0byBtYWtlIGZ1bGwga25vd2xlZGdlIG9mIHRoZSBiYXNlIHByb2dyYW1t aW5nCmxhbmd1YWdlIGEgcHJlcmVxIHRvIHJlYWRpbmcgb3VyIGNvZGUuIE90aGVyd2lzZSAtIHdo ZXJlIGRvCnlvdSB3YW50IHRvIGRyYXcgdGhlIGJvdW5kYXJ5IG9mIHdoYXQgaXMgcGVybWl0dGVk IGFuZCB3aGF0CmlzIG5vdD8gKFllcywgSSBrbm93IEknbSBndWlsdHkgaW4gb2NjYXNpb25hbGx5 IHdyaXRpbmcgcmF0aGVyCmNvbXBsZXggZXhwcmVzc2lvbnMsIHdpdGggYXQgdGltZXMgbm90IGlt bWVkaWF0ZWx5IG9idmlvdXMgc2lkZQplZmZlY3RzLCBhbmQgSSdtIHRyeWluZyB0byBkbyBiZXR0 ZXIgaXJyZXNwZWN0aXZlIG9mIGFsbCBzdWNoIGFsc28KZmFsbGluZyBpbiB0aGUgYWJvdmUgImJh c2ljIGxhbmd1YWdlIiBmZWF0dXJlcyBjYXRlZ29yeS4gVGhhdCdzCmJlY2F1c2UgSSBjYW4gc2Vl IGRvaW5nIHNvIGJlaW5nIHBhc3QgdGhlIGJvdW5kYXJ5IG9mCnJlYXNvbmFibHkgdW5kZXJzdGFu ZGFibGUgY29kZS4pCgo+IEluIG15IGNhc2UgSSd2ZSBzdWdnZXN0ZWQgYWRkaW5nIGEgY29tbWVu dCB0byBjbHVlIHBlb3BsZSBpbnRvIHRoZQo+IGZhY3QgdGhhdCB0aGUgcG9zdGZpeCBzZW1hbnRp Y3MgYXJlIGluIG9wZXJhdGlvbjsgSSB0aGluayB0aGF0Cj4gYmFsYW5jZXMgInJlZHVjaW5nIGNv Z25pdGl2ZSBsb2FkIiB3aXRoICJhdm9pZHMgdW5uZWNlc3NhcmlseSB2ZXJib3NlCj4gY29kZSIu Cj4gCj4gT3RoZXIgb3B0aW9ucyB3b3VsZCBiZSB0aGluZ3MgbGlrZSB0aGlzOgo+IAo+IGRvIHsK PiAgaS0tOwo+ICBbY2xlYW51cF0KPiB9IHdoaWxlICggaSA+IDAgKTsKPiAKPiBvcgo+IAo+IHdo aWxlICggaSA+IDAgKSB7Cj4gIGktLTsKPiAgW2NsZWFudXBdCj4gfQo+IAo+IFRoZSBmaXJzdCBv bmUgSSB0aGluayBpcyB0aGUgY2xlYXJlc3QsIGJ1dCBuZWl0aGVyIG9uZSBhcmUgdmVyeSBjb25j aXNlLgoKQnV0IHlvdSByZWFsaXplIHRoYXQgdGhlIGZpcnN0IChidXQgbm90IHRoZSBzZWNvbmQp IG9uZSBpcyB3cm9uZyBmb3IKdGhlIGkgPT0gMCBjYXNlPwoKSmFuCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK