From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v3 01/28] xen/x86: Drop unused and non-useful feature definitions Date: Tue, 22 Mar 2016 09:06:37 -0500 Message-ID: <56F1516D.9070602@cardoe.com> References: <1458056124-8024-1-git-send-email-andrew.cooper3@citrix.com> <1458056124-8024-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9121363172185402744==" Return-path: In-Reply-To: <1458056124-8024-2-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9121363172185402744== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2aSP9Pet1TT3UnwdtdfflRc7NtAM9gfNF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2aSP9Pet1TT3UnwdtdfflRc7NtAM9gfNF Content-Type: multipart/mixed; boundary="v9t3x1DgrahxQsGJaOkoDLDi2XB2fWdeQ" From: Doug Goldstein To: Andrew Cooper , Xen-devel Cc: Jan Beulich Message-ID: <56F1516D.9070602@cardoe.com> Subject: Re: [Xen-devel] [PATCH v3 01/28] xen/x86: Drop unused and non-useful feature definitions References: <1458056124-8024-1-git-send-email-andrew.cooper3@citrix.com> <1458056124-8024-2-git-send-email-andrew.cooper3@citrix.com> In-Reply-To: <1458056124-8024-2-git-send-email-andrew.cooper3@citrix.com> --v9t3x1DgrahxQsGJaOkoDLDi2XB2fWdeQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 3/15/16 10:34 AM, Andrew Cooper wrote: > None of these features are interesting for Xen to use, or to be adverti= sed to > guests. Doing so identifies further areas of code which can be removed= now > that 32bit support has been dropped. >=20 > IA64 has a sole user in microcode_intel.c. While it is plausible for a= 32bit > x86 hypervisor to get there via IA64's x86 emulation, a 64bit x86 hyper= visor > most certainly won't. >=20 > MP proves to be more complicated. It is only advertised on some K7 > processors, not on K8 or newer, and now listed as reserved in the AMD m= anual. > Cleaning this up reveals two chunks of common SMP code which was only > applicable to K7 processors, which are 32bit only. >=20 > While cleaning this area up, remove the incosistent use of newlines in = the Konrad already pointed this out. > cpu_has_* definition block. >=20 > Signed-off-by: Andrew Cooper > --- Reviewed-by: Doug Goldstein This patch seems to be a general improvement and doesn't cause other regressions without the rest of the series so can we merged this one. --=20 Doug Goldstein --v9t3x1DgrahxQsGJaOkoDLDi2XB2fWdeQ-- --2aSP9Pet1TT3UnwdtdfflRc7NtAM9gfNF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW8VFwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUCzUP/iM4KwRBD0+UJo4P0dQwxse3 YlMuM+jAtkzc6MaiqEHDGVENQHn8wZ9l6c+CI3dPaxjHFIGuS1K0CBko+3IGC7AA RR9Jm+srtTlWOdZ8fIHAhV/REdwu+prlm0t0KRYq8pFYTJ1KKpekvLD4omQA5Ty7 mI1r0LU6FxV/rF7Tz87n+iXbbo5mXtJbceOm0xDCsYkzAHKqESaaQh5HVT95oy6+ wQkVUjxWH7RpatYS9AnoDbXhX+U9YrvinJiXPAQUFhaA9g/HPV5Xx4qVRalIgcmI KORr2BJBOX54/M5u8TVf+/NvwSdODSDgb8uLWLuyIAixlJQtftJ3Sm5YrYzmmIhz K1baeUaaSuZ5wUGHaaybubw9jFdRGVd/BGTojwbT5cD1sLx6Dy7Rt2yjjEGr0Hjt tS+Gs+Uq+9WZ634FKue4DDaVvqKRlwMqmH9xiKp8bmJcZM+56iB0LvqplZclYHyg nEwu+KbsCgqIebULR3zFIgNnupoatWpzyR6VMyYBW4wr4VDeOmAVc8HeGZkJLCWO 5F6VObuQP6G5Gr5g4s8MJ+Y0B+rWkWB1f9R1cSYv2oZ7vJII+7GTN+uFLGYNzPW2 +W+nPzgb8j0ZLhQ1P1a1atllKXj8ptw6nfiuxFOqK/kl2BJokl1s7fGr2eMMi24O xRnsTpCknVIHi1j5u5Ug =f698 -----END PGP SIGNATURE----- --2aSP9Pet1TT3UnwdtdfflRc7NtAM9gfNF-- --===============9121363172185402744== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============9121363172185402744==--