From: George Dunlap <george.dunlap@citrix.com>
To: Yu Zhang <yu.c.zhang@linux.intel.com>, xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, keir@xen.org, jbeulich@suse.com,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
tim@xen.org, Paul.Durrant@citrix.com, zhiyuan.lv@intel.com,
jun.nakajima@intel.com
Subject: Re: [PATCH 2/3] Rename p2m_mmio_write_dm to p2m_ioreq_server
Date: Tue, 22 Mar 2016 14:15:10 +0000 [thread overview]
Message-ID: <56F1536E.2000504@citrix.com> (raw)
In-Reply-To: <1458130916-30068-1-git-send-email-yu.c.zhang@linux.intel.com>
On 16/03/16 12:21, Yu Zhang wrote:
> Previously p2m type p2m_mmio_write_dm was introduced for write-
> protected memory pages whose write operations are supposed to be
> forwarded to and emulated by an ioreq server. Yet limitations of
> rangeset restricts the number of guest pages to be write-protected.
>
> This patch replace the p2m type p2m_mmio_write_dm with a new name:
> p2m_ioreq_server, which means this p2m type can be claimed by one
> ioreq server, instead of being tracked inside the rangeset of ioreq
> server. Patches following up will add the related hvmop handling
> code which maps type p2m_ioreq_server to an ioreq server.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> ---
[snip]
> @@ -174,7 +174,8 @@ typedef unsigned int p2m_query_t;
>
> #define p2m_is_any_ram(_t) (p2m_to_mask(_t) & \
> (P2M_RAM_TYPES | P2M_GRANT_TYPES | \
> - p2m_to_mask(p2m_map_foreign)))
> + p2m_to_mask(p2m_map_foreign) | \
> + p2m_to_mask(p2m_ioreq_server)))
So this is the only bit that doesn't seem to be a straight rename.
What's the rationale for adding this in this patch?
And in any case, we want to add this to P2M_RAM_TYPES, don't we, so that
p2m_is_ram() returns true?
For example, if p2m_ioreq_server is *not* marked as p2m_is_ram(), then
when it's ballooned out the m2p mapping won't be updated properly (see
xen/arch/x86/mm/p2m.c:set_typed_p2m_entry()); and it looks like there
could be issues with emulation when running in shadow mode (see
xen/arch/x86/mm/common.c:emulate_gva_to_mfn()). Other examples of this
sort of thing abound.
Everything else looks fine to me.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-22 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 12:21 [PATCH 2/3] Rename p2m_mmio_write_dm to p2m_ioreq_server Yu Zhang
2016-03-22 14:15 ` George Dunlap [this message]
2016-03-23 6:30 ` Yu, Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F1536E.2000504@citrix.com \
--to=george.dunlap@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).