From: Julien Grall <julien.grall@arm.com> To: Shannon Zhao <zhaoshenglong@huawei.com>, xen-devel@lists.xen.org Cc: stefano.stabellini@citrix.com, shannon.zhao@linaro.org, peter.huangpeng@huawei.com Subject: Re: [PATCH v6 15/22] arm/acpi: Permit access all Xen unused SPIs for Dom0 Date: Tue, 22 Mar 2016 18:18:52 +0000 [thread overview] Message-ID: <56F18C8C.5070203@arm.com> (raw) In-Reply-To: <1458207668-12012-16-git-send-email-zhaoshenglong@huawei.com> Hi Shannon, On 17/03/16 09:41, Shannon Zhao wrote: > From: Shannon Zhao <shannon.zhao@linaro.org> > > Permit access all Xen unused SPIs for Dom0 except the interrupts that > Xen uses. You say exactly the same things with all "Xen unused SPIs for Dom0" and "except the interrupts that Xen uses". I would instead say: "Allow DOM0 to use all SPIs but the ones used by Xen." > Then when Dom0 configures the interrupt, it could set the > interrupt type and route it to Dom0. > > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org> > Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > xen/arch/arm/domain_build.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 6726e45..1e5ee0e 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1359,6 +1359,33 @@ static int prepare_dtb(struct domain *d, struct kernel_info *kinfo) > #ifdef CONFIG_ACPI > #define ACPI_DOM0_FDT_MIN_SIZE 4096 > > +static int acpi_permit_spi_access(struct domain *d) > +{ > + int i, res; > + struct irq_desc *desc; > + > + /* Here just permit Dom0 to access the SPIs which Xen doesn't use. Then when Coding style: /* * FOo * Bar */ > + * Dom0 configures the interrupt, set the interrupt type and route it to > + * Dom0. > + */ > + for( i = NR_LOCAL_IRQS; i < vgic_num_irqs(d); i++ ) > + { > + desc = irq_to_desc(i); > + if( desc->action != NULL) Well some of the SPIs used by Xen may not be registered yet. For instance the SMMU driver doesn't register any SPIs until it's necessary (i.e a device is assigned to a domain). > + continue; > + > + res = irq_permit_access(d, i); > + if ( res ) > + { > + printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", > + d->domain_id, i); > + return res; > + } > + } > + > + return 0; > +} > + > static int make_chosen_node(const struct kernel_info *kinfo, > struct membank tbl_add[]) > { > @@ -1849,6 +1876,10 @@ static int prepare_acpi(struct domain *d, struct kernel_info *kinfo) > if ( rc != 0 ) > return rc; > > + rc = acpi_permit_spi_access(d); > + if ( rc != 0 ) > + return rc; > + > return 0; > } > #else > -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-22 18:18 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 9:40 [PATCH v6 00/22] Prepare UEFI and ACPI tables for Dom0 on ARM64 Shannon Zhao 2016-03-17 9:40 ` [PATCH v6 01/22] arm/acpi: Estimate memory required for acpi/efi tables Shannon Zhao 2016-03-18 18:44 ` Julien Grall 2016-03-21 13:01 ` Jan Beulich 2016-03-22 13:01 ` Shannon Zhao 2016-03-22 0:28 ` Julien Grall 2016-03-24 12:36 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 02/22] arm/acpi: Add a helper function to get the acpi table offset Shannon Zhao 2016-03-21 12:16 ` Julien Grall 2016-03-24 12:32 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 03/22] arm/acpi: Prepare FADT table for Dom0 Shannon Zhao 2016-03-21 12:25 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 04/22] arm/gic: Add a new callback for creating MADT " Shannon Zhao 2016-03-21 15:18 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 05/22] arm/acpi: Prepare " Shannon Zhao 2016-03-21 15:26 ` Julien Grall 2016-03-21 15:51 ` Jan Beulich 2016-03-17 9:40 ` [PATCH v6 06/22] arm/acpi: Prepare STAO " Shannon Zhao 2016-03-21 15:31 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 07/22] arm/acpi: Prepare XSDT " Shannon Zhao 2016-03-21 15:43 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 08/22] arm/acpi: Prepare RSDP " Shannon Zhao 2016-03-21 15:47 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 09/22] arm/p2m: Add helper functions to map memory regions Shannon Zhao 2016-03-21 15:52 ` Julien Grall 2016-03-22 13:05 ` Shannon Zhao 2016-03-22 15:59 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 10/22] arm/acpi: Map all other tables for Dom0 Shannon Zhao 2016-03-21 15:57 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 11/22] arm/acpi: Prepare EFI system table " Shannon Zhao 2016-03-21 16:10 ` Julien Grall 2016-03-22 13:06 ` Shannon Zhao 2016-03-22 13:24 ` Jan Beulich 2016-03-17 9:40 ` [PATCH v6 12/22] arm/acpi: Prepare EFI memory descriptor " Shannon Zhao 2016-03-21 16:51 ` Julien Grall 2016-03-22 13:16 ` Shannon Zhao 2016-03-22 16:04 ` Julien Grall 2016-03-24 15:06 ` Shannon Zhao 2016-03-24 15:23 ` Julien Grall 2016-03-24 12:39 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 13/22] arm/acpi: Map the new created EFI and ACPI tables to Dom0 Shannon Zhao 2016-03-22 0:42 ` Julien Grall 2016-03-22 13:18 ` Shannon Zhao 2016-03-22 16:16 ` Julien Grall 2016-03-24 14:59 ` Shannon Zhao 2016-03-24 15:35 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 14/22] arm/acpi: Create min DT stub for Dom0 Shannon Zhao 2016-03-22 1:07 ` Julien Grall 2016-03-22 13:23 ` Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 15/22] arm/acpi: Permit access all Xen unused SPIs " Shannon Zhao 2016-03-22 18:18 ` Julien Grall [this message] 2016-03-24 15:01 ` Shannon Zhao 2016-03-24 15:37 ` Julien Grall 2016-03-25 7:13 ` Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 16/22] arm/acpi: Configure SPI interrupt type and route to Dom0 dynamically Shannon Zhao 2016-03-22 19:17 ` Julien Grall 2016-03-24 12:41 ` Stefano Stabellini 2016-03-17 9:41 ` [PATCH v6 17/22] arm/gic: Add a new callback to deny Dom0 access to GIC regions Shannon Zhao 2016-03-22 19:33 ` Julien Grall 2016-03-24 12:45 ` Stefano Stabellini 2016-03-24 15:03 ` Shannon Zhao 2016-03-24 15:39 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 18/22] arm/acpi: Permit MMIO access of Xen unused devices for Dom0 Shannon Zhao 2016-03-23 11:50 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 19/22] hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao 2016-03-17 10:42 ` Jan Beulich 2016-03-17 11:04 ` Shannon Zhao 2016-03-17 11:29 ` Jan Beulich 2016-03-17 11:56 ` Shannon Zhao 2016-03-17 12:42 ` Jan Beulich 2016-03-17 9:41 ` [PATCH v6 20/22] xen/acpi: Fix event-channel interrupt when booting with ACPI Shannon Zhao 2016-03-23 12:15 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 21/22] xen/arm: Add a hypercall for device mmio mapping Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 22/22] xen/arm64: Add ACPI support Shannon Zhao 2016-03-17 10:52 ` Jan Beulich 2016-03-17 11:03 ` Shannon Zhao 2016-03-17 11:31 ` Jan Beulich 2016-03-17 13:10 ` Shannon Zhao 2016-03-17 13:24 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56F18C8C.5070203@arm.com \ --to=julien.grall@arm.com \ --cc=peter.huangpeng@huawei.com \ --cc=shannon.zhao@linaro.org \ --cc=stefano.stabellini@citrix.com \ --cc=xen-devel@lists.xen.org \ --cc=zhaoshenglong@huawei.com \ --subject='Re: [PATCH v6 15/22] arm/acpi: Permit access all Xen unused SPIs for Dom0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).