From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Firas Azar <firas.azar@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] pygrub: remove isconfig option
Date: Tue, 22 Mar 2016 16:54:59 -0400 [thread overview]
Message-ID: <56F1B123.1050101@oracle.com> (raw)
In-Reply-To: <56F1AF2C.6040400@oracle.com>
On 03/22/2016 04:46 PM, Firas Azar wrote:
> Andrew:
>
> Currently if we use pygrub --isconfig <image>, there is a good chance
> that this command could fail with an "out of memory" error. This can
> happen especially if the image file in question is at least a few
> gigabytes in size and the dom0_mem setting is relatively small. So
> even if any software used this option it is likely it would fail. This
> problem is due to the parser using "readlines" function in
> GrubConf.py, which attempts to load the entire file into memory.
FWIW, the same problem is observed on unstable. Running this option
results in very high disk IO rate and eventually OOM killer wakes up and
whacks pygrub.
So chances are this has been broken for a while since I believe Firas is
working with 4.4. I haven't tried anything other than unstable though.
-boris
>
> The advantage of "-l -n" option is that it exercises the "real" code
> path, which boots the PV guests.
>
> Regards
>
> --Firas
>
> On 03/22/2016 04:22 PM, Andrew Cooper wrote:
>> On 22/03/16 20:06, Firas Azar wrote:
>>> The pygrub command option "isconfig" is broken and obsolete. This
>>> patch removes it since the alternate options "-l -n" provide the
>>> same functionality.
>> Broken how?
>>
>> Are you sure that no existing software is using that option?
>>
>> ~Andrew
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-22 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 20:06 [PATCH] pygrub: remove isconfig option Firas Azar
2016-03-22 20:22 ` Andrew Cooper
2016-03-22 20:46 ` Firas Azar
2016-03-22 20:54 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F1B123.1050101@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=firas.azar@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).