Re: [PATCH 05/16] xen: sched: move pCPU initialization in an helper

[George Dunlap <george.dunlap@citrix.com>]

On 18/03/16 19:04, Dario Faggioli wrote:
> That will turn out useful in following patches, where such
> code will need to be called more than just once. Create an
> helper now, and move the code there, to avoid mixing code
> motion and functional changes later.
> 
> In Credit2, some style cleanup is also done.
> 
> No functional change intended.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> ---
>  xen/common/sched_credit.c  |   22 +++++++++++++---------
>  xen/common/sched_credit2.c |   26 ++++++++++++++++----------
>  2 files changed, 29 insertions(+), 19 deletions(-)
> 
> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> index d4a0f5e..4488d7c 100644
> --- a/xen/common/sched_credit.c
> +++ b/xen/common/sched_credit.c
> @@ -542,16 +542,11 @@ csched_alloc_pdata(const struct scheduler *ops, int cpu)
>  }
>  
>  static void
> -csched_init_pdata(const struct scheduler *ops, void *pdata, int cpu)
> +init_pdata(struct csched_private *prv, struct csched_pcpu *spc, int cpu)
>  {
> -    struct csched_private *prv = CSCHED_PRIV(ops);
> -    struct csched_pcpu * const spc = pdata;
> -    unsigned long flags;
> -
> -    /* cpu data needs to be allocated, but STILL uninitialized */
> -    ASSERT(spc && spc->runq.next == spc->runq.prev && spc->runq.next == NULL);
> -
> -    spin_lock_irqsave(&prv->lock, flags);
> +    ASSERT(spin_is_locked(&prv->lock));
> +    /* cpu data needs to be allocated, but STILL uninitialized. */
> +    ASSERT(spc && spc->runq.next == NULL && spc->runq.prev == NULL);

Actually, Juergen, looks like Dario already agrees with us. ;-)

Obviously this should be updated in the previous patch instead.

With that done:

Reviewed-by: George Dunlap <george.dunlap@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel