From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 09/16] xen: sched: close potential races when switching scheduler to CPUs Date: Wed, 23 Mar 2016 19:05:27 +0000 Message-ID: <56F2E8F7.4000200@citrix.com> References: <20160318185524.8117.74837.stgit@Solace.station> <20160318190505.8117.89778.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aio6T-0001KY-A2 for xen-devel@lists.xenproject.org; Wed, 23 Mar 2016 19:06:01 +0000 In-Reply-To: <20160318190505.8117.89778.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: George Dunlap , Tianyang Chen , Meng Xu List-Id: xen-devel@lists.xenproject.org T24gMTgvMDMvMTYgMTk6MDUsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOgo+IGJ5IHVzaW5nIHRoZSBz Y2hlZF9zd2l0Y2ggaG9vayB0aGF0IHdlIGhhdmUgaW50cm9kdWNlZCBpbgo+IHRoZSB2YXJpb3Vz IHNjaGVkdWxlcnMuCj4gCj4gVGhlIGtleSBpcyB0byBsZXQgdGhlIGFjdHVhbCBzd2l0Y2ggb2Yg c2NoZWR1bGVyIGFuZCB0aGUKPiByZW1hcHBpbmcgb2YgdGhlIHNjaGVkdWxlciBsb2NrIGZvciB0 aGUgQ1BVIChpZiBuZWNlc3NhcnkpCj4gaGFwcGVuIHRvZ2V0aGVyIChpbiB0aGUgc2FtZSBjcml0 aWNhbCBzZWN0aW9uKSBwcm90ZWN0ZWQKPiAoYXQgbGVhc3QpIGJ5IHRoZSBvbGQgc2NoZWR1bGVy IGxvY2sgZm9yIHRoZSBDUFUuCj4gCj4gVGhpcyBhbHNvIG1lYW5zIHRoYXQsIGluIENyZWRpdDIg YW5kIFJURFMsIHdlIGNhbiBnZXQgcmlkCj4gb2YgdGhlIGNvZGUgdGhhdCB3YXMgZG9pbmcgdGhl IHNjaGVkdWxlciBsb2NrIHJlbWFwcGluZwo+IGluIGNzY2hlZDJfZnJlZV9wZGF0YSgpIGFuZCBy dF9mcmVlX3BkYXRhKCksIGFuZCBvZiB0aGVpcgo+IHRyaWdnZXJpbmcgQVNTRVJULXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogRGFyaW8gRmFnZ2lvbGkgPGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+ CgpTaW1pbGFyIHRvIG15IGNvbW1lbnQgYmVmb3JlIC0tIGluIG15IG93biB0cmVlIEkgc3F1YXNo ZWQgcGF0Y2hlcyA2LTkKaW50byBhIHNpbmdsZSBjb21taXQgYW5kIGZvdW5kIGl0IG11Y2ggZWFz aWVyIHRvIHJldmlldy4gOi0pCgpPbmUgaW1wb3J0YW50IHF1ZXN0aW9uLi4uCgo+IGRpZmYgLS1n aXQgYS94ZW4vY29tbW9uL3NjaGVkdWxlLmMgYi94ZW4vY29tbW9uL3NjaGVkdWxlLmMKPiBpbmRl eCAxYWRjMGUyLi4yOTU4MmE2IDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vc2NoZWR1bGUuYwo+ ICsrKyBiL3hlbi9jb21tb24vc2NoZWR1bGUuYwo+IEBAIC0xNjE3LDcgKzE2MTcsNiBAQCB2b2lk IF9faW5pdCBzY2hlZHVsZXJfaW5pdCh2b2lkKQo+ICBpbnQgc2NoZWR1bGVfY3B1X3N3aXRjaCh1 bnNpZ25lZCBpbnQgY3B1LCBzdHJ1Y3QgY3B1cG9vbCAqYykKPiAgewo+ICAgICAgc3RydWN0IHZj cHUgKmlkbGU7Cj4gLSAgICBzcGlubG9ja190ICpsb2NrOwo+ICAgICAgdm9pZCAqcHByaXYsICpw cHJpdl9vbGQsICp2cHJpdiwgKnZwcml2X29sZDsKPiAgICAgIHN0cnVjdCBzY2hlZHVsZXIgKm9s ZF9vcHMgPSBwZXJfY3B1KHNjaGVkdWxlciwgY3B1KTsKPiAgICAgIHN0cnVjdCBzY2hlZHVsZXIg Km5ld19vcHMgPSAoYyA9PSBOVUxMKSA/ICZvcHMgOiBjLT5zY2hlZDsKPiBAQCAtMTY0MCwxMSAr MTYzOSwyMSBAQCBpbnQgc2NoZWR1bGVfY3B1X3N3aXRjaCh1bnNpZ25lZCBpbnQgY3B1LCBzdHJ1 Y3QgY3B1cG9vbCAqYykKPiAgICAgIGlmICggb2xkX29wcyA9PSBuZXdfb3BzICkKPiAgICAgICAg ICBnb3RvIG91dDsKPiAgCj4gKyAgICAvKgo+ICsgICAgICogVG8gc2V0dXAgdGhlIGNwdSBmb3Ig dGhlIG5ldyBzY2hlZHVsZXIgd2UgbmVlZDoKPiArICAgICAqICAtIGEgdmFsaWQgaW5zdGFuY2Ug b2YgcGVyLUNQVSBzY2hlZHVsZXIgc3BlY2lmaWMgZGF0YSwgYXMgaXQgaXMKPiArICAgICAqICAg IGFsbG9jYXRlZCBieSBTQ0hFRF9PUChhbGxvY19wZGF0YSkuIE5vdGUgdGhhdCB3ZSBkbyBub3Qg d2FudCB0bwo+ICsgICAgICogICAgaW5pdGlhbGl6ZSBpdCB5ZXQgKGkuZS4sIHdlIGFyZSBub3Qg Y2FsbGluZyBTQ0hFRF9PUChpbml0X3BkYXRhKSkuCj4gKyAgICAgKiAgICBUaGF0IHdpbGwgYmUg ZG9uZSBieSB0aGUgdGFyZ2V0IHNjaGVkdWxlciwgaW4gU0NIRURfT1Aoc3dpdGNoX3NjaGVkKSwK PiArICAgICAqICAgIGluIHByb3BlciBvcmRlcmluZyBhbmQgd2l0aCBsb2NraW5nLgo+ICsgICAg ICogIC0gYSB2YWxpZCBpbnN0YW5jZSBvZiBwZXItdkNQVSBzY2hlZHVsZXIgc3BlY2lmaWMgZGF0 YSwgZm9yIHRoZSBpZGxlCj4gKyAgICAgKiAgICB2Q1BVIG9mIGNwdS4gVGhhdCBpcyB3aGF0IHRo ZSB0YXJnZXQgc2NoZWR1bGVyIHdpbGwgdXNlIGZvciB0aGUKPiArICAgICAqICAgIHNjaGVkX3By aXYgZmllbGQgb2YgdGhlIHBlci12Q1BVIGluZm8gb2YgdGhlIGlkbGUgZG9tYWluLgo+ICsgICAg ICovCj4gICAgICBpZGxlID0gaWRsZV92Y3B1W2NwdV07Cj4gICAgICBwcHJpdiA9IFNDSEVEX09Q KG5ld19vcHMsIGFsbG9jX3BkYXRhLCBjcHUpOwo+ICAgICAgaWYgKCBJU19FUlIocHByaXYpICkK PiAgICAgICAgICByZXR1cm4gUFRSX0VSUihwcHJpdik7Cj4gLSAgICBTQ0hFRF9PUChuZXdfb3Bz LCBpbml0X3BkYXRhLCBwcHJpdiwgY3B1KTsKPiAgICAgIHZwcml2ID0gU0NIRURfT1AobmV3X29w cywgYWxsb2NfdmRhdGEsIGlkbGUsIGlkbGUtPmRvbWFpbi0+c2NoZWRfcHJpdik7Cj4gICAgICBp ZiAoIHZwcml2ID09IE5VTEwgKQo+ICAgICAgewo+IEBAIC0xNjUyLDE3ICsxNjYxLDIwIEBAIGlu dCBzY2hlZHVsZV9jcHVfc3dpdGNoKHVuc2lnbmVkIGludCBjcHUsIHN0cnVjdCBjcHVwb29sICpj KQo+ICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ICAgICAgfQo+ICAKPiAtICAgIGxvY2sgPSBw Y3B1X3NjaGVkdWxlX2xvY2tfaXJxKGNwdSk7Cj4gLQo+ICAgICAgU0NIRURfT1Aob2xkX29wcywg dGlja19zdXNwZW5kLCBjcHUpOwo+ICsKPiArICAgIC8qCj4gKyAgICAgKiBUaGUgYWN0dWFsIHN3 aXRjaCwgaW5jbHVkaW5nIChpZiBuZWNlc3NhcnkpIHRoZSByZXJvdXRpbmcgb2YgdGhlCj4gKyAg ICAgKiBzY2hlZHVsZXIgbG9jayB0byB3aGF0ZXZlciBuZXdfb3BzIHByZWZlcnMsICBuZWVkcyB0 byBoYXBwZW4gaW4gb25lCj4gKyAgICAgKiBjcml0aWNhbCBzZWN0aW9uLCBwcm90ZWN0ZWQgYnkg b2xkX29wcycgbG9jaywgb3IgcmFjZXMgYXJlIHBvc3NpYmxlLgo+ICsgICAgICogU2luY2UgZWFj aCBzY2hlZHVsZXIgaGFzIGl0cyBvd24gY29udHJhaW50cyBhbmQgbG9ja2luZyBzY2hlbWUsIGRv Cj4gKyAgICAgKiB0aGF0IGluc2lkZSBzcGVjaWZpYyBzY2hlZHVsZXIgY29kZSwgcmF0aGVyIHRo YW4gaGVyZS4KPiArICAgICAqLwo+ICAgICAgdnByaXZfb2xkID0gaWRsZS0+c2NoZWRfcHJpdjsK PiAtICAgIGlkbGUtPnNjaGVkX3ByaXYgPSB2cHJpdjsKPiAtICAgIHBlcl9jcHUoc2NoZWR1bGVy LCBjcHUpID0gbmV3X29wczsKPiAgICAgIHBwcml2X29sZCA9IHBlcl9jcHUoc2NoZWR1bGVfZGF0 YSwgY3B1KS5zY2hlZF9wcml2Owo+IC0gICAgcGVyX2NwdShzY2hlZHVsZV9kYXRhLCBjcHUpLnNj aGVkX3ByaXYgPSBwcHJpdjsKPiAtICAgIFNDSEVEX09QKG5ld19vcHMsIHRpY2tfcmVzdW1lLCBj cHUpOwo+ICsgICAgU0NIRURfT1AobmV3X29wcywgc3dpdGNoX3NjaGVkLCBjcHUsIHBwcml2LCB2 cHJpdik7CgpJcyBpdCByZWFsbHkgc2FmZSB0byByZWFkIHNjaGVkX3ByaXYgd2l0aG91dCB0aGUg bG9jayBoZWxkPwoKIC1HZW9yZ2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5v cmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==