xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	xen devel <xen-devel@lists.xen.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v12 14/26] primary vm suspend/resume/checkpoint code
Date: Fri, 25 Mar 2016 10:00:47 +0800	[thread overview]
Message-ID: <56F49BCF.7090505@cn.fujitsu.com> (raw)
In-Reply-To: <22260.1684.738874.417138@mariner.uk.xensource.com>

On 03/24/2016 11:24 PM, Ian Jackson wrote:
> Changlong Xie writes ("[PATCH v12 14/26] primary vm suspend/resume/checkpoint code"):
>> From: Wen Congyang <wency@cn.fujitsu.com>
> ...
>
> Thanks.  Most of this seems plausible (although I have done a review
> of rather limited depth):
>
> However, there are several instances like this:
>
>> +out:
>> +    libxl__ao_complete(egc, ao, ERROR_FAIL);

Will use xxx->callback();

Thanks
	-Xie

>> +}
>
> libxl__ao_complete must not be called by some internal function in
> this way.  Only the same layer within libxl that called AO_CREATE is
> allowed to call libxl__ao_complete.
>
> Errors should be propagated by having the _setup function make the
> callback with the appropriate error code.  Eventually, the error will
> propagate out (possibly via a series of callbacks and error handling
> paths) to the same layer as called AO_CREATE.
>
> See remus_setup_done and remus_setup_failed for examples.
>
> You also need to make sure that when the setup fails, appropriate
> teardown is done.  In the remus case this includes invoking
> libxl__checkpoint_devices_teardown, and chaining through to a second
> callback.
>
> Thanks,
> Ian.
>
>
> .
>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-25  2:00 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23  8:06 [PATCH v12 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service Changlong Xie
2016-03-23  8:06 ` [PATCH v12 01/26] tools/libxl: introduction of libxl__qmp_restore to load qemu state Changlong Xie
2016-03-23  8:06 ` [PATCH v12 02/26] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Changlong Xie
2016-03-23  8:06 ` [PATCH v12 03/26] tools/libxl: Add back channel to allow migration target send data back Changlong Xie
2016-03-23  8:06 ` [PATCH v12 04/26] tools/libxl: Introduce new helper function dup_fd_helper() Changlong Xie
2016-03-23  8:06 ` [PATCH v12 05/26] tools/libx{l, c}: add back channel to libxc Changlong Xie
2016-03-23  8:06 ` [PATCH v12 06/26] docs: add colo readme Changlong Xie
2016-03-23  8:06 ` [PATCH v12 07/26] docs/libxl: Introduce CHECKPOINT_CONTEXT to support migration v2 colo streams Changlong Xie
2016-03-24 14:53   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 08/26] libxc/migration: Specification update for DIRTY_PFN_LIST records Changlong Xie
2016-03-24 14:56   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 09/26] libxc/migration: export read_record for common use Changlong Xie
2016-03-23  8:06 ` [PATCH v12 10/26] tools/libxl: add back channel support to write stream Changlong Xie
2016-03-24 16:49   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 11/26] tools/libxl: add back channel support to read stream Changlong Xie
2016-03-24 14:57   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 12/26] secondary vm suspend/resume/checkpoint code Changlong Xie
2016-03-24 15:15   ` Ian Jackson
2016-03-25  2:00     ` Changlong Xie
2016-03-23  8:06 ` [PATCH v12 13/26] libxl_internal: move stream read manipulations to right place Changlong Xie
2016-03-24 15:17   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 14/26] primary vm suspend/resume/checkpoint code Changlong Xie
2016-03-24 15:24   ` Ian Jackson
2016-03-25  2:00     ` Changlong Xie [this message]
2016-03-25  6:33     ` Changlong Xie
2016-03-23  8:06 ` [PATCH v12 15/26] libxc/restore: support COLO restore Changlong Xie
2016-03-24 15:27   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 16/26] libxc/save: support COLO save Changlong Xie
2016-03-24 15:28   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 17/26] implement the cmdline for COLO Changlong Xie
2016-03-24 15:34   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 18/26] COLO: introduce new API to prepare/start/do/get_error/stop replication Changlong Xie
2016-03-23  8:06 ` [PATCH v12 19/26] Introduce COLO mode and refactor relevant function Changlong Xie
2016-03-24 15:45   ` Ian Jackson
2016-03-25  2:02     ` Changlong Xie
2016-03-23  8:06 ` [PATCH v12 20/26] Support colo mode for qemu disk Changlong Xie
2016-03-23  8:06 ` [PATCH v12 21/26] COLO: use qemu block replication Changlong Xie
2016-03-24 15:54   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 22/26] COLO proxy: implement setup/teardown/preresume/postresume/checkpoint Changlong Xie
2016-03-24 15:59   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 23/26] COLO nic: implement COLO nic subkind Changlong Xie
2016-03-24 16:05   ` Ian Jackson
2016-03-25  2:29     ` Changlong Xie
2016-03-25  6:09     ` Changlong Xie
2016-03-25 12:23       ` Wei Liu
2016-03-28  3:20         ` Changlong Xie
2016-03-23  8:06 ` [PATCH v12 24/26] setup and control colo proxy on primary side Changlong Xie
2016-03-24 16:06   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 25/26] setup and control colo proxy on secondary side Changlong Xie
2016-03-24 16:06   ` Ian Jackson
2016-03-23  8:06 ` [PATCH v12 26/26] cmdline switches and config vars to control colo-proxy Changlong Xie
2016-03-24 16:12   ` Ian Jackson
2016-03-25  2:57     ` Changlong Xie
2016-03-25  6:10     ` Changlong Xie
2016-03-25 12:29       ` Wei Liu
2016-03-28  3:21         ` Changlong Xie
2016-03-24 16:21 ` [PATCH v12 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service Ian Jackson
2016-03-24 16:43   ` Lars Kurth
2016-03-24 17:06   ` Wei Liu
2016-03-24 17:07     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F49BCF.7090505@cn.fujitsu.com \
    --to=xiecl.fnst@cn.fujitsu.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=ian.campbell@citrix.com \
    --cc=lars.kurth@citrix.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).