xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Chun Yan Liu <cyliu@suse.com>, xen-devel@lists.xen.org
Cc: George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v3 4/5] libxl: check for dynamic device model start required
Date: Fri, 25 Mar 2016 07:25:26 +0100	[thread overview]
Message-ID: <56F4D9D6.8030300@suse.com> (raw)
In-Reply-To: <56F50DC102000066000C0EF4@suse.com>

On 25/03/16 03:06, Chun Yan Liu wrote:
> 
> 
>>>> On 3/23/2016 at 08:24 PM, in message
> <1458735847-9448-5-git-send-email-jgross@suse.com>, Juergen Gross
> <jgross@suse.com> wrote: 
>> Add a service routine checking whether a device model must be started 
>> after adding a device to a domain. 
>>  
>> Signed-off-by: Juergen Gross <jgross@suse.com> 
>> --- 
>>  tools/libxl/libxl.c          | 12 ++++++++++++ 
>>  tools/libxl/libxl_dm.c       | 14 ++++++++++++++ 
>>  tools/libxl/libxl_internal.h |  4 ++++ 
>>  tools/libxl/libxl_pci.c      |  3 +++ 
>>  tools/libxl/libxl_pvusb.c    |  6 ++++++ 
>>  5 files changed, 39 insertions(+) 
>>  
>> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c 
>> index dcd0951..2b4e36f 100644 
>> --- a/tools/libxl/libxl.c 
>> +++ b/tools/libxl/libxl.c 
>> @@ -2084,6 +2084,9 @@ void libxl__device_vtpm_add(libxl__egc *egc, uint32_t  
>> domid, 
>>          if (rc) goto out; 
>>   
>>          DEVICE_ADD(vtpm, vtpms, domid, &vtpm_saved, COMPARE_DEVID,  
>> &d_config); 
>> + 
>> +        rc = libxl__dm_check_start(gc, &d_config, domid); 
>> +        if (rc) goto out; 
>>      }
> 
> Why is this check put inside the if (aodev->update_json) {  }? I think it's a common
> check, so should move outside.

It is the only case where the check makes sense: update_json isn't set
when we are just creating the domain, in which case the test for the
device model needed is already in place. When the device is added to an
already running domain update_json will always be true.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-03-25  6:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 12:24 [PATCH v3 0/5] libxl: add support for qemu base pvusb backend Juergen Gross
2016-03-23 12:24 ` [PATCH v3 1/5] libxl: make libxl__need_xenpv_qemu() operate on domain config Juergen Gross
2016-03-24 20:28   ` Wei Liu
2016-03-25  6:13     ` Juergen Gross
2016-03-23 12:24 ` [PATCH v3 2/5] libxl: add new pvusb backend "qusb" provided by qemu Juergen Gross
2016-03-25  2:23   ` Chun Yan Liu
     [not found]   ` <56F5119C02000066000C0F24@suse.com>
2016-03-25  6:29     ` Juergen Gross
2016-03-25  6:38       ` Chun Yan Liu
2016-03-23 12:24 ` [PATCH v3 3/5] libxl: add service function to check whether device model is running Juergen Gross
2016-03-24 20:28   ` Wei Liu
2016-03-23 12:24 ` [PATCH v3 4/5] libxl: check for dynamic device model start required Juergen Gross
2016-03-25  2:06   ` Chun Yan Liu
     [not found]   ` <56F50DC102000066000C0EF4@suse.com>
2016-03-25  6:25     ` Juergen Gross [this message]
2016-03-25  6:29       ` Chun Yan Liu
2016-03-23 12:24 ` [PATCH v3 5/5] libxl: add domain config parameter to force start of qemu Juergen Gross
2016-03-24 20:28   ` Wei Liu
2016-03-24 20:35     ` Wei Liu
2016-03-25  6:20       ` Juergen Gross
2016-03-25  6:16     ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F4D9D6.8030300@suse.com \
    --to=jgross@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=cyliu@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).