xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, david.vrabel@citrix.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead()
Date: Fri, 25 Mar 2016 11:08:32 -0400	[thread overview]
Message-ID: <56F55470.5090004@oracle.com> (raw)
In-Reply-To: <20160325145358.GC17902@char.us.oracle.com>

On 03/25/2016 10:53 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Mar 17, 2016 at 09:03:25AM -0400, Boris Ostrovsky wrote:
>> This call has always been missing from xen_play dead() but until
>> recently this was rather benign. With new cpu hotplug framework
>> however this call is required, otherwise a hot-plugged CPU will not
> Could you include the commit id of the 'new cpu hotplug' in case
> anybody wants to backport this?

Sure.

It's commit 8df3e07e7f21 ("cpu/hotplug: Let upcoming cpu bring itself 
fully up").

Do you (or David) want me to re-send it?

-boris



>
> Thanks!
>> be properly brough up (by never calling cpuhp_online_idle())
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>>   arch/x86/xen/smp.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
>> index 3c6d17f..719cf29 100644
>> --- a/arch/x86/xen/smp.c
>> +++ b/arch/x86/xen/smp.c
>> @@ -545,6 +545,8 @@ static void xen_play_dead(void) /* used only with HOTPLUG_CPU */
>>   	 * data back is to call:
>>   	 */
>>   	tick_nohz_idle_enter();
>> +
>> +	cpu_startup_entry(CPUHP_AP_ONLINE_IDLE);
>>   }
>>   
>>   #else /* !CONFIG_HOTPLUG_CPU */
>> -- 
>> 1.7.1
>>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-25 15:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1458219805-13197-1-git-send-email-boris.ostrovsky@oracle.com>
2016-03-17 13:03 ` [PATCH 1/2] xen/apic: Provide Xen-specific version of cpu_present_to_apicid APIC op Boris Ostrovsky
2016-03-17 13:03 ` [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead() Boris Ostrovsky
     [not found] ` <1458219805-13197-2-git-send-email-boris.ostrovsky@oracle.com>
2016-03-25 14:52   ` [PATCH 1/2] xen/apic: Provide Xen-specific version of cpu_present_to_apicid APIC op Konrad Rzeszutek Wilk
     [not found] ` <1458219805-13197-3-git-send-email-boris.ostrovsky@oracle.com>
2016-03-25 14:53   ` [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead() Konrad Rzeszutek Wilk
2016-03-25 15:08     ` Boris Ostrovsky [this message]
2016-03-25 15:45       ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F55470.5090004@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).