From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/hvm/viridian: save APIC assist vector
Date: Tue, 29 Mar 2016 03:53:24 -0600 [thread overview]
Message-ID: <56FA6CB402000078000E0C77@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1459243805-2150-1-git-send-email-paul.durrant@citrix.com>
>>> On 29.03.16 at 11:30, <paul.durrant@citrix.com> wrote:
> If any vcpu has a pending APIC assist when the domain is suspended
> then the vector needs to be saved. If this is not done then it's
> possible for the vector to remain pending in the vlapic ISR
> indefinitely after resume.
>
> This patch adds code to save the APIC assist vector value in the
> viridian vcpu save record. This means that the record is now zero-
> extended on load and, because this implies a loaded value of
> zero means nothing is pending (for backwards compatibility with
> hosts not implementing APIC assist), the rest of the viridian APIC
> assist code is adjusted to treat a zero value in this way. A
> check has therefore been added to viridian_start_apic_assist() to
> prevent the enlightenment being used for vectors < 0x10 (which
> are illegal for an APIC).
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Are you then also looking into the domain page leaks which seem
likely to stem from the earlier APIC assist change?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-29 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 9:30 [PATCH v2] x86/hvm/viridian: save APIC assist vector Paul Durrant
2016-03-29 9:53 ` Jan Beulich [this message]
2016-03-29 9:58 ` Paul Durrant
2016-03-29 10:22 ` Paul Durrant
2016-03-30 6:18 ` Jan Beulich
2016-03-30 8:23 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA6CB402000078000E0C77@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).