From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 3/7] oxenstored: refactor request processing Date: Tue, 29 Mar 2016 08:45:07 -0400 Message-ID: <56FA78D3.4070400@oracle.com> References: <1458237075-13777-1-git-send-email-jonathan.davies@citrix.com> <1458237075-13777-4-git-send-email-jonathan.davies@citrix.com> <56F468A5.9080609@oracle.com> <56F46EFA.9060204@citrix.com> <56F47EEA.3070103@oracle.com> <20160329090829.GE3316@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akt18-0003Ll-Vc for xen-devel@lists.xenproject.org; Tue, 29 Mar 2016 12:45:07 +0000 In-Reply-To: <20160329090829.GE3316@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jonathan Davies Cc: Andrew Cooper , Jon Ludlam , Dave Scott , Euan Harris , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMDMvMjkvMjAxNiAwNTowOCBBTSwgSm9uYXRoYW4gRGF2aWVzIHdyb3RlOgo+IE9uIFRodSwg TWFyIDI0LCAyMDE2IGF0IDA3OjU3OjMwUE0gLTA0MDAsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToK Pj4gT24gMDMvMjQvMjAxNiAwNjo0OSBQTSwgQW5kcmV3IENvb3BlciB3cm90ZToKPj4+IE9uIDI0 LzAzLzIwMTYgMjI6MjIsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToKPj4+PiBPbiAwMy8xNy8yMDE2 IDAxOjUxIFBNLCBKb25hdGhhbiBEYXZpZXMgd3JvdGU6Cj4+Pj4+IEVuY2Fwc3VsYXRlIHRoZSBy ZXF1ZXN0IGluIGEgcmVjb3JkIHRoYXQgaXMgcGFzc2VkIGZyb20gZG9faW5wdXQgdG8KPj4+Pj4g cHJvY2Vzc19wYWNrZXQgYW5kIGlucHV0X2hhbmRsZV9lcnJvci4KPj4+Pj4KPj4+Pj4gVGhpcyB3 aWxsIGJlIGhlbHBmdWwgd2hlbiBrZWVwaW5nIHRyYWNrIG9mIHRoZSByZXF1ZXN0cyBtYWRlIGFz IHBhcnQKPj4+Pj4gb2YgYQo+Pj4+PiB0cmFuc2FjdGlvbi4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9m Zi1ieTogSm9uYXRoYW4gRGF2aWVzIDxqb25hdGhhbi5kYXZpZXNAY2l0cml4LmNvbT4KPj4+Pj4g UmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4+ Pj4+IFJldmlld2VkLWJ5OiBKb24gTHVkbGFtIDxqb25hdGhhbi5sdWRsYW1AY2l0cml4LmNvbT4K Pj4+Pj4gUmV2aWV3ZWQtYnk6IEV1YW4gSGFycmlzIDxldWFuLmhhcnJpc0BjaXRyaXguY29tPgo+ Pj4+PiAtLS0KPj4+Pj4gICAgdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgfCAgIDE1 ICsrKysrKysrKystLS0tLQo+Pj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9wcm9jZXNzLm1sCj4+Pj4+IGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3Mu bWwKPj4+Pj4gaW5kZXggN2E3MzY2OS4uYzkyYmVjNyAxMDA2NDQKPj4+Pj4gLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwKPj4+Pj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwKPj4+Pj4gQEAgLTM0NCwxMSArMzQ0LDExIEBAIGxldCBmdW5jdGlvbl9v Zl90eXBlIHR5ID0KPj4+Pj4gICAgICAgIHwgWGVuYnVzLlhiLk9wLkludmFsaWQgICAgICAgICAg IC0+IHJlcGx5X2FjayBkb19lcnJvcgo+Pj4+PiAgICAgICAgfCBfICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLT4gcmVwbHlfYWNrIGRvX2Vycm9yCj4+Pj4+ICAgIC1sZXQgaW5wdXRfaGFu ZGxlX2Vycm9yIH5jb25zIH5kb21zIH5mY3QgfnR5IH5jb24gfnQgfnJpZCB+ZGF0YSA9Cj4+Pj4+ ICtsZXQgaW5wdXRfaGFuZGxlX2Vycm9yIH5jb25zIH5kb21zIH5mY3QgfmNvbiB+dCB+cmVxID0K Pj4+Pj4gICAgICAgIGxldCByZXBseV9lcnJvciBlID0KPj4+Pj4gICAgICAgICAgICBQYWNrZXQu RXJyb3IgZSBpbgo+Pj4+PiAgICAgICAgdHJ5Cj4+Pj4+IC0gICAgICAgIGZjdCBjb24gdCBkb21z IGNvbnMgZGF0YQo+Pj4+PiArICAgICAgICBmY3QgY29uIHQgZG9tcyBjb25zIHJlcS5QYWNrZXQu ZGF0YQo+Pj4+PiAgICAgICAgd2l0aAo+Pj4+PiAgICAgICAgfCBEZWZpbmUuSW52YWxpZF9wYXRo ICAgICAgICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCj4+Pj4+ICAgICAgICB8IERlZmluZS5B bHJlYWR5X2V4aXN0ICAgICAgICAgLT4gcmVwbHlfZXJyb3IgIkVFWElTVCIKPj4+Pj4gQEAgLTM3 MCw3ICszNzAsMTAgQEAgbGV0IGlucHV0X2hhbmRsZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH50 eSB+Y29uCj4+Pj4+IH50IH5yaWQgfmRhdGEgPQo+Pj4+PiAgICAoKioKPj4+Pj4gICAgICogTm90 aHJvdyBndWFyYW50ZWUuCj4+Pj4+ICAgICAqKQo+Pj4+PiAtbGV0IHByb2Nlc3NfcGFja2V0IH5z dG9yZSB+Y29ucyB+ZG9tcyB+Y29uIH50aWQgfnJpZCB+dHkgfmRhdGEgPQo+Pj4+PiArbGV0IHBy b2Nlc3NfcGFja2V0IH5zdG9yZSB+Y29ucyB+ZG9tcyB+Y29uIH5yZXEgPQo+Pj4+PiArICAgIGxl dCB0eSA9IHJlcS5QYWNrZXQudHkgaW4KPj4+Pj4gKyAgICBsZXQgdGlkID0gcmVxLlBhY2tldC50 aWQgaW4KPj4+Pj4gKyAgICBsZXQgcmlkID0gcmVxLlBhY2tldC5yaWQgaW4KPj4+Pj4gICAgICAg IHRyeQo+Pj4+PiAgICAgICAgICAgIGxldCBmY3QgPSBmdW5jdGlvbl9vZl90eXBlIHR5IGluCj4+ Pj4+ICAgICAgICAgICAgbGV0IHQgPQo+Pj4+PiBAQCAtMzc5LDcgKzM4Miw3IEBAIGxldCBwcm9j ZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+dGlkCj4+Pj4+IH5yaWQgfnR5IH5k YXRhID0KPj4+Pj4gICAgICAgICAgICAgICAgZWxzZQo+Pj4+PiAgICAgICAgICAgICAgICAgICAg Q29ubmVjdGlvbi5nZXRfdHJhbnNhY3Rpb24gY29uIHRpZAo+Pj4+PiAgICAgICAgICAgICAgICBp bgo+Pj4+PiAtICAgICAgICBsZXQgcmVzcG9uc2UgPSBpbnB1dF9oYW5kbGVfZXJyb3IgfmNvbnMg fmRvbXMgfmZjdCB+dHkgfmNvbgo+Pj4+PiB+dCB+cmlkIH5kYXRhIGluCj4+Pj4+ICsgICAgICAg IGxldCByZXNwb25zZSA9IGlucHV0X2hhbmRsZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH5jb24g fnQKPj4+Pj4gfnJlcSBpbgo+Pj4+PiAgICAgICAgICAgICAgKCogUHV0IHRoZSByZXNwb25zZSBv biB0aGUgd2lyZSAqKQo+Pj4+PiAgICAgICAgICAgIHNlbmRfcmVzcG9uc2UgdHkgY29uIHQgcmlk IHJlc3BvbnNlCj4+Pj4+IEBAIC00MTIsMTEgKzQxNSwxMyBAQCBsZXQgZG9faW5wdXQgc3RvcmUg Y29ucyBkb21zIGNvbiA9Cj4+Pj4+ICAgICAgICBpZiBuZXdwYWNrZXQgdGhlbiAoCj4+Pj4+ICAg ICAgICAgICAgbGV0IHBhY2tldCA9IENvbm5lY3Rpb24ucG9wX2luIGNvbiBpbgo+Pj4+PiAgICAg ICAgICAgIGxldCB0aWQsIHJpZCwgdHksIGRhdGEgPSBYZW5idXMuWGIuUGFja2V0LnVucGFjayBw YWNrZXQgaW4KPj4+Pj4gKyAgICAgICAgbGV0IHJlcSA9IHtQYWNrZXQudGlkOyBQYWNrZXQucmlk OyBQYWNrZXQudHk7IFBhY2tldC5kYXRhfSBpbgo+Pj4+PiArCj4+Pj4gSSB0aGluayB0aGlzIGNo YW5nZSBicmVha3MgdGhlIGJ1aWxkIHdpdGggb2xkZXIgb2NhbWwgdmVyc2lvbnM6Cj4+Pj4KPj4+ PiByb290QGhhc3dlbGw+IG9jYW1sb3B0IC12Cj4+Pj4gVGhlIE9DYW1sIG5hdGl2ZS1jb2RlIGNv bXBpbGVyLCB2ZXJzaW9uIDQuMDAuMQo+Pj4+IFN0YW5kYXJkIGxpYnJhcnkgZGlyZWN0b3J5OiAv dXNyL2xpYjY0L29jYW1sCj4+Pj4gcm9vdEBoYXN3ZWxsPiBvY2FtbG9wdCAtZyAtY2NvcHQgIiAg ICAiIC1kdHlwZXMgLUkKPj4+PiAvcm9vdC90bXAveGVuL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC8u Li9saWJzL3hiIC1JCj4+Pj4gL3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4v bGlicy9tbWFwIC1JCj4+Pj4gL3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4v bGlicy94YyAtSQo+Pj4+IC9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xp YnMvZXZlbnRjaG4gLWNjIGdjYyAtdyBGCj4+Pj4gLXdhcm4tZXJyb3IgRiAtYyAtbyBwcm9jZXNz LmNteCBwcm9jZXNzLm1sCj4+Pj4gcm9vdEBoYXN3ZWxsPgo+Pj4+Cj4+Pj4KPj4+PiByb290QG92 czEwND4gb2NhbWxvcHQgLXYKPj4+PiBUaGUgT2JqZWN0aXZlIENhbWwgbmF0aXZlLWNvZGUgY29t cGlsZXIsIHZlcnNpb24gMy4xMS4yCj4+Pj4gU3RhbmRhcmQgbGlicmFyeSBkaXJlY3Rvcnk6IC91 c3IvbGliNjQvb2NhbWwKPj4+PiByb290QG92czEwND4gb2NhbWxvcHQgLWcgLWNjb3B0ICIgICAg IiAtZHR5cGVzIC1JCj4+Pj4gL3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4v bGlicy94YiAtSQo+Pj4+IC9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xp YnMvbW1hcCAtSQo+Pj4+IC9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xp YnMveGMgLUkKPj4+PiAvcm9vdC90bXAveGVuL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC8uLi9saWJz L2V2ZW50Y2huIC1jYyBnY2MgLXcgRgo+Pj4+IC13YXJuLWVycm9yIEYgLWMgLW8gcHJvY2Vzcy5j bXggcHJvY2Vzcy5tbAo+Pj4+IEZpbGUgInByb2Nlc3MubWwiLCBsaW5lIDQ4NywgY2hhcmFjdGVy cyAyMy0yNDoKPj4+PiBFcnJvcjogU3ludGF4IGVycm9yCj4+Pj4gcm9vdEBvdnMxMDQ+Cj4+Pj4K Pj4+PiBJIGRvbid0IGtub3cgbXVjaCBhYm91dCBvY2FtbCAoT0ssIEkga25vdyAqbm90aGluZyog YWJvdXQgb2NhbWwpIHNvIEkKPj4+PiBjYW4ndCBzYXkgd2hhdCBleGFjdGx5IG1pZ2h0IGJlIHdy b25nLgo+Pj4gQ291bGQgeW91IHBlcmhhcHMgdHJ5IHRoaXMgaW5zdGVhZD8KPj4+Cj4+PiBsZXQg cmVxID0ge3RpZCA9IFBhY2tldC50aWQ7IHJpZCA9IFBhY2tldC5yaWQ7IHR5ID0gUGFja2V0LnR5 OyBkYXRhID0KPj4+IFBhY2tldC5kYXRhfSBpbgo+Pj4KPj4+IEl0IGlzIG1vc3QgbGlrZWx5IHRo YXQgdGhlIG9sZGVyIHZlcnNpb24gb2YgT2NhbWwgY2FuJ3QgaW5mZXIgdGhlIG9yZGVyCj4+PiBv ZiBmaWVsZHMuCj4+Pgo+Pj4gfkFuZHJldwo+Pgo+PiBObywgaXQgbm93IGdpdmVzIG1lICJFcnJv cjogVW5ib3VuZCByZWNvcmQgZmllbGQgbGFiZWwgdGlkIgo+Pgo+PiAtYm9yaXMKPiBBbmRyZXcn cyBndWVzcyB3YXMgY2xvc2UsIGJ1dCB0aGUgd3Jvbmcgd2F5IGFyb3VuZCAtLSBwbGVhc2UgY291 bGQgeW91IHRyeSB0aGUKPiBmb2xsb3dpbmcgd2l0aCB0aGUgb2xkZXIgY29tcGlsZXI/Cj4KPiBs ZXQgcmVxID0ge1BhY2tldC50aWQ9dGlkOyBQYWNrZXQucmlkPXJpZDsgUGFja2V0LnR5PXR5OyBQ YWNrZXQuZGF0YT1kYXRhfSBpbgo+Cj4gSSB3YXMgdXNpbmcgYSBzeW50YWN0aWMgZmVhdHVyZSBv ZiBPQ2FtbCBjYWxsZWQgJ2ZpZWxkIHB1bm5pbmcnIHdoaWNoIGlzCj4gZ2VuZXJhbGx5IGNvbnNp ZGVyZWQgZ29vZCBwcmFjdGljZSBhbmQgbWFrZXMgZm9yIG1vcmUgcmVhZGFibGUgY29kZS4gSXQg bG9va3MKPiBsaWtlIHRoaXMgZmVhdHVyZSB3YXMgaW50cm9kdWNlZCBpbiBPQ2FtbCAzLjEyLjAg KGRhdGluZyBmcm9tIDIwMTApLCB3aGljaCBpcwo+IGNvbnNpc3RlbnQgd2l0aCBCb3JpcycgZmlu ZGluZ3MuCgpZZXMsIHRoaXMgZml4ZXMgaXQsIHRoYW5rcy4KCj4gV2hhdCdzIHRoZSBwb2xpY3kg aGVyZSAtLSBpcyB0aGVyZSBhIGRlZmluZWQgdmVyc2lvbiBvZiB0aGUgT0NhbWwgY29tcGlsZXIg d2hpY2gKPiB0b29scy9vY2FtbCBuZWVkcyB0byBiZSBhYmxlIHRvIGNvbXBpbGUgd2l0aD8KCk5v dCB0byBhbnN3ZXIgdGhpcyBxdWVzdGlvbiBkaXJlY3RseSBidXQgbW9yZSBhcyBhbiBGWUkgLS0t IHRoaXMgdmVyc2lvbiAKb2Ygb2NhbWwgaXMgZm91bmQgb24gT3JhY2xlIExpbnV4IDYuMiwgd2hp Y2ggQUZBSUsgaXMgYWN0aXZlbHkgc3VwcG9ydGVkLgoKLWJvcmlzCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK