From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] build: avoid putting local absolute symbols in symbol tables
Date: Wed, 30 Mar 2016 01:51:29 -0600 [thread overview]
Message-ID: <56FBA1A102000078000E1270@prv-mh.provo.novell.com> (raw)
In-Reply-To: <56FAE091.4070302@cardoe.com>
>>> On 29.03.16 at 22:07, <cardoe@cardoe.com> wrote:
> On 3/24/16 9:31 AM, Jan Beulich wrote:
>> They're not really useful past the building stage and only needlessly
>> increase binary file sizes.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -50,6 +50,7 @@ ALL_OBJS-$(CONFIG_X86) += $(BASEDIR)/c
>> CFLAGS += -nostdinc -fno-builtin -fno-common
>> CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
>> CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
>> +CFLAGS += -Wa,--strip-local-absolute
>> CFLAGS += '-D__OBJECT_FILE__="$@"'
>>
>> CFLAGS-$(verbose) += -DVERBOSE
>>
>
> This was committed as 607044bf9a8c8a8b37666a3a64c0d9b005875b13 and
> breaks the build on clang.
>
> https://travis-ci.org/xen-project/xen/jobs/119333381#L1004
> https://travis-ci.org/xen-project/xen/jobs/119333382#L1002
Yet I do not know clang, and hence don't know what to do about it.
Care to suggest a fix (or rather workaround, considering that I'd
expect them to be reasonably command line compatible with gcc)?
Simply omitting the new command line option for clang is clearly
not what we want.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-30 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 14:31 [PATCH] build: avoid putting local absolute symbols in symbol tables Jan Beulich
2016-03-24 14:36 ` Andrew Cooper
2016-03-29 20:07 ` Doug Goldstein
2016-03-30 7:51 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBA1A102000078000E1270@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).