From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block Date: Wed, 30 Mar 2016 10:47:07 -0400 Message-ID: <56FBE6EB.1090708@gmail.com> References: <56EB2B73.3060905@gmail.com> <20160325161106.GB21910@citrix.com> <56F56895.6040006@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Wei Liu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gMDMvMjkvMjAxNiAwNzoyNiBBTSwgR2VvcmdlIER1bmxhcCB3cm90ZToKPiBPbiBGcmksIE1h ciAyNSwgMjAxNiBhdCA0OjM0IFBNLCBSb3NzIFBoaWxpcHNvbgo+IDxyb3NzLnBoaWxpcHNvbkBn bWFpbC5jb20+IHdyb3RlOgo+PiBPbiAwMy8yNS8yMDE2IDEyOjExIFBNLCBXZWkgTGl1IHdyb3Rl Ogo+Pj4gT24gVGh1LCBNYXIgMTcsIDIwMTYgYXQgMDY6MTA6NTlQTSAtMDQwMCwgUm9zcyBQaGls aXBzb24gd3JvdGU6Cj4+Pj4gSXQgc2VlbXMgdGhlIGxvZ2ljIGlzIG1lYW50IHRvIGRldGVjdCBz ZWN0b3IgdW5hbGlnbmVkIGJ1ZmZlcnMgZm9yIGJsb2NrCj4+Pj4gd3JpdGVzLiBUaGUgTk9UaW5n IG9mIHRoZSBsb2dpYyBpbnN0ZWFkIG1hc2tzIG9mZiBhbnkgdW5hbGlnbmVkIGJpdHMgYW5kCj4+ Pj4gYWxzbyB3b3VsZCBjYXVzZSB0aGUgZnVuY3Rpb24gdG8gYWx3YXlzIGZhaWwuIEl0IHNlZW1z IHRoZSBmdW5jdGlvbiBpcyBub3QKPj4+PiB1c2VkIGluIGFueSBvZiB0aGUgdG9vbHMgc28gdGhh dCBpcyBwcm9iYWJseSB3aHkgdGhlIHByb2JsZW0gaXMgbm90IHNlZW4uCj4+Pj4gSW4gdGhlIHZo ZF9yZWFkX2Jsb2NrIGZ1bmN0aW9uIGl0IGlzIGNvcnJlY3QuCj4+Pj4KPj4+PiBTaWduZWQtb2Zm LWJ5OiBSb3NzIFBoaWxpcHNvbiA8cm9zcy5waGlsaXBzb25AYWluZm9zZWMuY29tPgo+Pj4KPj4+ IFRoaXMgc2VlbXMgdG8gZmFsbCB1bmRlciB0b29scyB1bWJyZWxsYS4gSSd2ZSBsb29rIGF0IGJs a3RhcDIgY29kZSwKPj4+IHRoZSByZWFzb25pbmcgaXMgY29udmluY2luZyB0byBtZSBzbzoKPj4+ Cj4+PiAgIEFja2VkLWJ5OiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+Pj4KPj4+IEJ1 dCBJJ3ZlIG5ldmVyIHVzZWQgYmxrdGFwMiBhbmQgd2UgZG9uJ3Qgbm9ybWFsbHkgdGVzdCBpdCBz byBJIHdvdWxkCj4+PiBhbHNvIHdhaXQgYSBiaXQgbG9uZ2VyIHRvIHNlZSBpZiBhbnlib2R5IG9i amVjdHMgdG8gdGhpcyBjaGFuZ2UuCj4+Pgo+Pj4gT09JIGlmIG5vIGNvZGUgd2FzIHVzaW5nIHRo aXMsIGhvdyBkaWQgeW91IGRpc2NvdmVyIHRoaXMgcHJvYmxlbT8KPj4KPj4gV2UgaGF2ZSBhbiBv bGQgZm9yayBvZiBibGt0YXAyIGZyb20gd2F5IGJhY2sgd2hlbi4gSSB3YXMgd29ya2luZyB0byBl eHRyYWN0IG91cgo+PiBjaGFuZ2VzIGFuZCB0dXJuIHRoZW0gaW50byBwYXRjaGVzIHNvIHdlIGNv dWxkIHJlYmFzZSBvbiB1cHN0cmVhbSBibGt0YXAyLgo+PiBTb21lb25lIGxvbmcgYWdvIGZvdW5k IHRoYXQgLSBJIGhhdmUgbm8gaWRlYSBob3cgYnV0IGl0IHdhcyBhIHZhbGlkIGZpeCBzbyBJCj4+ IHVwc3RyZWFtZWQgaXQuCj4+Cj4+IFRoZXJlIGFyZSBhIG51bWJlciBvZiBvdGhlciBvbmVzIHRo YXQgd2VyZSBmb3VuZCB0aGF0IGFyZSBzdGlsbCBpbiB1cHN0cmVhbQo+PiBibGt0YXAyIC0gSSBw bGFuIHRvIHNlbmQgdGhlbSB0b28uCj4gCj4gUm9zcywKPiAKPiBJbnN0ZWFkIG9mIGNyb3NzLXBv cnRpbmcgZml4ZXMgZnJvbSBYZW5TZXJ2ZXIncyBibGt0YXAzIHRvIHRoZQo+IGJpdHJvdHRpbmcg YmxrdGFwMiwgd291bGQgeW91IGNvbnNpZGVyIHRha2luZyB1cCBteSB3b3JrIG9uIHJlcGxhY2lu Zwo+IGJsa3RhcDIgd2l0aCBidWlsZGluZyBibGt0YXAzIGFzIGFuIGV4dGVybmFsIHByb2plY3Q/ CgpHZW9yZ2UsIHNvcnJ5IEkgaGFkIHRvIHNvcnQgb3V0IHNvbWUgcmVkIHRhcGUgYmVmb3JlIEkg Y291bGQgcmVwbHkuIEZvciB0aGUKcmVjb3JkIEkgYW0gbm90IGNyb3NzIHBvcnRpbmcgZnJvbSBi bGt0YXAzIGJ1dCB1cHN0cmVhbWluZyBmcm9tIGEgdmVyeSBvbGQgZm9yawpvZiBibGt0YXAyIHRo YXQgY2FtZSBmcm9tIFhlblNlcnZlci4KCkJ1dCByZWFsbHkgdGhhdCBpcyBvZiBsaXR0bGUgY29u Y2VybiBiZWNhdXNlIEkgdGhpbmsgeW91ciBpZGVhIGlzIGEgcmVhbGx5IGdvb2QKb25lLiBZZXMg SSB3b3VsZCBiZSB1cCBmb3IgdGFraW5nIG9uIHRoYXQgd29yayBhbmQgd2Ugd291bGQgdmVyeSBt dWNoIGxpa2UgdG8KcmUtYmFzZSBvdXIgcHJvamVjdCBvbiBibGt0YXAzIHRvby4gSSBjYW5ub3Qg Z2l2ZSB5b3UgYW4gZXhhY3QgZGF0ZSB3aGVuIEkgd291bGQKc3RhcnQgb24gaXQgYnV0IHByb2Jh Ymx5IEkgY291bGQgc3RhcnQgYXQgdGhlIGJlZ2lubmluZyBvZiBNYXkuIEluIHRoZSBtZWFuIHRp bWUKSSB3aWxsIHNwZW5kIHRpbWUgZmFtaWxpYXJpemluZyBteXNlbGYgd2l0aCBibGt0YXAzIGFu ZCBJIHdpbGwgcHJvYmFibHkgaGF2ZQpzb21lIHF1ZXN0aW9uIGZvciB5b3UgdG9vLi4uCgpUaGFu a3MKCj4gCj4gVGhlIGJhc2ljIHNoYXBlIG9mIHRoaW5ncyB0aGF0IG5lZWQgdG8gaGFwcGVuIGZv ciB0aGF0IGFyZToKPiAKPiAxLiBBbGxvdyBxZW11IHRvIHByb3ZpZGUgZW11bGF0ZWQgZGV2aWNl cyBmb3IgZGlza3Mgd2hpY2ggdXNlIGhvdHBsdWcKPiBzY3JpcHRzIChqdXN0IGNoZWNrZWQgaW4g bGFzdCB3ZWVrKQo+IAo+IDIuIERvIHRoZSB0d2Vha3MgbmVjZXNzYXJ5IHRvIGFsbG93IGJsa3Rh cDMgdG8gYmUgYnVpbHQgYXMgYW4KPiBpbmRlcGVuZGVudCBwcm9qZWN0IChvdXRzaWRlIHRoZSBY ZW5TZXJ2ZXIgYnVpbGQgc3lzdGVtKQo+IAo+IDMuIFN3aXRjaCBsaWJ4bCB0byB1c2UgdGhlIGFs cmVhZHktaW4tdHJlZSBibG9jay10YXAgc2NyaXB0ICh3aGljaAo+IGNhbGxzIHRhcGN0bCkgcmF0 aGVyIHRoYW4gbGlua2luZyBhZ2FpbnN0IHRoZSBibGt0YXAgbGlicmFyeS4KPiAKPiA0LiBBZGQg YSBibGt0YXAgdGFyZ2V0IHRvIHJhaXNpbi4KPiAKPiAjMSBpcyBkb25lIGFuZCB3YXMganVzdCBj aGVja2VkIGluIGxhc3Qgd2Vlay4gICMyIHNob3VsZG4ndCBiZSBhCj4gdGVycmlibHkgbGFyZ2Ug YW1vdW50IG9mIHdvcmsuICBGb3IgIzMsIEkndmUgcG9zdGVkIHBhdGNoZXMgYWxyZWFkeSwKPiBh bmQgSSBjYW4gcHJvYmFibHkgZG8gYSBxdWljayByZWJhc2UgZm9yIHlvdSB0byBwaWNrIHVwIGlm IHlvdSB3YW50ZWQuCj4gIzQgc2hvdWxkbid0IGJlIHRvbyBoYXJkIG9uY2UgeW91IGhhdmUgYW4g b3V0LW9mLXRyZWUgYnVpbGQgd29ya2luZzsgSQo+IGNhbiBoZWxwIHdpdGggdGhhdCBhcyB3ZWxs Lgo+IAo+IElmIHdlIHRoZW4gYWRkIHRlc3RzIGZvciB1cHN0cmVhbSBibGt0YXAgdG8gb3NzdGVz dCwgdGhlbiB3ZSdsbCBjYXRjaAo+IGFueSBicmVha2FnZXMsIGFuZCBhdXRvbWF0aWNhbGx5IGdl dCB1cGRhdGVzOyBhbmQgd2UgY2FuIGRlbGV0ZSB0aGUKPiBiaXRyb3R0aW5nIGJsa3RhcDIgb3V0 IG9mIHRoZSB0cmVlLgo+IAo+IFdoYXQgZG8geW91IHRoaW5rPwo+IAo+ICAtR2VvcmdlCj4gCgoK LS0gClJvc3MgUGhpbGlwc29uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3Jn Cmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=