On 3/29/16 3:50 AM, Jan Beulich wrote: >>>> On 25.03.16 at 22:02, wrote: >> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: >>>> --- a/xen/Kconfig.debug >>>> +++ b/xen/Kconfig.debug >>>> @@ -4,3 +4,14 @@ menuconfig DEBUG >>>> ---help--- >>>> If you want to debug Xen say Y and select any additional debugging >>>> support options. >>>> + >>>> +if DEBUG >>> >>> Perhaps if !defined then atuomatically enable it? Looking at Config.mk >>> it seems you could do crash_debug without debug=y? >> >> debug=y unfortunately is more than just a "meta" option that selects >> verbose=y and frame_pointer=y. It also turns off NDEBUG so that debug >> messages appear. I'm not sure how that should be mapped in the context >> of this patch. Should the messages be enabled when DEBUG is enabled or >> should there be another option? > > Let's not make this too fine grained, at least for now. I.e. enabling > DEBUG should mean exactly what "debug=y" so far meant. > > Jan > That's what I was stating this patch does. The question revolved around the fact that you can do crash_debug=y debug=n right now and if that made sense. Should crash_debug=y imply debug=y as well. So things are more fine grained and I was proposing we make it less so if the fine grained choices didn't make sense. -- Doug Goldstein