From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [RFC PATCH 2/2] build: convert crash_debug to Kconfig Date: Wed, 30 Mar 2016 10:38:28 -0500 Message-ID: <56FBF2F4.6070809@cardoe.com> References: <1458838099-12053-1-git-send-email-cardoe@cardoe.com> <1458838099-12053-2-git-send-email-cardoe@cardoe.com> <20160325194927.GD14689@char.us.oracle.com> <56F5A780.9080502@cardoe.com> <56FA5DDA02000078000E0BDB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1800860616201592107==" Return-path: In-Reply-To: <56FA5DDA02000078000E0BDB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Konrad Rzeszutek Wilk Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1800860616201592107== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1WC9cmVDmgX0jG5gRgWE5uXWIBVPgwF5n" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1WC9cmVDmgX0jG5gRgWE5uXWIBVPgwF5n Content-Type: multipart/mixed; boundary="TV1xbwglvItFlOPI6uIakO4V3jQckrPin" From: Doug Goldstein To: Jan Beulich , Konrad Rzeszutek Wilk Cc: Andrew Cooper , xen-devel@lists.xen.org, Keir Fraser Message-ID: <56FBF2F4.6070809@cardoe.com> Subject: Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig References: <1458838099-12053-1-git-send-email-cardoe@cardoe.com> <1458838099-12053-2-git-send-email-cardoe@cardoe.com> <20160325194927.GD14689@char.us.oracle.com> <56F5A780.9080502@cardoe.com> <56FA5DDA02000078000E0BDB@prv-mh.provo.novell.com> In-Reply-To: <56FA5DDA02000078000E0BDB@prv-mh.provo.novell.com> --TV1xbwglvItFlOPI6uIakO4V3jQckrPin Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/29/16 3:50 AM, Jan Beulich wrote: >>>> On 25.03.16 at 22:02, wrote: >> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: >>>> --- a/xen/Kconfig.debug >>>> +++ b/xen/Kconfig.debug >>>> @@ -4,3 +4,14 @@ menuconfig DEBUG >>>> ---help--- >>>> If you want to debug Xen say Y and select any additional debuggi= ng >>>> support options. >>>> + >>>> +if DEBUG >>> >>> Perhaps if !defined then atuomatically enable it? Looking at Config.m= k >>> it seems you could do crash_debug without debug=3Dy? >> >> debug=3Dy unfortunately is more than just a "meta" option that selects= >> verbose=3Dy and frame_pointer=3Dy. It also turns off NDEBUG so that de= bug >> messages appear. I'm not sure how that should be mapped in the context= >> of this patch. Should the messages be enabled when DEBUG is enabled or= >> should there be another option? >=20 > Let's not make this too fine grained, at least for now. I.e. enabling > DEBUG should mean exactly what "debug=3Dy" so far meant. >=20 > Jan >=20 That's what I was stating this patch does. The question revolved around the fact that you can do crash_debug=3Dy debug=3Dn right now and if that made sense. Should crash_debug=3Dy imply debug=3Dy as well. So things are more fine grained and I was proposing we make it less so if the fine grained choices didn't make sense. --=20 Doug Goldstein --TV1xbwglvItFlOPI6uIakO4V3jQckrPin-- --1WC9cmVDmgX0jG5gRgWE5uXWIBVPgwF5n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW+/L3XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU044QAJfcTKaKe1w4kd1ZRNGi+8aK 90RR/FEO9aKCPTfcPWooq8mY+S8F2mVQwAwLwHu8XfBI0Z+uUDxaRV4cK5bnv9iO h/iu3gkKJxbz5MyYsdVRzcYc65rymVW2cp5vTz+n+/p0ZQ2JDp5UC3M8XJrupRaV T+CEomArOjc+leXqcmptoNX1YXJXc3JK7bho+YdlxGJGesx/FkhhUMBzAdo7QNwN yfbV/31smFMGzTq+l8IqkOluVaOZpz71kcdx16CIP25JDlk2Qr9f8sms3z1CPrUl Svrun7miIJuTGyGHXWHeowvNyObv1QZq7G8F76cEzxBbyGDNvIqglPNGuxgWbuqF x4VIfFUDvdT/RdW27chbmcr24bTWR6lgCGRkejpwyRZX7X6gQACz8QzfLxXlYfSP tT+gNwlC6pATpVuhUKZwlJQt86FrBGG02Uvq5xlxrcgeXNfs90rbthh1v/prkMcH 4oEMTJvviJ94EkGYlE6ImGVemSyPlYl6MZwud9m2jHRQXCrWSUI56jOCYbCMRs/4 LCC/b0jmU+dF3oaTKKkagA67b4RGPNK68Dn/661xxVUZqfw89h5M9B+cZPadbNHh xDim6Cj5Cc/l3JC7B1HyWyLwOB1A4+kGqMh/dSXVO6T1RWzI7v5X0PGryC1N1mi9 +akTv3tLlM8JdhWVJGsm =GVNI -----END PGP SIGNATURE----- --1WC9cmVDmgX0jG5gRgWE5uXWIBVPgwF5n-- --===============1800860616201592107== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============1800860616201592107==--