From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCH v2] xenbus: Avoid deadlock during suspend due to open transactions Date: Wed, 22 May 2019 16:25:52 +0100 Message-ID: <56ce57f7-8c99-7c16-c997-97bf1e7773bf@citrix.com> References: <20190513135635.22406-1-ross.lagerwall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hTT7u-00014z-GG for xen-devel@lists.xenproject.org; Wed, 22 May 2019 15:25:58 +0000 In-Reply-To: <20190513135635.22406-1-ross.lagerwall@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Boris Ostrovsky , Juergen Gross Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org UGluZz8KCk9uIDUvMTMvMTkgMjo1NiBQTSwgUm9zcyBMYWdlcndhbGwgd3JvdGU6Cj4gRHVyaW5n IGEgc3VzcGVuZC9yZXN1bWUsIHRoZSB4ZW53YXRjaCB0aHJlYWQgd2FpdHMgZm9yIGFsbCBvdXRz dGFuZGluZwo+IHhlbnN0b3JlIHJlcXVlc3RzIGFuZCB0cmFuc2FjdGlvbnMgdG8gY29tcGxldGUu IFRoaXMgZG9lcyBub3Qgd29yawo+IGNvcnJlY3RseSBmb3IgdHJhbnNhY3Rpb25zIHN0YXJ0ZWQg YnkgdXNlcnNwYWNlIGJlY2F1c2UgaXQgd2FpdHMgZm9yCj4gdGhlbSB0byBjb21wbGV0ZSBhZnRl ciBmcmVlemluZyB1c2Vyc3BhY2UgdGhyZWFkcyB3aGljaCBtZWFucyB0aGUKPiB0cmFuc2FjdGlv bnMgaGF2ZSBubyB3YXkgb2YgY29tcGxldGluZywgcmVzdWx0aW5nIGluIGEgZGVhZGxvY2suIFRo aXMgaXMKPiB0cml2aWFsIHRvIHJlcHJvZHVjZSBieSBydW5uaW5nIHRoaXMgc2NyaXB0IGFuZCB0 aGVuIHN1c3BlbmRpbmcgdGhlIFZNOgo+IAo+ICAgICAgaW1wb3J0IHB5eHMsIHRpbWUKPiAgICAg IGMgPSBweXhzLmNsaWVudC5DbGllbnQoeGVuX2J1c19wYXRoPSIvZGV2L3hlbi94ZW5idXMiKQo+ ICAgICAgYy5jb25uZWN0KCkKPiAgICAgIGMudHJhbnNhY3Rpb24oKQo+ICAgICAgdGltZS5zbGVl cCgzNjAwKQo+IAo+IEV2ZW4gaWYgdGhpcyBkZWFkbG9jayB3ZXJlIHJlc29sdmVkLCBtaXNiZWhh dmluZyB1c2Vyc3BhY2Ugc2hvdWxkIG5vdAo+IHByZXZlbnQgYSBWTSBmcm9tIGJlaW5nIG1pZ3Jh dGVkLiBTbywgaW5zdGVhZCBvZiB3YWl0aW5nIGZvciB0aGVzZQo+IHRyYW5zYWN0aW9ucyB0byBj b21wbGV0ZSBiZWZvcmUgc3VzcGVuZGluZywgc3RvcmUgdGhlIGN1cnJlbnQgZ2VuZXJhdGlvbgo+ IGlkIGZvciBlYWNoIHRyYW5zYWN0aW9uIHdoZW4gaXQgaXMgc3RhcnRlZC4gVGhlIGdsb2JhbCBn ZW5lcmF0aW9uIGlkIGlzCj4gaW5jcmVtZW50ZWQgZHVyaW5nIHJlc3VtZS4gSWYgdGhlIGNhbGxl ciBjb21taXRzIHRoZSB0cmFuc2FjdGlvbiBhbmQgdGhlCj4gZ2VuZXJhdGlvbiBpZCBkb2VzIG5v dCBtYXRjaCB0aGUgY3VycmVudCBnZW5lcmF0aW9uIGlkLCByZXR1cm4gRUFHQUlOIHNvCj4gdGhh dCB0aGV5IHRyeSBhZ2Fpbi4gSWYgdGhlIHRyYW5zYWN0aW9uIHdhcyBpbnN0ZWFkIGRpc2NhcmRl ZCwgcmV0dXJuIE9LCj4gc2luY2Ugbm8gY2hhbmdlcyB3ZXJlIG1hZGUgYW55d2F5Lgo+IAo+IFRo aXMgb25seSBhZmZlY3RzIHVzZXJzIG9mIHRoZSB4ZW5idXMgZmlsZSBpbnRlcmZhY2UuIEluLWtl cm5lbCB1c2VycyBvZgo+IHhlbmJ1cyBhcmUgYXNzdW1lZCB0byBiZSB3ZWxsLWJlaGF2ZWQgYW5k IGNvbXBsZXRlIGFsbCB0cmFuc2FjdGlvbnMKPiBiZWZvcmUgZnJlZXppbmcuCj4gCj4gU2lnbmVk LW9mZi1ieTogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+Cj4gLS0t Cj4gCj4gQ2hhbmdlZCBpbiB2MjogcmV3cm90ZSBhY2NvcmRpbmcgdG8gSnVlcmdlbidzIHN1Z2dl c3Rpb24uCj4gCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmggICAgICAgICAgICAgIHwg IDMgKysrCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2Rldl9mcm9udGVuZC5jIHwgMTgg KysrKysrKysrKysrKysrKysrCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMgICAg ICAgICAgIHwgIDcgKysrKystLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVu YnVzLmggYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgKPiBpbmRleCAwOTI5ODExNzFkZjEu LmQ3NWEyMzg1YjM3YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgK PiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgKPiBAQCAtODMsNiArODMsNyBAQCBz dHJ1Y3QgeGJfcmVxX2RhdGEgewo+ICAgCWludCBudW1fdmVjczsKPiAgIAlpbnQgZXJyOwo+ICAg CWVudW0geGJfcmVxX3N0YXRlIHN0YXRlOwo+ICsJYm9vbCB1c2VyX3JlcTsKPiAgIAl2b2lkICgq Y2IpKHN0cnVjdCB4Yl9yZXFfZGF0YSAqKTsKPiAgIAl2b2lkICpwYXI7Cj4gICB9Owo+IEBAIC0x MzMsNCArMTM0LDYgQEAgdm9pZCB4ZW5idXNfcmluZ19vcHNfaW5pdCh2b2lkKTsKPiAgIGludCB4 ZW5idXNfZGV2X3JlcXVlc3RfYW5kX3JlcGx5KHN0cnVjdCB4c2Rfc29ja21zZyAqbXNnLCB2b2lk ICpwYXIpOwo+ICAgdm9pZCB4ZW5idXNfZGV2X3F1ZXVlX3JlcGx5KHN0cnVjdCB4Yl9yZXFfZGF0 YSAqcmVxKTsKPiAgIAo+ICtleHRlcm4gdW5zaWduZWQgaW50IHhiX2Rldl9nZW5lcmF0aW9uX2lk Owo+ICsKPiAgICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVz X2Rldl9mcm9udGVuZC5jIGIvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19kZXZfZnJvbnRlbmQu Ywo+IGluZGV4IDA3ODJmZjNjMjI3My4uMzljNjMxNTJhMzU4IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMveGVuL3hlbmJ1cy94ZW5idXNfZGV2X2Zyb250ZW5kLmMKPiArKysgYi9kcml2ZXJzL3hlbi94 ZW5idXMveGVuYnVzX2Rldl9mcm9udGVuZC5jCj4gQEAgLTYyLDYgKzYyLDggQEAKPiAgIAo+ICAg I2luY2x1ZGUgInhlbmJ1cy5oIgo+ICAgCj4gK3Vuc2lnbmVkIGludCB4Yl9kZXZfZ2VuZXJhdGlv bl9pZDsKPiArCj4gICAvKgo+ICAgICogQW4gZWxlbWVudCBvZiBhIGxpc3Qgb2Ygb3V0c3RhbmRp bmcgdHJhbnNhY3Rpb25zLCBmb3Igd2hpY2ggd2UncmUKPiAgICAqIHN0aWxsIHdhaXRpbmcgYSBy ZXBseS4KPiBAQCAtNjksNiArNzEsNyBAQAo+ICAgc3RydWN0IHhlbmJ1c190cmFuc2FjdGlvbl9o b2xkZXIgewo+ICAgCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKPiAgIAlzdHJ1Y3QgeGVuYnVzX3Ry YW5zYWN0aW9uIGhhbmRsZTsKPiArCXVuc2lnbmVkIGludCBnZW5lcmF0aW9uX2lkOwo+ICAgfTsK PiAgIAo+ICAgLyoKPiBAQCAtNDQxLDYgKzQ0NCw3IEBAIHN0YXRpYyBpbnQgeGVuYnVzX3dyaXRl X3RyYW5zYWN0aW9uKHVuc2lnbmVkIG1zZ190eXBlLAo+ICAgCQkJcmMgPSAtRU5PTUVNOwo+ICAg CQkJZ290byBvdXQ7Cj4gICAJCX0KPiArCQl0cmFucy0+Z2VuZXJhdGlvbl9pZCA9IHhiX2Rldl9n ZW5lcmF0aW9uX2lkOwo+ICAgCQlsaXN0X2FkZCgmdHJhbnMtPmxpc3QsICZ1LT50cmFuc2FjdGlv bnMpOwo+ICAgCX0gZWxzZSBpZiAobXNnLT5oZHIudHhfaWQgIT0gMCAmJgo+ICAgCQkgICAheGVu YnVzX2dldF90cmFuc2FjdGlvbih1LCBtc2ctPmhkci50eF9pZCkpCj4gQEAgLTQ0OSw2ICs0NTMs MjAgQEAgc3RhdGljIGludCB4ZW5idXNfd3JpdGVfdHJhbnNhY3Rpb24odW5zaWduZWQgbXNnX3R5 cGUsCj4gICAJCSAhKG1zZy0+aGRyLmxlbiA9PSAyICYmCj4gICAJCSAgICghc3RyY21wKG1zZy0+ Ym9keSwgIlQiKSB8fCAhc3RyY21wKG1zZy0+Ym9keSwgIkYiKSkpKQo+ICAgCQlyZXR1cm4geGVu YnVzX2NvbW1hbmRfcmVwbHkodSwgWFNfRVJST1IsICJFSU5WQUwiKTsKPiArCWVsc2UgaWYgKG1z Z190eXBlID09IFhTX1RSQU5TQUNUSU9OX0VORCkgewo+ICsJCXRyYW5zID0geGVuYnVzX2dldF90 cmFuc2FjdGlvbih1LCBtc2ctPmhkci50eF9pZCk7Cj4gKwkJaWYgKHRyYW5zICYmIHRyYW5zLT5n ZW5lcmF0aW9uX2lkICE9IHhiX2Rldl9nZW5lcmF0aW9uX2lkKSB7Cj4gKwkJCWxpc3RfZGVsKCZ0 cmFucy0+bGlzdCk7Cj4gKwkJCWtmcmVlKHRyYW5zKTsKPiArCQkJaWYgKCFzdHJjbXAobXNnLT5i b2R5LCAiVCIpKQo+ICsJCQkJcmV0dXJuIHhlbmJ1c19jb21tYW5kX3JlcGx5KHUsIFhTX0VSUk9S LAo+ICsJCQkJCQkJICAgICJFQUdBSU4iKTsKPiArCQkJZWxzZQo+ICsJCQkJcmV0dXJuIHhlbmJ1 c19jb21tYW5kX3JlcGx5KHUsCj4gKwkJCQkJCQkgICAgWFNfVFJBTlNBQ1RJT05fRU5ELAo+ICsJ CQkJCQkJICAgICJPSyIpOwo+ICsJCX0KPiArCX0KPiAgIAo+ICAgCXJjID0geGVuYnVzX2Rldl9y ZXF1ZXN0X2FuZF9yZXBseSgmbXNnLT5oZHIsIHUpOwo+ICAgCWlmIChyYyAmJiB0cmFucykgewo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMgYi9kcml2ZXJzL3hl bi94ZW5idXMveGVuYnVzX3hzLmMKPiBpbmRleCA0OWEzODc0YWU2YmIuLmRkYzE4ZGE2MTgzNCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMKPiArKysgYi9kcml2 ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMKPiBAQCAtMTA1LDYgKzEwNSw3IEBAIHN0YXRpYyB2 b2lkIHhzX3N1c3BlbmRfZW50ZXIodm9pZCkKPiAgIAo+ICAgc3RhdGljIHZvaWQgeHNfc3VzcGVu ZF9leGl0KHZvaWQpCj4gICB7Cj4gKwl4Yl9kZXZfZ2VuZXJhdGlvbl9pZCsrOwo+ICAgCXNwaW5f bG9jaygmeHNfc3RhdGVfbG9jayk7Cj4gICAJeHNfc3VzcGVuZF9hY3RpdmUtLTsKPiAgIAlzcGlu X3VubG9jaygmeHNfc3RhdGVfbG9jayk7Cj4gQEAgLTEyNSw3ICsxMjYsNyBAQCBzdGF0aWMgdWlu dDMyX3QgeHNfcmVxdWVzdF9lbnRlcihzdHJ1Y3QgeGJfcmVxX2RhdGEgKnJlcSkKPiAgIAkJc3Bp bl9sb2NrKCZ4c19zdGF0ZV9sb2NrKTsKPiAgIAl9Cj4gICAKPiAtCWlmIChyZXEtPnR5cGUgPT0g WFNfVFJBTlNBQ1RJT05fU1RBUlQpCj4gKwlpZiAocmVxLT50eXBlID09IFhTX1RSQU5TQUNUSU9O X1NUQVJUICYmICFyZXEtPnVzZXJfcmVxKQo+ICAgCQl4c19zdGF0ZV91c2VycysrOwo+ICAgCXhz X3N0YXRlX3VzZXJzKys7Cj4gICAJcnFfaWQgPSB4c19yZXF1ZXN0X2lkKys7Cj4gQEAgLTE0MCw3 ICsxNDEsNyBAQCB2b2lkIHhzX3JlcXVlc3RfZXhpdChzdHJ1Y3QgeGJfcmVxX2RhdGEgKnJlcSkK PiAgIAlzcGluX2xvY2soJnhzX3N0YXRlX2xvY2spOwo+ICAgCXhzX3N0YXRlX3VzZXJzLS07Cj4g ICAJaWYgKChyZXEtPnR5cGUgPT0gWFNfVFJBTlNBQ1RJT05fU1RBUlQgJiYgcmVxLT5tc2cudHlw ZSA9PSBYU19FUlJPUikgfHwKPiAtCSAgICAocmVxLT50eXBlID09IFhTX1RSQU5TQUNUSU9OX0VO RCAmJgo+ICsJICAgIChyZXEtPnR5cGUgPT0gWFNfVFJBTlNBQ1RJT05fRU5EICYmICFyZXEtPnVz ZXJfcmVxICYmCj4gICAJICAgICAhV0FSTl9PTl9PTkNFKHJlcS0+bXNnLnR5cGUgPT0gWFNfRVJS T1IgJiYKPiAgIAkJCSAgICFzdHJjbXAocmVxLT5ib2R5LCAiRU5PRU5UIikpKSkKPiAgIAkJeHNf c3RhdGVfdXNlcnMtLTsKPiBAQCAtMjg2LDYgKzI4Nyw3IEBAIGludCB4ZW5idXNfZGV2X3JlcXVl c3RfYW5kX3JlcGx5KHN0cnVjdCB4c2Rfc29ja21zZyAqbXNnLCB2b2lkICpwYXIpCj4gICAJcmVx LT5udW1fdmVjcyA9IDE7Cj4gICAJcmVxLT5jYiA9IHhlbmJ1c19kZXZfcXVldWVfcmVwbHk7Cj4g ICAJcmVxLT5wYXIgPSBwYXI7Cj4gKwlyZXEtPnVzZXJfcmVxID0gdHJ1ZTsKPiAgIAo+ICAgCXhz X3NlbmQocmVxLCBtc2cpOwo+ICAgCj4gQEAgLTMxMyw2ICszMTUsNyBAQCBzdGF0aWMgdm9pZCAq eHNfdGFsa3Yoc3RydWN0IHhlbmJ1c190cmFuc2FjdGlvbiB0LAo+ICAgCXJlcS0+dmVjID0gaW92 ZWM7Cj4gICAJcmVxLT5udW1fdmVjcyA9IG51bV92ZWNzOwo+ICAgCXJlcS0+Y2IgPSB4c193YWtl X3VwOwo+ICsJcmVxLT51c2VyX3JlcSA9IGZhbHNlOwo+ICAgCj4gICAJbXNnLnJlcV9pZCA9IDA7 Cj4gICAJbXNnLnR4X2lkID0gdC5pZDsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DEEC282CE for ; Wed, 22 May 2019 15:26:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56A4220868 for ; Wed, 22 May 2019 15:26:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56A4220868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hTT7v-000154-OY; Wed, 22 May 2019 15:25:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hTT7u-00014z-GG for xen-devel@lists.xenproject.org; Wed, 22 May 2019 15:25:58 +0000 X-Inumbo-ID: e44e9af2-7ca5-11e9-b005-2347c8a701e2 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e44e9af2-7ca5-11e9-b005-2347c8a701e2; Wed, 22 May 2019 15:25:55 +0000 (UTC) Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ross.lagerwall@citrix.com; spf=Pass smtp.mailfrom=ross.lagerwall@citrix.com; spf=None smtp.helo=postmaster@MIAPEX02MSOL02.citrite.net Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of ross.lagerwall@citrix.com) identity=pra; client-ip=23.29.105.83; receiver=esa6.hc3370-68.iphmx.com; envelope-from="ross.lagerwall@citrix.com"; x-sender="ross.lagerwall@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of ross.lagerwall@citrix.com designates 23.29.105.83 as permitted sender) identity=mailfrom; client-ip=23.29.105.83; receiver=esa6.hc3370-68.iphmx.com; envelope-from="ross.lagerwall@citrix.com"; x-sender="ross.lagerwall@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:23.29.105.83 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@MIAPEX02MSOL02.citrite.net) identity=helo; client-ip=23.29.105.83; receiver=esa6.hc3370-68.iphmx.com; envelope-from="ross.lagerwall@citrix.com"; x-sender="postmaster@MIAPEX02MSOL02.citrite.net"; x-conformance=sidf_compatible IronPort-SDR: Q3TD1lHsyx3IR39FCD0531KSah3N1wJhXHR/7y4iApF8B8KpoMbzxWv1N6XwE47tBhr/u9jNb1 qGtL24F6dTzf0ayzczEJMW5Peh5bIPROrGpy9Fc0+lY+QPt5VRhhOpmERHfjMX9xYDcGxzhRAP rC5/nNrG0xH0zmosteJ/tka8CMQJTpRMsF+YRUChuNm4sApQmRuVIPBYmDrl/wEjThtPN3MhYq K1GFgJx0BoE6xA1Ss2ti7MO5wwgnsG3GdZigxRshkjviaNa5czIGqoeCADklbA9kZO1ssCIT4S ZQs= X-SBRS: 2.7 X-MesageID: 757212 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 23.29.105.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.60,499,1549947600"; d="scan'208";a="757212" To: Boris Ostrovsky , Juergen Gross References: <20190513135635.22406-1-ross.lagerwall@citrix.com> From: Ross Lagerwall Message-ID: <56ce57f7-8c99-7c16-c997-97bf1e7773bf@citrix.com> Date: Wed, 22 May 2019 16:25:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190513135635.22406-1-ross.lagerwall@citrix.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v2] xenbus: Avoid deadlock during suspend due to open transactions X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="UTF-8"; format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190522152552.LwkdqmuuDCKViQP06nC6YEN1_eTQ-RJB9yPWEkcDlec@z> UGluZz8KCk9uIDUvMTMvMTkgMjo1NiBQTSwgUm9zcyBMYWdlcndhbGwgd3JvdGU6Cj4gRHVyaW5n IGEgc3VzcGVuZC9yZXN1bWUsIHRoZSB4ZW53YXRjaCB0aHJlYWQgd2FpdHMgZm9yIGFsbCBvdXRz dGFuZGluZwo+IHhlbnN0b3JlIHJlcXVlc3RzIGFuZCB0cmFuc2FjdGlvbnMgdG8gY29tcGxldGUu IFRoaXMgZG9lcyBub3Qgd29yawo+IGNvcnJlY3RseSBmb3IgdHJhbnNhY3Rpb25zIHN0YXJ0ZWQg YnkgdXNlcnNwYWNlIGJlY2F1c2UgaXQgd2FpdHMgZm9yCj4gdGhlbSB0byBjb21wbGV0ZSBhZnRl ciBmcmVlemluZyB1c2Vyc3BhY2UgdGhyZWFkcyB3aGljaCBtZWFucyB0aGUKPiB0cmFuc2FjdGlv bnMgaGF2ZSBubyB3YXkgb2YgY29tcGxldGluZywgcmVzdWx0aW5nIGluIGEgZGVhZGxvY2suIFRo aXMgaXMKPiB0cml2aWFsIHRvIHJlcHJvZHVjZSBieSBydW5uaW5nIHRoaXMgc2NyaXB0IGFuZCB0 aGVuIHN1c3BlbmRpbmcgdGhlIFZNOgo+IAo+ICAgICAgaW1wb3J0IHB5eHMsIHRpbWUKPiAgICAg IGMgPSBweXhzLmNsaWVudC5DbGllbnQoeGVuX2J1c19wYXRoPSIvZGV2L3hlbi94ZW5idXMiKQo+ ICAgICAgYy5jb25uZWN0KCkKPiAgICAgIGMudHJhbnNhY3Rpb24oKQo+ICAgICAgdGltZS5zbGVl cCgzNjAwKQo+IAo+IEV2ZW4gaWYgdGhpcyBkZWFkbG9jayB3ZXJlIHJlc29sdmVkLCBtaXNiZWhh dmluZyB1c2Vyc3BhY2Ugc2hvdWxkIG5vdAo+IHByZXZlbnQgYSBWTSBmcm9tIGJlaW5nIG1pZ3Jh dGVkLiBTbywgaW5zdGVhZCBvZiB3YWl0aW5nIGZvciB0aGVzZQo+IHRyYW5zYWN0aW9ucyB0byBj b21wbGV0ZSBiZWZvcmUgc3VzcGVuZGluZywgc3RvcmUgdGhlIGN1cnJlbnQgZ2VuZXJhdGlvbgo+ IGlkIGZvciBlYWNoIHRyYW5zYWN0aW9uIHdoZW4gaXQgaXMgc3RhcnRlZC4gVGhlIGdsb2JhbCBn ZW5lcmF0aW9uIGlkIGlzCj4gaW5jcmVtZW50ZWQgZHVyaW5nIHJlc3VtZS4gSWYgdGhlIGNhbGxl ciBjb21taXRzIHRoZSB0cmFuc2FjdGlvbiBhbmQgdGhlCj4gZ2VuZXJhdGlvbiBpZCBkb2VzIG5v dCBtYXRjaCB0aGUgY3VycmVudCBnZW5lcmF0aW9uIGlkLCByZXR1cm4gRUFHQUlOIHNvCj4gdGhh dCB0aGV5IHRyeSBhZ2Fpbi4gSWYgdGhlIHRyYW5zYWN0aW9uIHdhcyBpbnN0ZWFkIGRpc2NhcmRl ZCwgcmV0dXJuIE9LCj4gc2luY2Ugbm8gY2hhbmdlcyB3ZXJlIG1hZGUgYW55d2F5Lgo+IAo+IFRo aXMgb25seSBhZmZlY3RzIHVzZXJzIG9mIHRoZSB4ZW5idXMgZmlsZSBpbnRlcmZhY2UuIEluLWtl cm5lbCB1c2VycyBvZgo+IHhlbmJ1cyBhcmUgYXNzdW1lZCB0byBiZSB3ZWxsLWJlaGF2ZWQgYW5k IGNvbXBsZXRlIGFsbCB0cmFuc2FjdGlvbnMKPiBiZWZvcmUgZnJlZXppbmcuCj4gCj4gU2lnbmVk LW9mZi1ieTogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+Cj4gLS0t Cj4gCj4gQ2hhbmdlZCBpbiB2MjogcmV3cm90ZSBhY2NvcmRpbmcgdG8gSnVlcmdlbidzIHN1Z2dl c3Rpb24uCj4gCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmggICAgICAgICAgICAgIHwg IDMgKysrCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2Rldl9mcm9udGVuZC5jIHwgMTgg KysrKysrKysrKysrKysrKysrCj4gICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMgICAg ICAgICAgIHwgIDcgKysrKystLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVu YnVzLmggYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgKPiBpbmRleCAwOTI5ODExNzFkZjEu LmQ3NWEyMzg1YjM3YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgK PiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzLmgKPiBAQCAtODMsNiArODMsNyBAQCBz dHJ1Y3QgeGJfcmVxX2RhdGEgewo+ICAgCWludCBudW1fdmVjczsKPiAgIAlpbnQgZXJyOwo+ICAg CWVudW0geGJfcmVxX3N0YXRlIHN0YXRlOwo+ICsJYm9vbCB1c2VyX3JlcTsKPiAgIAl2b2lkICgq Y2IpKHN0cnVjdCB4Yl9yZXFfZGF0YSAqKTsKPiAgIAl2b2lkICpwYXI7Cj4gICB9Owo+IEBAIC0x MzMsNCArMTM0LDYgQEAgdm9pZCB4ZW5idXNfcmluZ19vcHNfaW5pdCh2b2lkKTsKPiAgIGludCB4 ZW5idXNfZGV2X3JlcXVlc3RfYW5kX3JlcGx5KHN0cnVjdCB4c2Rfc29ja21zZyAqbXNnLCB2b2lk ICpwYXIpOwo+ICAgdm9pZCB4ZW5idXNfZGV2X3F1ZXVlX3JlcGx5KHN0cnVjdCB4Yl9yZXFfZGF0 YSAqcmVxKTsKPiAgIAo+ICtleHRlcm4gdW5zaWduZWQgaW50IHhiX2Rldl9nZW5lcmF0aW9uX2lk Owo+ICsKPiAgICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVz X2Rldl9mcm9udGVuZC5jIGIvZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19kZXZfZnJvbnRlbmQu Ywo+IGluZGV4IDA3ODJmZjNjMjI3My4uMzljNjMxNTJhMzU4IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMveGVuL3hlbmJ1cy94ZW5idXNfZGV2X2Zyb250ZW5kLmMKPiArKysgYi9kcml2ZXJzL3hlbi94 ZW5idXMveGVuYnVzX2Rldl9mcm9udGVuZC5jCj4gQEAgLTYyLDYgKzYyLDggQEAKPiAgIAo+ICAg I2luY2x1ZGUgInhlbmJ1cy5oIgo+ICAgCj4gK3Vuc2lnbmVkIGludCB4Yl9kZXZfZ2VuZXJhdGlv bl9pZDsKPiArCj4gICAvKgo+ICAgICogQW4gZWxlbWVudCBvZiBhIGxpc3Qgb2Ygb3V0c3RhbmRp bmcgdHJhbnNhY3Rpb25zLCBmb3Igd2hpY2ggd2UncmUKPiAgICAqIHN0aWxsIHdhaXRpbmcgYSBy ZXBseS4KPiBAQCAtNjksNiArNzEsNyBAQAo+ICAgc3RydWN0IHhlbmJ1c190cmFuc2FjdGlvbl9o b2xkZXIgewo+ICAgCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKPiAgIAlzdHJ1Y3QgeGVuYnVzX3Ry YW5zYWN0aW9uIGhhbmRsZTsKPiArCXVuc2lnbmVkIGludCBnZW5lcmF0aW9uX2lkOwo+ICAgfTsK PiAgIAo+ICAgLyoKPiBAQCAtNDQxLDYgKzQ0NCw3IEBAIHN0YXRpYyBpbnQgeGVuYnVzX3dyaXRl X3RyYW5zYWN0aW9uKHVuc2lnbmVkIG1zZ190eXBlLAo+ICAgCQkJcmMgPSAtRU5PTUVNOwo+ICAg CQkJZ290byBvdXQ7Cj4gICAJCX0KPiArCQl0cmFucy0+Z2VuZXJhdGlvbl9pZCA9IHhiX2Rldl9n ZW5lcmF0aW9uX2lkOwo+ICAgCQlsaXN0X2FkZCgmdHJhbnMtPmxpc3QsICZ1LT50cmFuc2FjdGlv bnMpOwo+ICAgCX0gZWxzZSBpZiAobXNnLT5oZHIudHhfaWQgIT0gMCAmJgo+ICAgCQkgICAheGVu YnVzX2dldF90cmFuc2FjdGlvbih1LCBtc2ctPmhkci50eF9pZCkpCj4gQEAgLTQ0OSw2ICs0NTMs MjAgQEAgc3RhdGljIGludCB4ZW5idXNfd3JpdGVfdHJhbnNhY3Rpb24odW5zaWduZWQgbXNnX3R5 cGUsCj4gICAJCSAhKG1zZy0+aGRyLmxlbiA9PSAyICYmCj4gICAJCSAgICghc3RyY21wKG1zZy0+ Ym9keSwgIlQiKSB8fCAhc3RyY21wKG1zZy0+Ym9keSwgIkYiKSkpKQo+ICAgCQlyZXR1cm4geGVu YnVzX2NvbW1hbmRfcmVwbHkodSwgWFNfRVJST1IsICJFSU5WQUwiKTsKPiArCWVsc2UgaWYgKG1z Z190eXBlID09IFhTX1RSQU5TQUNUSU9OX0VORCkgewo+ICsJCXRyYW5zID0geGVuYnVzX2dldF90 cmFuc2FjdGlvbih1LCBtc2ctPmhkci50eF9pZCk7Cj4gKwkJaWYgKHRyYW5zICYmIHRyYW5zLT5n ZW5lcmF0aW9uX2lkICE9IHhiX2Rldl9nZW5lcmF0aW9uX2lkKSB7Cj4gKwkJCWxpc3RfZGVsKCZ0 cmFucy0+bGlzdCk7Cj4gKwkJCWtmcmVlKHRyYW5zKTsKPiArCQkJaWYgKCFzdHJjbXAobXNnLT5i b2R5LCAiVCIpKQo+ICsJCQkJcmV0dXJuIHhlbmJ1c19jb21tYW5kX3JlcGx5KHUsIFhTX0VSUk9S LAo+ICsJCQkJCQkJICAgICJFQUdBSU4iKTsKPiArCQkJZWxzZQo+ICsJCQkJcmV0dXJuIHhlbmJ1 c19jb21tYW5kX3JlcGx5KHUsCj4gKwkJCQkJCQkgICAgWFNfVFJBTlNBQ1RJT05fRU5ELAo+ICsJ CQkJCQkJICAgICJPSyIpOwo+ICsJCX0KPiArCX0KPiAgIAo+ICAgCXJjID0geGVuYnVzX2Rldl9y ZXF1ZXN0X2FuZF9yZXBseSgmbXNnLT5oZHIsIHUpOwo+ICAgCWlmIChyYyAmJiB0cmFucykgewo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMgYi9kcml2ZXJzL3hl bi94ZW5idXMveGVuYnVzX3hzLmMKPiBpbmRleCA0OWEzODc0YWU2YmIuLmRkYzE4ZGE2MTgzNCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMKPiArKysgYi9kcml2 ZXJzL3hlbi94ZW5idXMveGVuYnVzX3hzLmMKPiBAQCAtMTA1LDYgKzEwNSw3IEBAIHN0YXRpYyB2 b2lkIHhzX3N1c3BlbmRfZW50ZXIodm9pZCkKPiAgIAo+ICAgc3RhdGljIHZvaWQgeHNfc3VzcGVu ZF9leGl0KHZvaWQpCj4gICB7Cj4gKwl4Yl9kZXZfZ2VuZXJhdGlvbl9pZCsrOwo+ICAgCXNwaW5f bG9jaygmeHNfc3RhdGVfbG9jayk7Cj4gICAJeHNfc3VzcGVuZF9hY3RpdmUtLTsKPiAgIAlzcGlu X3VubG9jaygmeHNfc3RhdGVfbG9jayk7Cj4gQEAgLTEyNSw3ICsxMjYsNyBAQCBzdGF0aWMgdWlu dDMyX3QgeHNfcmVxdWVzdF9lbnRlcihzdHJ1Y3QgeGJfcmVxX2RhdGEgKnJlcSkKPiAgIAkJc3Bp bl9sb2NrKCZ4c19zdGF0ZV9sb2NrKTsKPiAgIAl9Cj4gICAKPiAtCWlmIChyZXEtPnR5cGUgPT0g WFNfVFJBTlNBQ1RJT05fU1RBUlQpCj4gKwlpZiAocmVxLT50eXBlID09IFhTX1RSQU5TQUNUSU9O X1NUQVJUICYmICFyZXEtPnVzZXJfcmVxKQo+ICAgCQl4c19zdGF0ZV91c2VycysrOwo+ICAgCXhz X3N0YXRlX3VzZXJzKys7Cj4gICAJcnFfaWQgPSB4c19yZXF1ZXN0X2lkKys7Cj4gQEAgLTE0MCw3 ICsxNDEsNyBAQCB2b2lkIHhzX3JlcXVlc3RfZXhpdChzdHJ1Y3QgeGJfcmVxX2RhdGEgKnJlcSkK PiAgIAlzcGluX2xvY2soJnhzX3N0YXRlX2xvY2spOwo+ICAgCXhzX3N0YXRlX3VzZXJzLS07Cj4g ICAJaWYgKChyZXEtPnR5cGUgPT0gWFNfVFJBTlNBQ1RJT05fU1RBUlQgJiYgcmVxLT5tc2cudHlw ZSA9PSBYU19FUlJPUikgfHwKPiAtCSAgICAocmVxLT50eXBlID09IFhTX1RSQU5TQUNUSU9OX0VO RCAmJgo+ICsJICAgIChyZXEtPnR5cGUgPT0gWFNfVFJBTlNBQ1RJT05fRU5EICYmICFyZXEtPnVz ZXJfcmVxICYmCj4gICAJICAgICAhV0FSTl9PTl9PTkNFKHJlcS0+bXNnLnR5cGUgPT0gWFNfRVJS T1IgJiYKPiAgIAkJCSAgICFzdHJjbXAocmVxLT5ib2R5LCAiRU5PRU5UIikpKSkKPiAgIAkJeHNf c3RhdGVfdXNlcnMtLTsKPiBAQCAtMjg2LDYgKzI4Nyw3IEBAIGludCB4ZW5idXNfZGV2X3JlcXVl c3RfYW5kX3JlcGx5KHN0cnVjdCB4c2Rfc29ja21zZyAqbXNnLCB2b2lkICpwYXIpCj4gICAJcmVx LT5udW1fdmVjcyA9IDE7Cj4gICAJcmVxLT5jYiA9IHhlbmJ1c19kZXZfcXVldWVfcmVwbHk7Cj4g ICAJcmVxLT5wYXIgPSBwYXI7Cj4gKwlyZXEtPnVzZXJfcmVxID0gdHJ1ZTsKPiAgIAo+ICAgCXhz X3NlbmQocmVxLCBtc2cpOwo+ICAgCj4gQEAgLTMxMyw2ICszMTUsNyBAQCBzdGF0aWMgdm9pZCAq eHNfdGFsa3Yoc3RydWN0IHhlbmJ1c190cmFuc2FjdGlvbiB0LAo+ICAgCXJlcS0+dmVjID0gaW92 ZWM7Cj4gICAJcmVxLT5udW1fdmVjcyA9IG51bV92ZWNzOwo+ICAgCXJlcS0+Y2IgPSB4c193YWtl X3VwOwo+ICsJcmVxLT51c2VyX3JlcSA9IGZhbHNlOwo+ICAgCj4gICAJbXNnLnJlcV9pZCA9IDA7 Cj4gICAJbXNnLnR4X2lkID0gdC5pZDsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3hlbi1kZXZlbA==