xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>,
	linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
	rt@linutronix.de, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
Date: Mon, 4 Apr 2016 17:21:45 +0100	[thread overview]
Message-ID: <57029499.7070007__29837.4108657756$1459786986$gmane$org@arm.com> (raw)
In-Reply-To: <1459773140-43707-1-git-send-email-anna-maria@linutronix.de>

(CC Stefano new e-mail address)

Hello Anna-Maria,

On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
>   arch/arm/xen/enlighten.c         |    6 ++++++
>   arch/x86/xen/enlighten.c         |    7 +++++++
>   drivers/xen/events/events_fifo.c |    6 ++++++
>   3 files changed, 19 insertions(+)
>
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
>   				unsigned long action,
>   				void *hcpu)
>   {
> +	/*
> +	 * Xen guests do not offline/online CPUs during
> +	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> +	 * are not considered.
> +	 */
> +
>   	switch (action) {
>   	case CPU_STARTING:
>   		xen_percpu_init();
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1788,6 +1788,13 @@ static int xen_hvm_cpu_notify(struct not
>   			      void *hcpu)
>   {
>   	int cpu = (long)hcpu;
> +
> +	/*
> +	 * Xen guests do not offline/online CPUs during
> +	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> +	 * are not considered.
> +	 */
> +
>   	switch (action) {
>   	case CPU_UP_PREPARE:
>   		xen_vcpu_setup(cpu);
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>   	int cpu = (long)hcpu;
>   	int ret = 0;
>
> +	/*
> +	 * Xen guests do not offline/online CPUs during
> +	 * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> +	 * are not considered.
> +	*/

NIT: The '*' is not aligned with the others.

> +
>   	switch (action) {
>   	case CPU_UP_PREPARE:
>   		if (!per_cpu(cpu_control_block, cpu))
>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

       reply	other threads:[~2016-04-04 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1459773140-43707-1-git-send-email-anna-maria@linutronix.de>
2016-04-04 16:21 ` Julien Grall [this message]
     [not found] ` <57029499.7070007@arm.com>
2016-04-04 16:30   ` David Vrabel
     [not found]   ` <570296C3.70805@citrix.com>
2016-04-04 16:48     ` Boris Ostrovsky
     [not found]     ` <57029AC7.90201@oracle.com>
2016-04-05  4:22       ` Juergen Gross
     [not found]       ` <57033D78.8010306@suse.com>
2016-04-06 23:52         ` Stefano Stabellini
2016-04-06 13:09 ` David Vrabel
     [not found] ` <57050A98.80901@cantab.net>
2016-04-06 14:08   ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 23:53   ` Stefano Stabellini
2016-04-04 12:32 Anna-Maria Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='57029499.7070007__29837.4108657756$1459786986$gmane$org@arm.com' \
    --to=julien.grall@arm.com \
    --cc=anna-maria@linutronix.de \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rt@linutronix.de \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).