From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Changlong Xie" <xiecl.fnst@cn.fujitsu.com>,
"Ian Jackson" <Ian.Jackson@eu.citrix.com>,
"Wen Congyang" <wency@cn.fujitsu.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL
Date: Wed, 6 Apr 2016 12:29:34 +0100 [thread overview]
Message-ID: <5704F31E.7020908@citrix.com> (raw)
In-Reply-To: <1459940476-23186-4-git-send-email-wei.liu2@citrix.com>
On 06/04/16 12:01, Wei Liu wrote:
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 5b5dda4..79ff25e 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -410,12 +410,12 @@ PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.2.8 libnl-route-3.0 >= 3.2.8],
> [libnl3_lib="y"], [libnl3_lib="n"])
>
> AS_IF([test "x$libnl3_lib" = "xn" ], [
> - AC_MSG_WARN([Disabling support for Remus network buffering.
> + AC_MSG_WARN([Disabling support for Remus network buffering and COLO.
> Please install libnl3 libraries, command line tools and devel
> headers - version 3.2.8 or higher])
While playing in this area, could the text be expanded to something like:
"Please install libnl3 libraries (including libnl-route)"
I spent a rather long time trying to work out I couldn't enable netbuf
on a fresh install, as they are separate packages.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 11:01 [PATCH v2 0/4] COLO: only build when libnl is available Wei Liu
2016-04-06 11:01 ` [PATCH v2 1/4] libxl: colo: rearrange things in header files Wei Liu
2016-04-06 11:01 ` [PATCH v2 2/4] libxl: colo: move netlink related stuff to libxl_colo_proxy.c Wei Liu
2016-04-06 11:01 ` [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL Wei Liu
2016-04-06 11:29 ` Andrew Cooper [this message]
2016-04-06 11:32 ` Wei Liu
2016-04-06 13:44 ` Ian Jackson
2016-04-06 11:01 ` [PATCH v2 4/4] libxl: colo: make it depend on availability of libnl Wei Liu
2016-04-06 13:44 ` Ian Jackson
2016-04-06 11:04 ` [PATCH v2 0/4] COLO: only build when libnl is available Wei Liu
2016-04-06 13:56 ` Wei Liu
2016-04-06 14:10 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704F31E.7020908@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).