From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v4 08/14] apm32: remove paravirt_enabled() use Date: Thu, 7 Apr 2016 09:08:36 -0400 Message-ID: <57065BD4.3040209@oracle.com> References: <1459987594-5434-1-git-send-email-mcgrof@kernel.org> <1459987594-5434-9-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1459987594-5434-9-git-send-email-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: "Luis R. Rodriguez" , bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Cc: x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xensource.com, lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com, jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: > There is already a check for apm_info.bios == 0, the > apm_info.bios is set from the boot_params.apm_bios_info. > Both Xen and lguest, which are also the only ones that set > paravirt_enabled to true, never set the apm_bios.info. The > > Xen folks are sure force disable to 0 is not needed, Because apm_info lives in .bss (which we recently made sure is cleared on Xen PV). May be worth mentioning in the commit message so that we don't forget why this is not needed. I think you also have this statement in other patches. -boris > we > recently forced disabled this on lguest. With this in place > the paravirt_enabled() check is simply not needed anymore. > > Signed-off-by: Luis R. Rodriguez > --- > arch/x86/kernel/apm_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c > index 9307f182fe30..c7364bd633e1 100644 > --- a/arch/x86/kernel/apm_32.c > +++ b/arch/x86/kernel/apm_32.c > @@ -2267,7 +2267,7 @@ static int __init apm_init(void) > > dmi_check_system(apm_dmi_table); > > - if (apm_info.bios.version == 0 || paravirt_enabled() || machine_is_olpc()) { > + if (apm_info.bios.version == 0 || machine_is_olpc()) { > printk(KERN_INFO "apm: BIOS not found.\n"); > return -ENODEV; > }