From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.7] xen/build: Fix build with Clang
Date: Thu, 7 Apr 2016 20:16:18 +0100 [thread overview]
Message-ID: <5706B202.40004@citrix.com> (raw)
In-Reply-To: <5706BF3602000078000E600C@prv-mh.provo.novell.com>
On 07/04/16 20:12, Jan Beulich wrote:
>>>> On 07.04.16 at 20:46, <andrew.cooper3@citrix.com> wrote:
>> The clang build already has many duplicate symbols for some reason I have yet
>> to identify, e.g.
>>
>> Duplicate symbol 'asid.c#get_cpu_info' (ffff82d0801e6840 != ffff82d0801c8190)
>> Duplicate symbol 'ats.c#__list_add' (ffff82d08015b900 != ffff82d0801546a0)
>> Duplicate symbol 'common.c#clear_bit' (ffff82d080213560 != ffff82d0801baf10)
>> Duplicate symbol 'common.c#constant_test_bit' (ffff82d080213550 != ffff82d0801ba750)
>> Duplicate symbol 'common.c#cpumask_check' (ffff82d080218c50 != ffff82d0801baf20)
>> Duplicate symbol 'common.c#cpumask_clear_cpu' (ffff82d080214990 != ffff82d0801bae40)
>> Duplicate symbol 'common.c#get_cpu_info' (ffff82d080212210 != ffff82d0801bad20)
>>
>> The resulting binary does function. Someone with more time can investigate
>> making symbol handling work better with Clang
> I'd guess that's because they don't inline functions as aggressively
> as gcc does.
>
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -50,9 +50,15 @@ ALL_OBJS-$(CONFIG_X86) += $(BASEDIR)/crypto/built_in.o
>> CFLAGS += -nostdinc -fno-builtin -fno-common
>> CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
>> CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
>> -CFLAGS += -Wa,--strip-local-absolute
>> CFLAGS += '-D__OBJECT_FILE__="$@"'
>>
>> +ifneq ($(clang),y)
>> +# Clang doesn't understand this command line argument, and doesn't appear to
>> +# have an suitable alternative. The resulting compiled binary does function,
>> +# but has an excessively large symbol table.
>> +CFLAGS += -Wa,--strip-local-absolute
>> +endif
> Well, that's the brute force undo-it-altogether-for-clang approach
> that I think Doug had also considered. You may have seen the
> discussion (on irc iirc) - I'd really like to see the option still getting
> passed to gas (for all the .S files) even when using clang. Would
> that really be hard to arrange for?
That won't fix the fact that all the .c files which include
cpufeatureset.h also gets the absolute symbols, to allow the
alternatives() blocks to compile.
It will complicate the clang build quite a bit, and won't make much of a
dent on the symbol table bloat.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-07 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:46 [PATCH for-4.7] xen/build: Fix build with Clang Andrew Cooper
2016-04-07 19:12 ` Jan Beulich
2016-04-07 19:16 ` Andrew Cooper [this message]
2016-04-07 19:21 ` Jan Beulich
2016-04-07 19:23 ` Andrew Cooper
2016-04-07 20:55 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706B202.40004@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).