From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl
Date: Fri, 8 Apr 2016 00:05:09 +0100 [thread overview]
Message-ID: <5706E7A5.9010808@citrix.com> (raw)
In-Reply-To: <5706F31102000078000E6043@prv-mh.provo.novell.com>
On 07/04/2016 23:53, Jan Beulich wrote:
>>>> On 08.04.16 at 00:30, <andrew.cooper3@citrix.com> wrote:
>> On 07/04/2016 22:55, Jan Beulich wrote:
>>>>>> On 07.04.16 at 23:39, <andrew.cooper3@citrix.com> wrote:
>>>> @@ -1763,7 +1765,8 @@ static void load_segments(struct vcpu *n)
>>>> vcpu_info(n, evtchn_upcall_mask) = 1;
>>>>
>>>> regs->entry_vector |= TRAP_syscall;
>>>> - regs->_eflags &= 0xFFFCBEFFUL;
>>>> + regs->_eflags &= ~(X86_EFLAGS_AC|X86_EFLAGS_VM|X86_EFLAGS_RF|
>>>> + X86_EFLAGS_NT|X86_EFLAGS_IOPL|X86_EFLAGS_TF);
>>> Why AC, which didn't get cleared before? Did you just copy
>>> the 64-bit variant from below?
>> Yes,
>>
>>> Assuming so, with it removed Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> Why keep the disparity?
> Because there's no reason to clear AC for 32-bit guests.
Nor 64bit guests. A 64bit PV kernel should be acutely aware it is
running in ring3, and suitably audit flags at each of its entry points,
as all entry points have to do.
But as with all these hidden gems in the PV ABI, that ship has long
since sailed.
I will return it to how it was, although keeping the named constants.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-07 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 21:39 [PATCH for-4.7 v2 1/2] xen/x86: Remove the use of vm86_mode() Andrew Cooper
2016-04-07 21:39 ` [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl Andrew Cooper
2016-04-07 21:55 ` Jan Beulich
2016-04-07 22:30 ` Andrew Cooper
2016-04-07 22:53 ` Jan Beulich
2016-04-07 23:05 ` Andrew Cooper [this message]
2016-04-08 9:30 ` [PATCH for-4.7 v3 " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706E7A5.9010808@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).