From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Benjamin Sanda <ben.sanda@dornerworks.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v3 0/5] xentrace/xenalyze Support on ARM
Date: Fri, 8 Apr 2016 15:44:05 +0100 [thread overview]
Message-ID: <5707C3B5.8090404@citrix.com> (raw)
In-Reply-To: <57038EDF02000078000E30CB@prv-mh.provo.novell.com>
On 05/04/16 09:09, Jan Beulich wrote:
>>>> On 04.04.16 at 20:48, <ben.sanda@dornerworks.com> wrote:
>> This patch set adds support for xentrace/xenalyze to the ARM platform.
>>
>> The Xen heap memory mapping, timestamping, and P2M translation needed
>> by xentrace is corrected for operation on the ARM platform using the
>> x86 platform as reference. Trace buffer initialization is added to
>> setup.c, XENMAPSPACE_gmfn_foreign page mapping and address translation
>> for DOMID_XEN is corrected in mm.c and p2m.c, and timestamping for the
>> trace buffers is corrected in time.c/.h.
>>
>> Finally the xenaylze makefile is configured to build the tool for ARM.
>>
>> ---
>> Changed since v2:
>> * Merged previous single file patches into atomic patches which can
>> be applied and compiled independently.
>> * Updated individual patch names to be more descriptive.
>> * Correct order of patches in patch set to provide correct
>> application/build order.
>>
>> ---
>> Changed since v1:
>> * Removed Flask changes as deemed unnecessary and unclear in
>> purpose
>> * Corrected all commit messages to be line limited to 72 chars
>> * Implemented v1 review comments as indicated in each file's
>> commit log.
>>
>> Benjamin Sanda (5):
>> xentrace: Common Support for get_pg_owner/put_pg_owner on ARM and x86
>> xentrace: Memory/Page Mapping support for DOMID_XEN on ARM
>> xentrace: Timestamp support for ARM platform
>> xentrace: Trace Buffer Initialization on ARM
>> xenalyze: Build for Both ARM and x86 Platforms
>>
>> tools/xentrace/Makefile | 3 +--
>> xen/arch/arm/mm.c | 3 ++-
>> xen/arch/arm/p2m.c | 35 +++++++++++++++++++++++++++----
>> xen/arch/arm/setup.c | 3 +++
>> xen/arch/arm/time.c | 9 +++++++-
>> xen/arch/x86/mm.c | 48 -------------------------------------------
>> xen/common/page_alloc.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++
>> xen/include/asm-arm/time.h | 11 +++++-----
>> xen/include/xen/mm.h | 2 ++
>> 9 files changed, 103 insertions(+), 62 deletions(-)
>
> A couple of formal things: This is v3, and I only now notice indeed
> I should have looked at some of the patches. Yet which of them
> isn't clear - I'm being Cc-ed on all of them, instead of just the ones
> that submission guidelines say I should be. And then all patch
> subjects start with xenalyze: or xentrace:, suggesting this series
> isn't touching code other than those two. Generalization of
> {get,put}_pg_owner(), otoh, while apparently a prereq for the
> generalization of one or both of the two, should use a more
> indicative component prefix (or maybe even none at all).
To make things a bit more concrete, here might be a better set of
one-line descriptions that help people skimming figure out what pertains
to them and what's going on:
[1/5] xen: Move {get,put}_pg_owner() into common code
[2/5] xen/arm: Support mapping pages owned by DOMID_XEN
[3/5] xen/arm: Have get_cycles() use the hardware timestamp counter
[4/5] xen/arm: Enable tracing
[5/5] tools/xenalyze: Build on ARM
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-08 14:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:48 [PATCH v3 0/5] xentrace/xenalyze Support on ARM Benjamin Sanda
2016-04-04 18:48 ` [PATCH v3 1/5] xentrace: Common Support for get_pg_owner/put_pg_owner on ARM and x86 Benjamin Sanda
2016-04-04 23:05 ` Andrew Cooper
2016-04-05 8:12 ` Jan Beulich
2016-04-14 19:59 ` Ben Sanda
2016-04-17 7:58 ` Jan Beulich
2016-04-04 18:48 ` [PATCH v3 2/5] xentrace: Memory/Page Mapping support for DOMID_XEN on ARM Benjamin Sanda
2016-04-08 10:42 ` Julien Grall
2016-04-08 15:49 ` Jan Beulich
2016-04-08 17:58 ` Andrew Cooper
2016-04-11 9:52 ` George Dunlap
2016-04-12 15:53 ` Julien Grall
2016-04-14 19:52 ` Ben Sanda
2016-04-20 12:48 ` Julien Grall
2016-04-22 9:42 ` Stefano Stabellini
2016-04-22 17:01 ` Julien Grall
2016-04-04 18:48 ` [PATCH v3 3/5] xentrace: Timestamp support for ARM platform Benjamin Sanda
2016-04-08 10:50 ` Julien Grall
2016-04-11 14:56 ` Konrad Rzeszutek Wilk
2016-04-04 18:48 ` [PATCH v3 4/5] xentrace: Trace Buffer Initialization on ARM Benjamin Sanda
2016-04-08 10:53 ` Julien Grall
2016-04-04 18:48 ` [PATCH v3 5/5] xenalyze: Build for Both ARM and x86 Platforms Benjamin Sanda
2016-04-05 8:09 ` [PATCH v3 0/5] xentrace/xenalyze Support on ARM Jan Beulich
2016-04-06 16:51 ` Ben Sanda
2016-04-06 16:59 ` Andrew Cooper
2016-04-06 17:03 ` Ben Sanda
2016-04-08 14:44 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5707C3B5.8090404@citrix.com \
--to=george.dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ben.sanda@dornerworks.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).