xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Konrad Rzeszutek Wilk <konrad@kernel.org>
Cc: Martin Pohlack <mpohlack@amazon.de>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	sasha.levin@oracle.com
Subject: Re: [PATCH v7] xSplice v1 design and implementation.
Date: Tue, 12 Apr 2016 09:10:38 +0100	[thread overview]
Message-ID: <570CAD7E.2000201@citrix.com> (raw)
In-Reply-To: <20160411154339.GA1368@char.us.oracle.com>

On 04/11/2016 04:43 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Apr 11, 2016 at 10:32:20AM -0400, Konrad Rzeszutek Wilk wrote:
>>> *Hypervisor Maintainers*
>>>
>>> Jan, the hypervisor patches #2, #5-#17, #21-#23 need your Ack.
>>
>> s/Ack./Ack please./
>>> *Are there any TODOs left from v5 or v6 reviews?*
>>>
>>> One I hope can be deferred - that is xensyms_read which we use in
>>>   "[PATCH v7 12/24] xsplice,symbols: Implement symbol name resolution on
>>>   address." is not the fastest. It will need some tweaking (or a new
>>> function will have to be written) and I hope that this can be done in v4.8.
>>
>> Let me correct myself. I am right now looking at it - so I may have it
>> ready soonish but there are also bugs to work on.
>>
>>>
>>> The other is to test this on a 8 socket machine with tons of CPUs.
>>> Somebody else is using this beast right now. The impact is whether the default
>>> timeout of 30ms to quisce the CPUs should be increased on those beasts.
>>
>> A 240 CPUs box that is idle had no trouble with the default 30ms. I
>> will be putting some load on it and see how that goes later today.
>
> 100 guests (each 2VCPU) doing CPU intensive workload and the default 30ms
> timeout worked out just fine.
>

Yeah that works fine. The problem comes (on any machine) if your CPUs 
are busy in Xen code, then it's possible to fail a 30ms timeout. One way 
to reproduce this is to use several large guests with several vCPUs 
each, simultaneously localhost migrate them, then try and apply a patch. 
It's possible for this to trip a 5s watchdog timeout, let alone 30ms 
timeout. So what is important is not really the number of pCPUs but the 
kind of workload that it being run.

-- 
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-12  8:12 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-10 21:14 [PATCH v7] xSplice v1 design and implementation Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 01/24] xsplice: Design document Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 02/24] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 03/24] libxc: Implementation of XEN_XSPLICE_op in libxc Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 04/24] xen-xsplice: Tool to manipulate xsplice payloads Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 05/24] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 06/24] arm/x86/vmap: Add vmalloc_xen, vfree_xen and vm_init_type Konrad Rzeszutek Wilk
2016-04-11  9:39   ` Andrew Cooper
2016-04-11 13:29     ` Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 07/24] x86/mm: Introduce modify_xen_mappings() Konrad Rzeszutek Wilk
2016-04-11 12:51   ` George Dunlap
2016-04-11 13:00     ` Andrew Cooper
2016-04-11 14:04     ` [PATCH v7.1 " Andrew Cooper
2016-04-11 15:21       ` George Dunlap
2016-04-11 17:18       ` Jan Beulich
2016-04-11 17:33         ` Andrew Cooper
2016-04-11 17:46         ` [PATCH v7.2 " Andrew Cooper
2016-04-11 17:54           ` Jan Beulich
2016-04-12  9:08             ` Andrew Cooper
2016-04-10 21:14 ` [PATCH v7 08/24] xsplice: Add helper elf routines Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 09/24] xsplice: Implement payload loading Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 10/24] xsplice: Implement support for applying/reverting/replacing patches Konrad Rzeszutek Wilk
2016-04-11 10:14   ` Andrew Cooper
2016-04-11 13:29     ` Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 11/24] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version' Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 12/24] xsplice, symbols: Implement symbol name resolution on address Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 13/24] x86, xsplice: Print payload's symbol name and payload name in backtraces Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 14/24] xsplice: Add support for bug frames Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 15/24] xsplice: Add support for exception tables Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 16/24] xsplice: Add support for alternatives Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 17/24] build_id: Provide ld-embedded build-ids Konrad Rzeszutek Wilk
2016-04-11 12:17   ` Andrew Cooper
2016-04-11 13:31     ` Konrad Rzeszutek Wilk
2016-04-11 13:35       ` Andrew Cooper
2016-04-10 21:14 ` [PATCH v7 18/24] HYPERCALL_version_op: Add VERSION_build_id to retrieve build-id Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 19/24] libxl: info: Display build_id of the hypervisor using XEN_VERSION_build_id Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 20/24] xsplice: Print build_id in keyhandler and on bootup Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 21/24] xsplice: Stacking build-id dependency checking Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 22/24] xsplice/xen_replace_world: Test-case for XSPLICE_ACTION_REPLACE Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 23/24] xsplice: Prevent duplicate payloads from being loaded Konrad Rzeszutek Wilk
2016-04-10 21:14 ` [PATCH v7 24/24] MAINTAINERS/xsplice: Add myself and Ross as the maintainers Konrad Rzeszutek Wilk
2016-04-11 14:32 ` [PATCH v7] xSplice v1 design and implementation Konrad Rzeszutek Wilk
2016-04-11 15:43   ` Konrad Rzeszutek Wilk
2016-04-12  8:10     ` Ross Lagerwall [this message]
2016-04-12 20:59   ` Konrad Rzeszutek Wilk
2016-04-12 20:59     ` [PATCH v7 25/24] symbols/xsplice: Implement fast symbol names -> virtual addresses lookup Konrad Rzeszutek Wilk
2016-04-13  2:03       ` Konrad Rzeszutek Wilk
2016-04-13  2:17         ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570CAD7E.2000201@citrix.com \
    --to=ross.lagerwall@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=konrad@kernel.org \
    --cc=mpohlack@amazon.de \
    --cc=sasha.levin@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).