From: "Jan Beulich" <jbeulich@suse.com>
To: julien.grall@arm.com, xen-devel@lists.xen.org
Cc: andre.przywara@arm.com, keir@xen.org, sstabellini@kernel.org,
ian.jackson@eu.citrix.com, tim@xen.org
Subject: Re: [for-4.7 1/2] xen/bitops: Introduce macros to generate mask
Date: Wed, 13 Apr 2016 22:01:16 -0600 [thread overview]
Message-ID: <570F241C02000078000E66AA@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1460562931-19858-2-git-send-email-julien.grall@arm.com>
>>> Julien Grall <julien.grall@arm.com> 04/13/16 6:01 PM >>>
>--- a/xen/include/xen/bitops.h
>+++ b/xen/include/xen/bitops.h
>@@ -3,6 +3,17 @@
>#include <asm/types.h>
>
>/*
>+ * Create a contiguous bitmask starting at bit position @l and ending at
>+ * position @h. For example
>+ * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
>+ */
>+#define GENMASK(h, l) \
>+ (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
>+
>+#define GENMASK_ULL(h, l) \
>+ (((~0ULL) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
Irrespective of Linux perhaps considering them useful, I'm not sure they
are (and ISTR these macros having got proposed before). Plus - I don't
think we even have BITS_PER_LONG_LONG anywhere.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-14 4:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 15:55 [for-4.7 0/2] xen/arm: traps: Correctly interpret the content of the register HPFAR_EL2 Julien Grall
2016-04-13 15:55 ` [for-4.7 1/2] xen/bitops: Introduce macros to generate mask Julien Grall
2016-04-13 18:07 ` Stefano Stabellini
2016-04-13 18:14 ` Andrew Cooper
2016-04-14 8:47 ` Julien Grall
2016-04-14 4:01 ` Jan Beulich [this message]
2016-04-14 8:55 ` Julien Grall
2016-04-14 14:56 ` Jan Beulich
2016-04-14 15:08 ` Julien Grall
2016-04-14 15:23 ` Jan Beulich
2016-04-20 12:35 ` Julien Grall
2016-04-20 16:43 ` Jan Beulich
2016-04-22 11:33 ` Julien Grall
2016-04-22 11:49 ` Stefano Stabellini
2016-04-22 15:33 ` Julien Grall
2016-04-22 15:42 ` Stefano Stabellini
2016-04-13 15:55 ` [for-4.7 2/2] xen/arm: traps: Correctly interpret the content of the register HPFAR_EL2 Julien Grall
2016-04-13 18:17 ` Stefano Stabellini
2016-04-13 19:11 ` Tamas K Lengyel
2016-04-13 20:33 ` André Przywara
2016-04-14 17:47 ` [for-4.7 0/2] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F241C02000078000E66AA@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andre.przywara@arm.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=keir@xen.org \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).