From: Juergen Gross <jgross@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v12 1/2] libxl: add support for vscsi
Date: Thu, 14 Apr 2016 16:35:39 +0200 [thread overview]
Message-ID: <570FAABB.9040804@suse.com> (raw)
In-Reply-To: <20160414142731.GF4688@aepfle.de>
On 14/04/16 16:27, Olaf Hering wrote:
> On Thu, Apr 14, Juergen Gross wrote:
>
>> On 13/04/16 10:56, Olaf Hering wrote:
>>> + back = flexarray_make(gc, i, 1);
>> Shouldn't be this in the loop below? Otherwise the array might be
>> expanded with the same entries several times in case of a transaction
>> collision.
>
> I think the result would be like 'echo val > path ; echo val > path'.
> But in theory one iteration could enter XenbusStateConnected, and a
> following one another state. In practice this would be
> XenbusStateReconfiguring and the loop is done.
>
> What would be the way to free a flexarray? Looks like flexarray_free
> would lead to a double free if the gc itself is finally freed. Just
> overwriting 'back' would work, but does Coverity understand that the
> previous back is not leaked?
Overwriting the array pointer is done in other places already. Seems
as if this would be the way to go. See device_disk_add() in libxl.c
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-14 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 8:56 [PATCH v12 0/2] libxl: add support for pvscsi, iteration 12 Olaf Hering
2016-04-13 8:56 ` [PATCH v12 1/2] libxl: add support for vscsi Olaf Hering
2016-04-14 14:06 ` Juergen Gross
2016-04-14 14:27 ` Olaf Hering
2016-04-14 14:35 ` Juergen Gross [this message]
2016-04-14 14:43 ` Olaf Hering
2016-04-27 14:10 ` Wei Liu
2016-04-27 14:15 ` Olaf Hering
2016-04-13 8:57 ` [PATCH v12 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
2016-04-13 9:15 ` [PATCH libvirt v2 0/2] libxl: support vscsi Olaf Hering
2016-04-13 9:15 ` [PATCH libvirt v2 1/2] libxl: include a XLU_Config in _libxlDriverConfig Olaf Hering
2016-04-15 21:23 ` Jim Fehlig
2016-04-13 9:15 ` [PATCH libvirt v2 2/2] libxl: support vscsi Olaf Hering
2016-04-13 9:20 ` Olaf Hering
2016-04-15 22:20 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FAABB.9040804@suse.com \
--to=jgross@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).