xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86emul: special case far branch validation outside of long mode
Date: Thu, 21 Apr 2016 02:55:33 -0600	[thread overview]
Message-ID: <5718B1A502000078000E4450@prv-mh.provo.novell.com> (raw)
In-Reply-To: <571890F6.6040109@citrix.com>

>>> On 21.04.16 at 10:36, <andrew.cooper3@citrix.com> wrote:
> On 11/03/16 16:01, Jan Beulich wrote:
>> In that case (with the new value being held in, or now in one case cast
>> to, a 32-bit variable) there's no need to go through the long mode part
>> of the checks.
>>
>> Primarily this was meant to hopefully address Coverity ID 1355278, but
>> since the change produces smaller code as well I think we should use it
>> even if it doesn't help that (benign) warning.
>>
>> Also it's more in line with jmp_rel() for commit_far_branch() to do the
>> _regs.eip update, so adjust that at once.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Wei,

considering that this at least attempts to address a Coverity issue,
I'd like to ask for this to be considered to be allowed in despite
being past code freeze.

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-21  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 16:01 [PATCH] x86emul: special case far branch validation outside of long mode Jan Beulich
2016-04-21  8:36 ` Andrew Cooper
2016-04-21  8:55   ` Jan Beulich [this message]
2016-04-22 10:07     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5718B1A502000078000E4450@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).