xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Quan Xu <quan.xu@intel.com>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures
Date: Tue, 10 May 2016 02:02:31 -0600	[thread overview]
Message-ID: <5731B1B702000078000E9E13@prv-mh.provo.novell.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B8ABBE4@SHSMSX101.ccr.corp.intel.com>

>>> On 10.05.16 at 09:53, <quan.xu@intel.com> wrote:
> +    rc = hd->platform_ops->unmap_page(d, gfn);
> +
> +    if ( unlikely(rc) )
> +    {
> +        if ( printk_ratelimit() )
> +            printk(XENLOG_ERR
> +                   "iommu_unmap_page: IOMMU unmapping gfn %#lx failed for dom%d.",
> +                   gfn, d->domain_id);
> +
> +        if ( !is_hardware_domain(d) )
> +            domain_crash(d);
> +    }
> +
> +    return rc;

But please - as said - also avoid logging any message for already
dying domains.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-10  8:02 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  8:54 [PATCH v4 00/10] Check VT-d Device-TLB flush error Quan Xu
2016-05-06  8:54 ` [PATCH v4 01/10] vt-d: fix the IOMMU flush issue Quan Xu
2016-05-09 16:09   ` Jan Beulich
2016-05-12  7:50     ` Xu, Quan
2016-05-12  8:53       ` Jan Beulich
2016-05-12 13:29         ` Xu, Quan
2016-05-12 13:37           ` Jan Beulich
2016-05-12 13:43             ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures Quan Xu
2016-05-09 16:13   ` Jan Beulich
2016-05-10  3:41     ` Xu, Quan
2016-05-10  6:53       ` Jan Beulich
2016-05-10  7:53         ` Xu, Quan
2016-05-10  8:02           ` Jan Beulich [this message]
2016-05-10  8:20             ` Xu, Quan
2016-05-10  8:26               ` Jan Beulich
2016-05-12 14:28         ` Xu, Quan
2016-05-12 15:06           ` Jan Beulich
2016-05-13  8:04             ` Xu, Quan
2016-05-13  9:08               ` Jan Beulich
2016-05-13  9:20                 ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 03/10] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping Quan Xu
2016-05-10  8:44   ` Jan Beulich
2016-05-10 14:45     ` George Dunlap
2016-05-10 14:59       ` George Dunlap
2016-05-11  2:26         ` Xu, Quan
2016-05-11  8:45           ` George Dunlap
2016-05-11  8:58             ` Xu, Quan
2016-05-10 15:02       ` Jan Beulich
2016-05-11  2:29       ` Xu, Quan
2016-05-11  3:39     ` Xu, Quan
2016-05-11  7:02       ` Jan Beulich
2016-05-06  8:54 ` [PATCH v4 04/10] vt-d: propagate IOMMU Device-TLB flush error up to IOMMU unmapping Quan Xu
2016-05-10  8:50   ` Jan Beulich
2016-05-11  3:49     ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 05/10] vt-d: propagate IOMMU Device-TLB flush error up to IOMMU mapping Quan Xu
2016-05-06  8:54 ` [PATCH v4 06/10] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (top level ones) Quan Xu
2016-05-10  9:04   ` Jan Beulich
2016-05-11  5:52     ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 07/10] IOMMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (leaf ones) Quan Xu
2016-05-10  9:06   ` Jan Beulich
2016-05-11  6:47     ` Xu, Quan
2016-05-11  7:06       ` Jan Beulich
2016-05-11  7:12         ` Xu, Quan
2016-05-11  7:16           ` Jan Beulich
2016-05-11  7:20             ` Xu, Quan
2016-05-11  7:37               ` Jan Beulich
2016-05-06  8:54 ` [PATCH v4 08/10] vt-d/ept: propagate IOMMU Device-TLB flush error up to EPT update Quan Xu
2016-05-10  9:09   ` Jan Beulich
2016-05-10 14:58     ` George Dunlap
2016-05-10 15:04       ` Jan Beulich
2016-05-11  7:25     ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 09/10] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending Quan Xu
2016-05-10  9:24   ` Jan Beulich
2016-05-13  3:39     ` Xu, Quan
2016-05-13  6:16       ` Jan Beulich
2016-05-13  6:27         ` Xu, Quan
2016-05-06  8:54 ` [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping Quan Xu
2016-05-10  9:29   ` Jan Beulich
2016-05-11  8:35     ` Xu, Quan
2016-05-11  9:07       ` Jan Beulich
2016-05-12  5:16         ` Xu, Quan
2016-05-12  8:44           ` Jan Beulich
2016-05-12  9:02             ` Xu, Quan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5731B1B702000078000E9E13@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=dario.faggioli@citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=quan.xu@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).