From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V2 2/2] xen/arm: mm: clean up code in setup_pagetables Date: Thu, 12 May 2016 11:59:02 +0100 Message-ID: <573461F6.9060400@arm.com> References: <1463018504-26432-1-git-send-email-van.freenix@gmail.com> <1463018504-26432-2-git-send-email-van.freenix@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1463018504-26432-2-git-send-email-van.freenix@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Peng Fan , xen-devel@lists.xen.org, sstabellini@kernel.org List-Id: xen-devel@lists.xenproject.org SGkgUGVuZywKCkhpIFBlbmcsCgpPbiAxMi8wNS8xNiAwMzowMSwgUGVuZyBGYW4gd3JvdGU6Cj4g SW4gc2V0dXBfcGFnZXRhYmxlcywgbmVlZCB0byBtYXAgQk9PVF9SRUxPQ19WSVJUX1NUQVJUCj4g aW4geGVuX3NlY29uZCBhbmQgYm9vdF9zZWNvbmQsIHNvIHdlIGNhbiBtZXJnZSB0aGUgdHdvCj4g cGllY2VzIGNvZGUgaW50byBvbmUgY29kZSBibG9jay4KClRoZXJlIGlzIGEgbWlzc2luZyBzdWJq ZWN0IGZvciAibmVlZCIuIEkgd291bGQgc2F5OgoKIlRoZSBiYXNlIG9mIGFkZHJlc3MgZm9yIHRo ZSByZWxvY2F0ZWQgeGVuIG5lZWRzIHRvIGJlIG1hcHBlZCBhdCB0aGUgCnNhbWUgdmlydHVhbCBh ZGRyZXNzIChCT09UX1JFTE9DX1ZJUlRfU1RBUlQpIGluIGJvdGggdGhlIGJvb3QgYW5kIApydW50 aW1lIHBhZ2UgdGFibGVzLiBTbyB3ZSBjYW4gbWVyZ2UgdGhlIHR3byBwaWVjZXMgb2YgY29kZSBp bnRvIG9uIGNvZGUgCmJsb2NrLiIKCj4KPiBBbHNvIG5vIG5lZWQgdG8gdXNlIHdyaXRlX3B0ZSB3 aGVuIG1hcCBCT09UX1JFTE9DX1ZJUlRfU1RBUlQKPiBpbiB4ZW5fc2Vjb25kLCBiZWNhdXNlIENQ VTAgaXMgdXNpbmcgYm9vdCBwYWdlIHRhYmxlcyBub3cuCj4KPiBTaWduZWQtb2ZmLWJ5OiBQZW5n IEZhbiA8dmFuLmZyZWVuaXhAZ21haWwuY29tPgo+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ2M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFy bS5jb20+Cj4gLS0tCj4KPiBWMjoKPiAgIEZvbGxvdyBKdWxpZW4ncyBjb21tZW50czoKPiAgICAg c3BsaXQgdGhlIFYxIHBhdGNoIGludG8gdHdvIHBhdGNoZXMsIHRoaXMgcGF0Y2ggaXMgdGhlIGNv ZGUgbW92ZW1lbnQgcGFydC4KPgo+ICAgeGVuL2FyY2gvYXJtL21tLmMgfCAxMCArKysrLS0tLS0t Cj4gICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tbS5jIGIveGVuL2FyY2gvYXJtL21tLmMKPiBpbmRl eCBhZGRkNjk5Li4wYTRmODQ1IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9tbS5jCj4gKysr IGIveGVuL2FyY2gvYXJtL21tLmMKPiBAQCAtNDQzLDExICs0NDMsNiBAQCB2b2lkIF9faW5pdCBz ZXR1cF9wYWdldGFibGVzKHVuc2lnbmVkIGxvbmcgYm9vdF9waHlzX29mZnNldCwgcGFkZHJfdCB4 ZW5fcGFkZHIpCj4gICAgICAgbHBhZV90IHB0ZSwgKnA7Cj4gICAgICAgaW50IGk7Cj4KPiAtICAg IC8qIE1hcCB0aGUgZGVzdGluYXRpb24gaW4gdGhlIGJvb3QgbWlzYyBhcmVhLiAqLwo+IC0gICAg ZGVzdF92YSA9IEJPT1RfUkVMT0NfVklSVF9TVEFSVDsKPiAtICAgIHB0ZSA9IG1mbl90b194ZW5f ZW50cnkoeGVuX3BhZGRyID4+IFBBR0VfU0hJRlQsIFdSSVRFQUxMT0MpOwo+IC0gICAgd3JpdGVf cHRlKHhlbl9zZWNvbmQgKyBzZWNvbmRfdGFibGVfb2Zmc2V0KGRlc3RfdmEpLCBwdGUpOwo+IC0K PiAgICAgICAvKiBDYWxjdWxhdGUgdmlydC10by1waHlzIG9mZnNldCBmb3IgdGhlIG5ldyBsb2Nh dGlvbiAqLwo+ICAgICAgIHBoeXNfb2Zmc2V0ID0geGVuX3BhZGRyIC0gKHVuc2lnbmVkIGxvbmcp IF9zdGFydDsKPgo+IEBAIC00OTQsOSArNDg5LDEyIEBAIHZvaWQgX19pbml0IHNldHVwX3BhZ2V0 YWJsZXModW5zaWduZWQgbG9uZyBib290X3BoeXNfb2Zmc2V0LCBwYWRkcl90IHhlbl9wYWRkcikK PiAgICAgICBwdGUgPSBib290X3NlY29uZFtzZWNvbmRfdGFibGVfb2Zmc2V0KEJPT1RfRkRUX1ZJ UlRfU1RBUlQpXTsKPiAgICAgICB4ZW5fc2Vjb25kW3NlY29uZF90YWJsZV9vZmZzZXQoQk9PVF9G RFRfVklSVF9TVEFSVCldID0gcHRlOwo+Cj4gLSAgICAvKiBNYXAgdGhlIGRlc3RpbmF0aW9uIGlu IHRoZSBib290IG1pc2MgYXJlYS4gKi8KPiArICAgIC8qIC4uLiBCb290IE1pc2MgYXJlYSBmb3Ig eGVuIHJlbG9jYXRpb24gKi8KPiAgICAgICBkZXN0X3ZhID0gQk9PVF9SRUxPQ19WSVJUX1NUQVJU Owo+ICAgICAgIHB0ZSA9IG1mbl90b194ZW5fZW50cnkoeGVuX3BhZGRyID4+IFBBR0VfU0hJRlQs IFdSSVRFQUxMT0MpOwo+ICsgICAgLyogTWFwIHRoZSBkZXN0aW5hdGlvbiBpbiB4ZW5fc2Vjb25k LiAqLwo+ICsgICAgeGVuX3NlY29uZFtzZWNvbmRfdGFibGVfb2Zmc2V0KGRlc3RfdmEpXSA9IHB0 ZTsKPiArICAgIC8qIE1hcCB0aGUgZGVzdGluYXRpb24gaW4gYm9vdF9zZWNvbmQuICovCj4gICAg ICAgd3JpdGVfcHRlKGJvb3Rfc2Vjb25kICsgc2Vjb25kX3RhYmxlX29mZnNldChkZXN0X3ZhKSwg cHRlKTsKPiAgICAgICBmbHVzaF94ZW5fZGF0YV90bGJfcmFuZ2VfdmFfbG9jYWwoZGVzdF92YSwg U0VDT05EX1NJWkUpOwo+ICAgI2lmZGVmIENPTkZJR19BUk1fNjQKPgoKUmVnYXJkcywKCi0tIApK dWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDov L2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==