From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
GeorgeDunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH for-4.7] xen/nested_p2m: Don't walk EPT tables with a regular PT walker
Date: Fri, 13 May 2016 09:31:32 -0600 [thread overview]
Message-ID: <57360F7402000078000EB4F4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5735F1A6.8090603@citrix.com>
>>> On 13.05.16 at 17:24, <andrew.cooper3@citrix.com> wrote:
> On 13/05/16 16:00, Andrew Cooper wrote:
>> On 13/05/16 15:13, Jan Beulich wrote:
>>>>>> On 13.05.16 at 15:33, <andrew.cooper3@citrix.com> wrote:
>>>> --- a/xen/arch/x86/mm/hap/nested_hap.c
>>>> +++ b/xen/arch/x86/mm/hap/nested_hap.c
>>>> @@ -141,7 +141,7 @@ nestedhap_fix_p2m(struct vcpu *v, struct p2m_domain
> *p2m,
>>>> * walk is successful, the translated value is returned in
>>>> * L1_gpa. The result value tells what to do next.
>>>> */
>>>> -static int
>>>> +int
>>>> nestedhap_walk_L1_p2m(struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa,
>>>> unsigned int *page_order, uint8_t *p2m_acc,
>>> The function becoming non-static widens the visibility of the bogus
>>> uint8_t here (should be p2m_access_t afaics). Granted this isn't an
>>> issue the patch introduces, but I would prefer this to be adjusted
>>> prior to dropping the static here...
>>>
>>>> --- a/xen/arch/x86/mm/p2m.c
>>>> +++ b/xen/arch/x86/mm/p2m.c
>>>> @@ -2081,20 +2081,29 @@ unsigned long paging_gva_to_gfn(struct vcpu *v,
>>>>
>>>> if ( is_hvm_vcpu(v) && paging_mode_hap(v->domain) && nestedhvm_is_n2(v) )
>>>> {
>>>> - unsigned long gfn;
>>>> + unsigned long l2_gfn, l1_gfn;
>>>> struct p2m_domain *p2m;
>>>> const struct paging_mode *mode;
>>>> - uint32_t pfec_21 = *pfec;
>>>> uint64_t np2m_base = nhvm_vcpu_p2m_base(v);
>>>> + uint8_t l1_p2ma;
>>> ... avoiding proliferation of the quirkiness.
>> Will do.
>
> It turns out that this is currently hard, due to a tangle of header files.
And I withdraw the request then.
> I will put this on my TODO list, but this point, I have more important
> things to do for 4.7.
Thanks, understood.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-13 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 13:33 [PATCH for-4.7] xen/nested_p2m: Don't walk EPT tables with a regular PT walker Andrew Cooper
2016-05-13 14:13 ` Jan Beulich
2016-05-13 15:00 ` Andrew Cooper
2016-05-13 15:19 ` Jan Beulich
2016-05-13 17:25 ` [PATCH v2 " Andrew Cooper
2016-05-17 6:06 ` Tian, Kevin
2016-05-18 13:36 ` George Dunlap
2016-05-18 13:50 ` Wei Liu
2016-05-13 15:24 ` [PATCH " Andrew Cooper
2016-05-13 15:31 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57360F7402000078000EB4F4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).