From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Tim Deegan <tim@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 2/6] build: convert crash_debug to Kconfig
Date: Wed, 18 May 2016 03:14:27 -0600 [thread overview]
Message-ID: <573C4E9302000078000EC68E@prv-mh.provo.novell.com> (raw)
In-Reply-To: <44b4d3c1-c125-d7d1-2506-1d1a43612fd9@cardoe.com>
>>> On 18.05.16 at 04:15, <cardoe@cardoe.com> wrote:
> On 5/12/16 4:03 AM, Jan Beulich wrote:
>>>>> On 11.05.16 at 19:35, <cardoe@cardoe.com> wrote:
>>> On 5/11/16 4:47 AM, Jan Beulich wrote:
>>>>>>> On 10.05.16 at 23:05, <cardoe@cardoe.com> wrote:
>>>>> --- a/xen/Kconfig.debug
>>>>> +++ b/xen/Kconfig.debug
>>>>> @@ -1,6 +1,13 @@
>>>>>
>>>>> menu "Debugging Options"
>>>>>
>>>>> +config CRASH_DEBUG
>>>>> + bool "Crash Debugging Support"
>>>>> + depends on X86
>>>>> + ---help---
>>>>> + If you want to be able to attach gdb to Xen to be able to debug
>>>>> + Xen if it crashes then say Y.
>>>>> +
>>>>> config DEBUG
>>>>> bool "Developer Checks"
>>>>> ---help---
>>>>
>>>> Is this really meant to be independent of DEBUG (or EXPERT), as it's
>>>> being placed ahead of DEBUG?
>>>
>>> That's what we talked about with v2. You wanted it to be independent if
>>> EXPERT was set but when you have something defined as "menuconfig XXXX"
>>> you cannot then have a rule "if XXXX || EXPERT" as you asked for in v2.
>>> So I needed to make them independent always which is what I did.
>>>
>>> Let me restate more generically, if things are dependent on a menu for
>>> the sub-menu items to be displayed (as in v2) then the menu must be
>>> enabled and cannot be conditionally displayed on another option.
>>>
>>> Roughly think of it this way:
>>>
>>> menuconfig SOME_STATE
>>>
>>> if SOME_STATE || EXPERT
>>>
>>> config OTHER
>>>
>>> endif
>>>
>>>
>>> is the following code:
>>>
>>>
>>> if (SOME_STATE) {
>>> if (SOME_STATE or EXPERT) {
>>> printf("got here\n");
>>> }
>>> }
>>
>> But there's no menuconfig anymore, for precisely that reason (aiui).
>
> Right. That's what I was trying to get across. What I gathered from past
> reviews is that it should to be independent of DEBUG correct?
"It" being what? The CRASH_DEBUG above? That would be the
question I asked you in my initial reply (still visible above); I
don't think it should be, but instead should, like all the other
DEBUG controlled ones, be dependent on "DEBUG || EXPERT" as
said a number of times.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-18 9:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 21:05 [PATCH v3 0/6] Kconfig debug options Doug Goldstein
2016-05-10 21:05 ` [PATCH v3 1/6] build: add debug menu to Kconfig Doug Goldstein
2016-05-13 18:07 ` Konrad Rzeszutek Wilk
2016-05-10 21:05 ` [PATCH v3 2/6] build: convert crash_debug " Doug Goldstein
2016-05-11 9:47 ` Jan Beulich
2016-05-11 17:35 ` Doug Goldstein
2016-05-12 9:03 ` Jan Beulich
2016-05-18 2:15 ` Doug Goldstein
2016-05-18 9:14 ` Jan Beulich [this message]
2016-05-10 21:05 ` [PATCH v3 3/6] build: convert verbose " Doug Goldstein
2016-05-11 9:45 ` Jan Beulich
2016-05-11 17:37 ` Doug Goldstein
2016-05-12 9:04 ` Jan Beulich
2016-05-18 2:16 ` Doug Goldstein
2016-05-18 9:18 ` Jan Beulich
2016-05-10 21:05 ` [PATCH v3 4/6] build: convert frame_pointer " Doug Goldstein
2016-05-10 21:05 ` [PATCH v3 5/6] build: convert perfc{, _arrays} " Doug Goldstein
2016-05-11 9:53 ` Jan Beulich
2016-05-11 18:39 ` Doug Goldstein
2016-05-12 9:07 ` Jan Beulich
2016-05-10 21:05 ` [PATCH v3 6/6] build: convert lock_profile " Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573C4E9302000078000EC68E@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).