From: "Jan Beulich" <JBeulich@suse.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
pengtaox.zhang@intel.com,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
Christoph Egger <chegger@amazon.de>,
xudong.hao@intel.com, xen-devel@lists.xen.org,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject
Date: Fri, 27 May 2016 08:03:42 -0600 [thread overview]
Message-ID: <57486FDE02000078000EF407@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160527133033.7412-1-haozhong.zhang@intel.com>
>>> On 27.05.16 at 15:30, <haozhong.zhang@intel.com> wrote:
> Commit 26646f3 "x86/mce: translate passed-in GPA to host machine
> address" and commit 4ddf474 "tools/xen-mceinj: Pass in GPA when
> injecting through MSR_MCI_ADDR" forgot to consider reserved domain
> ID and mistakenly add MC_MSRINJ_F_GPADDR flag for them, which in turn
> causes bug reported by
> http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg02640.html.
>
> This patch removes MC_MSRINK_F_GPADDR flag and checks this when injecting
> to reserved domain IDs except DOMID_SELF, and treats the passed-in
> address as host machine address.
>
> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-27 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 13:30 [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject Haozhong Zhang
2016-05-27 14:03 ` Jan Beulich [this message]
2016-05-27 14:06 ` Wei Liu
2016-05-27 15:31 ` Wei Liu
2016-05-27 16:06 ` Jan Beulich
2016-05-27 16:14 ` Wei Liu
2016-05-27 16:16 ` Wei Liu
2016-06-01 6:38 ` Haozhong Zhang
2016-06-06 13:08 ` Wei Liu
2016-06-06 13:40 ` Egger, Christoph
2016-06-06 13:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57486FDE02000078000EF407@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chegger@amazon.de \
--cc=haozhong.zhang@intel.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=pengtaox.zhang@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).