From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] kexec: allow relaxed placement specification via command line
Date: Tue, 31 May 2016 04:50:07 -0600 [thread overview]
Message-ID: <574D887F02000078000EFF81@prv-mh.provo.novell.com> (raw)
In-Reply-To: <574D6671.3010302@citrix.com>
>>> On 31.05.16 at 12:24, <andrew.cooper3@citrix.com> wrote:
> On 30/05/16 14:48, Jan Beulich wrote:
>> Rather than just allowing a fixed address or fully automatic placement,
>> also allow for specifying an upper bound. Especially on EFI systems,
>> where firmware memory use is commonly less predictable than on legacy
>> BIOS ones, this makes success of the reservation more likely when
>> automatic placement is not an option (e.g. because of special DMA
>> restrictions of devices involved in actually carrying out the dump).
>>
>> Also take the opportunity to actually add text to the "crashkernel"
>> entry in the command line option doc.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/docs/misc/xen-command-line.markdown
>> +++ b/docs/misc/xen-command-line.markdown
>> @@ -458,7 +458,18 @@ Specify the maximum address to allocate
>> combination with the `low_crashinfo` command line option.
>>
>> ### crashkernel
>> -> `= <ramsize-range>:<size>[,...][@<offset>]`
>> +> `= <ramsize-range>:<size>[,...][{@,<}<offset>]`
>> +> `= <size>[{@,<}<offset>]`
>> +
>> +Specify sizes and optionally placement of the kexec reservation area.
>> +The `<ramsize-range>:<size>' pairs indicate how much memory to set
>
> For markdown, you need to use matching ` ` pairs for formatting the
> containing text as monospace.
Oh, okay. I meant to copy what was there, and now I see that
I didn't look right. Fixed.
> Other than this, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks, Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-31 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 13:48 [PATCH] kexec: allow relaxed placement specification via command line Jan Beulich
2016-05-31 10:24 ` Andrew Cooper
2016-05-31 10:50 ` Jan Beulich [this message]
2016-05-31 10:30 ` David Vrabel
2016-05-31 12:44 ` Jan Beulich
2016-05-31 16:02 ` David Vrabel
2016-06-01 10:26 ` Daniel Kiper
2016-06-01 10:42 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574D887F02000078000EFF81@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).