From: Julien Grall <julien.grall@arm.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Shannon Zhao <zhaoshenglong@huawei.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.comg,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
ian.jackson@eu.citrix.com, peter.huangpeng@huawei.com,
xen-devel@lists.xen.org, shannon.zhao@linaro.org,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 00/14] Xen ARM DomU ACPI support
Date: Wed, 1 Jun 2016 13:42:32 +0100 [thread overview]
Message-ID: <574ED838.2070902@arm.com> (raw)
In-Reply-To: <574DF957.9040405@oracle.com>
Hi Boris,
On 31/05/16 21:51, Boris Ostrovsky wrote:
> On 05/31/2016 03:42 PM, Konrad Rzeszutek Wilk wrote:
>> On Tue, May 31, 2016 at 12:43:22PM +0800, Shannon Zhao wrote:
>>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>>
>>> The design of this feature is described as below.
>>> Firstly, the toolstack (libxl) generates the ACPI tables according the
>>> number of vcpus and gic controller.
>> CC-ing Boris - who has been working on exposing ACPI tables
>> for PVH guests.
>>
>> Is there some way of re-using some of the code?
>
> Indeed it would be good to keep all ACPI code in single place.
>
> I sent a patch series a while ago
> (http://lists.xenproject.org/archives/html/xen-devel/2016-04/msg00625.html)
> but because of release work it hasn't been reviewed yet. Shannon, can
> you take a look at it and see whether you code can make use of what is
> proposed there? It builds all the tables that you are building here
> except for GTDT and provides libxc interface.
AFAICT, your library is creating ACPI 1.0/2.0 tables. However the
support for ARM has been added in ACPI 5.1.
Looking at the list of tables built by the library, we might be able to
re-use the code for SRAT, SLIT, FADT, RSDP. The rest is x86 specific
(WAET, MADT, HPET, SSDT_{PM,S3,S4}, TCPA (?)).
In the current state, I think the benefits for ARM is very limited. I
agree that having a common library to manipulate ACPI would be nice,
however, this would need a better abstraction to support different
version and avoid to build unnecessary code.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-01 12:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 4:43 [PATCH 00/14] Xen ARM DomU ACPI support Shannon Zhao
2016-05-31 4:43 ` [PATCH 01/14] libxl/arm: Fix the function name in error log Shannon Zhao
2016-05-31 4:43 ` [PATCH 02/14] libxl/arm: Factor out codes for generating DTB Shannon Zhao
2016-05-31 4:43 ` [PATCH 03/14] libxc: Add placeholders for ACPI tables blob and size Shannon Zhao
2016-05-31 4:43 ` [PATCH 04/14] tools: add ACPI tables relevant definitions Shannon Zhao
2016-05-31 4:43 ` [PATCH 05/14] libxl/arm: Construct ACPI GTDT table Shannon Zhao
2016-05-31 4:43 ` [PATCH 06/14] libxl/arm: Construct ACPI FADT table Shannon Zhao
2016-05-31 4:43 ` [PATCH 07/14] libxl/arm: Construct ACPI DSDT table Shannon Zhao
2016-05-31 4:43 ` [PATCH 08/14] libxl/arm: Construct ACPI MADT table Shannon Zhao
2016-05-31 4:43 ` [PATCH 09/14] libxl/arm: Construct ACPI XSDT table Shannon Zhao
2016-05-31 4:43 ` [PATCH 10/14] libxl/arm: Construct ACPI RSDP table Shannon Zhao
2016-05-31 4:43 ` [PATCH 11/14] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-05-31 4:43 ` [PATCH 12/14] libxl/arm: Add ACPI module Shannon Zhao
2016-05-31 4:43 ` [PATCH 13/14] libxl/arm: initialize memory information of ACPI blob Shannon Zhao
2016-05-31 4:43 ` [PATCH 14/14] libxc/xc_dom_core: Copy ACPI tables to guest memory space Shannon Zhao
2016-05-31 4:56 ` [PATCH 00/14] Xen ARM DomU ACPI support Shannon Zhao
2016-05-31 19:42 ` Konrad Rzeszutek Wilk
2016-05-31 20:51 ` Boris Ostrovsky
2016-06-01 12:42 ` Julien Grall [this message]
2016-06-01 12:59 ` Boris Ostrovsky
2016-06-01 13:21 ` Julien Grall
2016-06-01 13:39 ` Boris Ostrovsky
2016-06-01 13:53 ` Shannon Zhao
2016-06-01 14:36 ` Boris Ostrovsky
2016-06-01 14:56 ` Shannon Zhao
2016-06-01 15:05 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574ED838.2070902@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=peter.huangpeng@huawei.com \
--cc=roger.pau@citrix.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.comg \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).