From: "Jan Beulich" <JBeulich@suse.com>
To: David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jan Beulich <JBeulich@suse.com>, Juergen Gross <JGross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 3/2] xen-pciback: drop rom_init()
Date: Mon, 06 Jun 2016 02:47:40 -0600 [thread overview]
Message-ID: <575554CC02000078000F1E3F__34485.9277167872$1465202998$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com>
It's identical to bar_init() now.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm sorry for this 3/2 - I only now noticed that this additional
simplification is now possible.
---
drivers/xen/xen-pciback/conf_space_header.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
--- 4.7-rc2-xen-pciback-BAR.orig/drivers/xen/xen-pciback/conf_space_header.c
+++ 4.7-rc2-xen-pciback-BAR/drivers/xen/xen-pciback/conf_space_header.c
@@ -250,18 +250,6 @@ static void *bar_init(struct pci_dev *de
return bar;
}
-static void *rom_init(struct pci_dev *dev, int offset)
-{
- struct pci_bar_info *bar = kzalloc(sizeof(*bar), GFP_KERNEL);
-
- if (!bar)
- return ERR_PTR(-ENOMEM);
-
- read_dev_bar(dev, bar, offset);
-
- return bar;
-}
-
static void bar_reset(struct pci_dev *dev, int offset, void *data)
{
struct pci_bar_info *bar = data;
@@ -380,7 +368,7 @@ static const struct config_field header_
{ \
.offset = reg_offset, \
.size = 4, \
- .init = rom_init, \
+ .init = bar_init, \
.reset = bar_reset, \
.release = bar_release, \
.u.dw.read = bar_read, \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-06 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <57554B8D02000078000F1DE4@prv-mh.provo.novell.com>
2016-06-06 8:11 ` [PATCH 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-06 8:12 ` [PATCH 2/2] xen-pciback: clean up read_dev_bar() Jan Beulich
2016-06-06 8:47 ` Jan Beulich [this message]
[not found] ` <57554C5D02000078000F1DF1@prv-mh.provo.novell.com>
2016-06-06 13:03 ` [PATCH 1/2] xen-pciback: return proper values during BAR sizing Boris Ostrovsky
2016-06-06 13:51 ` Jan Beulich
[not found] ` <57559C1D02000078000F20DF@prv-mh.provo.novell.com>
2016-06-06 14:28 ` Boris Ostrovsky
[not found] ` <57554C7502000078000F1DF5@prv-mh.provo.novell.com>
2016-06-06 13:04 ` [PATCH 2/2] xen-pciback: clean up read_dev_bar() Boris Ostrovsky
[not found] ` <575554CC02000078000F1E3F@prv-mh.provo.novell.com>
2016-06-06 13:09 ` [PATCH 3/2] xen-pciback: drop rom_init() Boris Ostrovsky
2016-06-06 13:54 ` Jan Beulich
[not found] ` <57559CBD02000078000F20EC@prv-mh.provo.novell.com>
2016-06-06 14:35 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='575554CC02000078000F1E3F__34485.9277167872$1465202998$gmane$org@prv-mh.provo.novell.com' \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).