xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>,
	xen-devel@lists.xen.org, Jun Nakajima <jun.nakajima@intel.com>,
	Haozhong Zhang <haozhong.zhang@intel.com>
Subject: Re: [PATCH] Revert "x86/hvm: add support for pcommit instruction"
Date: Mon, 06 Jun 2016 04:37:56 -0600	[thread overview]
Message-ID: <57556EA402000078000F1F2F@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160606103103.GU14588@citrix.com>

>>> On 06.06.16 at 12:31, <wei.liu2@citrix.com> wrote:
> On Mon, Jun 06, 2016 at 02:54:47AM -0600, Jan Beulich wrote:
>> >>> On 06.06.16 at 07:56, <haozhong.zhang@intel.com> wrote:
>> > This reverts commit cfacce340608be5f94ce0c8f424487b63c3d5399.
>> > 
>> > Platforms supporting Intel NVDIMM are now required to provide
>> > persistency once pmem stores are accepted by the memory subsystem.
>> > This is usually achieved by a platform-level feature known as ADR
>> > (Asynchronous DRAM Refresh) that flushes any memory subsystem write
>> > pending queues on power loss/shutdown. Therefore, the pcommit
>> > instruction, which has not yet shipped on any product (and will not),
>> > is no longer needed and is deprecated.
>> > 
>> > Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
>> 
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> 
>> Wei - certainly something to consider for 4.7.
>> 
> 
> Sure. No point in shipping feature that won't show up in hardware.
> 
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> But please wait a bit before committing while we try to sort out RC5 and
> branching etc.

Sure. Got to wait for a VMX maintainer ack anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-06 10:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  5:56 [PATCH] Revert "x86/hvm: add support for pcommit instruction" Haozhong Zhang
2016-06-06  8:54 ` Jan Beulich
2016-06-06 10:31   ` Wei Liu
2016-06-06 10:37     ` Jan Beulich [this message]
2016-06-07  0:55       ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57556EA402000078000F1F2F@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=haozhong.zhang@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).