From: Julien Grall <julien.grall@arm.com> To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org Cc: edgar.iglesias@xilinx.com, sstabellini@kernel.org Subject: Re: [RFC for-4.8 v2 1/7] xen/arm: Add MATTR_MEM_NC for normal non-cacheable memory Date: Mon, 6 Jun 2016 18:23:47 +0100 [thread overview] Message-ID: <5755B1A3.1030901@arm.com> (raw) In-Reply-To: <1464960552-6645-2-git-send-email-edgar.iglesias@gmail.com> Hi Edgar, On 03/06/16 14:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Add the MATTR_MEM_NC macro describing normal non-cacheable memory. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > xen/arch/arm/p2m.c | 1 + > xen/include/asm-arm/page.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 838d004..0f1e1b1 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -343,6 +343,7 @@ static lpae_t mfn_to_p2m_entry(unsigned long mfn, unsigned int mattr, > e.p2m.sh = LPAE_SH_INNER; > break; > > + case MATTR_MEM_NC: I would add a comment here to explain why non-cacheable memory should always be outer-shareable (see DDI 0406C.b B3-1376 to 1377). For ideas on what to write, see mfn_to_xen_entry in include/asm-arm/page.h > case MATTR_DEV: > e.p2m.sh = LPAE_SH_OUTER; > break; > diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h > index a94e978..45d2e2c 100644 > --- a/xen/include/asm-arm/page.h > +++ b/xen/include/asm-arm/page.h > @@ -73,6 +73,7 @@ > * > */ > #define MATTR_DEV 0x1 > +#define MATTR_MEM_NC 0x5 > #define MATTR_MEM 0xf > > /* Flags for get_page_from_gva, gvirt_to_maddr etc */ > Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-06 17:23 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-03 13:29 [RFC for-4.8 v2 0/7] xen/arm: Add support for mapping mmio-sram nodes into dom0 Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 1/7] xen/arm: Add MATTR_MEM_NC for normal non-cacheable memory Edgar E. Iglesias 2016-06-06 17:23 ` Julien Grall [this message] 2016-06-07 20:34 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache Edgar E. Iglesias 2016-06-06 17:55 ` Julien Grall 2016-06-07 20:55 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 3/7] xen/device-tree: Add __DT_MATCH macros without braces Edgar E. Iglesias 2016-06-06 17:36 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 4/7] xen/device-tree: Make dt_match_node match props Edgar E. Iglesias 2016-06-06 17:39 ` Julien Grall 2016-06-07 20:43 ` Edgar E. Iglesias 2016-06-08 8:44 ` Julien Grall 2016-06-09 16:04 ` Edgar E. Iglesias 2016-06-09 16:23 ` Julien Grall 2016-06-09 16:30 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 5/7] xen/arm: domain_build: Plumb for different mapping attributes Edgar E. Iglesias 2016-06-06 18:00 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 6/7] xen/device-tree: Add an mmio-sram bus Edgar E. Iglesias 2016-06-06 18:05 ` Julien Grall 2016-06-08 0:21 ` Edgar E. Iglesias 2016-06-08 8:52 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 7/7] xen/arm: Map mmio-sram nodes as normal un-cached rwx memory Edgar E. Iglesias 2016-06-06 18:08 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5755B1A3.1030901@arm.com \ --to=julien.grall@arm.com \ --cc=edgar.iglesias@gmail.com \ --cc=edgar.iglesias@xilinx.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xen.org \ --subject='Re: [RFC for-4.8 v2 1/7] xen/arm: Add MATTR_MEM_NC for normal non-cacheable memory' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).