From: Julien Grall <julien.grall@arm.com> To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org Cc: edgar.iglesias@xilinx.com, sstabellini@kernel.org Subject: Re: [RFC for-4.8 v2 7/7] xen/arm: Map mmio-sram nodes as normal un-cached rwx memory Date: Mon, 6 Jun 2016 19:08:03 +0100 [thread overview] Message-ID: <5755BC03.2060106@arm.com> (raw) In-Reply-To: <1464960552-6645-8-git-send-email-edgar.iglesias@gmail.com> Hi Edgar, On 03/06/16 14:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Map mmio-sram nodes as normal un-cached MEMORY with RWX perms. > If the node has set the no-memory-wc property, we map it as > DEVICE RW. Please add a path/link to the bindings in the commit message. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 064feb3..2a2316b 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -54,6 +54,32 @@ struct map_range_data > const struct map_attr *attr; > }; > > +static const struct map_attr mattr_device_rw __initconst = > +{ > + .memattr = MATTR_DEV, > + .access = p2m_access_rw, > +}; > + > +static const struct map_attr mattr_memory_nc_rwx __initconst = > +{ > + .memattr = MATTR_MEM_NC, > + .access = p2m_access_rwx, > +}; > + > +static const struct dt_device_match dev_map_attrs[] __initconst = > +{ > + { > + __DT_MATCH_COMPATIBLE("mmio-sram"), > + __DT_MATCH_PROPS("no-memory-wc"), > + .data = &mattr_device_rw, > + }, > + { > + __DT_MATCH_COMPATIBLE("mmio-sram"), > + .data = &mattr_memory_nc_rwx, > + }, > + { /* sentinel */ }, > +}; > + > //#define DEBUG_DT > > #ifdef DEBUG_DT > @@ -1201,6 +1227,16 @@ static int handle_device(struct domain *d, struct dt_device_node *dev, > return 0; > } > > +static const struct map_attr *lookup_map_attr(struct dt_device_node *node, > + const struct map_attr *parent_attr) The indentation looks wrong here. > +{ > + const struct dt_device_match *r; > + > + /* Search and if nothing matches, use the parent's attributes. */ > + r = dt_match_node(dev_map_attrs, node); Newline here please. > + return r ? r->data : parent_attr; I would explain this behavior in the commit message and give some rationale why it is fine to do that. > +} > + > static int handle_node(struct domain *d, struct kernel_info *kinfo, > struct dt_device_node *node, > const struct map_attr *attr) > @@ -1290,6 +1326,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo, > "WARNING: Path %s is reserved, skip the node as we may re-use the path.\n", > path); > > + attr = lookup_map_attr(node, attr); > res = handle_device(d, node, attr); > if ( res) > return res; > Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-06 18:08 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-03 13:29 [RFC for-4.8 v2 0/7] xen/arm: Add support for mapping mmio-sram nodes into dom0 Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 1/7] xen/arm: Add MATTR_MEM_NC for normal non-cacheable memory Edgar E. Iglesias 2016-06-06 17:23 ` Julien Grall 2016-06-07 20:34 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache Edgar E. Iglesias 2016-06-06 17:55 ` Julien Grall 2016-06-07 20:55 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 3/7] xen/device-tree: Add __DT_MATCH macros without braces Edgar E. Iglesias 2016-06-06 17:36 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 4/7] xen/device-tree: Make dt_match_node match props Edgar E. Iglesias 2016-06-06 17:39 ` Julien Grall 2016-06-07 20:43 ` Edgar E. Iglesias 2016-06-08 8:44 ` Julien Grall 2016-06-09 16:04 ` Edgar E. Iglesias 2016-06-09 16:23 ` Julien Grall 2016-06-09 16:30 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 5/7] xen/arm: domain_build: Plumb for different mapping attributes Edgar E. Iglesias 2016-06-06 18:00 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 6/7] xen/device-tree: Add an mmio-sram bus Edgar E. Iglesias 2016-06-06 18:05 ` Julien Grall 2016-06-08 0:21 ` Edgar E. Iglesias 2016-06-08 8:52 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 7/7] xen/arm: Map mmio-sram nodes as normal un-cached rwx memory Edgar E. Iglesias 2016-06-06 18:08 ` Julien Grall [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5755BC03.2060106@arm.com \ --to=julien.grall@arm.com \ --cc=edgar.iglesias@gmail.com \ --cc=edgar.iglesias@xilinx.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xen.org \ --subject='Re: [RFC for-4.8 v2 7/7] xen/arm: Map mmio-sram nodes as normal un-cached rwx memory' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).