From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Date: Tue, 07 Jun 2016 00:31:43 -0600 Message-ID: <5756866F02000078000F269D__45519.3572365262$1465281175$gmane$org@prv-mh.provo.novell.com> References: <5756857802000078000F268D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAAYH-0002ru-RJ for xen-devel@lists.xenproject.org; Tue, 07 Jun 2016 06:31:49 +0000 In-Reply-To: <5756857802000078000F268D@prv-mh.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: David Vrabel , Boris Ostrovsky , Konrad Rzeszutek Wilk , Juergen Gross Cc: xen-devel , linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org LSBkcm9wIHVudXNlZCBmdW5jdGlvbiBwYXJhbWV0ZXIgb2YgcmVhZF9kZXZfYmFyKCkKLSBkcm9w IHJvbV9pbml0KCkgKG5vdyBpZGVudGljYWwgdG8gYmFyX2luaXQoKSkKLSBmb2xkIHJlYWRfZGV2 X2JhcigpIGludG8gaXRzIG5vdyBzaW5nbGUgY2FsbGVyCi0gc2ltcGxpZnkgZGV0ZXJtaW5hdGlv biBvZiA2NC1iaXQgbWVtb3J5IHJlc291cmNlCi0gdXNlIGNvbnN0IGFuZCB1bnNpZ25lZAoKU2ln bmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgotLS0KdjI6IGZvbGQg aW4gM3JkIHBhdGNoIGFuZCBkcm9wIHJlYWRfZGV2X2JhcigpIChhcyByZXF1ZXN0ZWQgYnkgQm9y aXMpCi0tLQogZHJpdmVycy94ZW4veGVuLXBjaWJhY2svY29uZl9zcGFjZV9oZWFkZXIuYyB8ICAg NTcgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2Vy dGlvbnMoKyksIDQwIGRlbGV0aW9ucygtKQoKLS0tIDQuNy1yYzIteGVuLXBjaWJhY2stQkFSLm9y aWcvZHJpdmVycy94ZW4veGVuLXBjaWJhY2svY29uZl9zcGFjZV9oZWFkZXIuYworKysgNC43LXJj Mi14ZW4tcGNpYmFjay1CQVIvZHJpdmVycy94ZW4veGVuLXBjaWJhY2svY29uZl9zcGFjZV9oZWFk ZXIuYwpAQCAtMjA5LDU4ICsyMDksMzUgQEAgc3RhdGljIGludCBiYXJfcmVhZChzdHJ1Y3QgcGNp X2RldiAqZGV2LAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW5saW5lIHZvaWQgcmVhZF9kZXZf YmFyKHN0cnVjdCBwY2lfZGV2ICpkZXYsCi0JCQkJc3RydWN0IHBjaV9iYXJfaW5mbyAqYmFyX2lu Zm8sIGludCBvZmZzZXQsCi0JCQkJdTMyIGxlbl9tYXNrKQorc3RhdGljIHZvaWQgKmJhcl9pbml0 KHN0cnVjdCBwY2lfZGV2ICpkZXYsIGludCBvZmZzZXQpCiB7Ci0JaW50CXBvczsKLQlzdHJ1Y3Qg cmVzb3VyY2UJKnJlcyA9IGRldi0+cmVzb3VyY2U7CisJdW5zaWduZWQgaW50IHBvczsKKwljb25z dCBzdHJ1Y3QgcmVzb3VyY2UgKnJlcyA9IGRldi0+cmVzb3VyY2U7CisJc3RydWN0IHBjaV9iYXJf aW5mbyAqYmFyID0ga3phbGxvYyhzaXplb2YoKmJhciksIEdGUF9LRVJORUwpOworCisJaWYgKCFi YXIpCisJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwogCiAJaWYgKG9mZnNldCA9PSBQQ0lfUk9N X0FERFJFU1MgfHwgb2Zmc2V0ID09IFBDSV9ST01fQUREUkVTUzEpCiAJCXBvcyA9IFBDSV9ST01f UkVTT1VSQ0U7CiAJZWxzZSB7CiAJCXBvcyA9IChvZmZzZXQgLSBQQ0lfQkFTRV9BRERSRVNTXzAp IC8gNDsKLQkJaWYgKHBvcyAmJiAoKHJlc1twb3MgLSAxXS5mbGFncyAmIChQQ0lfQkFTRV9BRERS RVNTX1NQQUNFIHwKLQkJCQlQQ0lfQkFTRV9BRERSRVNTX01FTV9UWVBFX01BU0spKSA9PQotCQkJ ICAgKFBDSV9CQVNFX0FERFJFU1NfU1BBQ0VfTUVNT1JZIHwKLQkJCQlQQ0lfQkFTRV9BRERSRVNT X01FTV9UWVBFXzY0KSkpIHsKLQkJCWJhcl9pbmZvLT52YWwgPSByZXNbcG9zIC0gMV0uc3RhcnQg Pj4gMzI7Ci0JCQliYXJfaW5mby0+bGVuX3ZhbCA9IC1yZXNvdXJjZV9zaXplKCZyZXNbcG9zIC0g MV0pID4+IDMyOwotCQkJcmV0dXJuOworCQlpZiAocG9zICYmIChyZXNbcG9zIC0gMV0uZmxhZ3Mg JiBJT1JFU09VUkNFX01FTV82NCkpIHsKKwkJCWJhci0+dmFsID0gcmVzW3BvcyAtIDFdLnN0YXJ0 ID4+IDMyOworCQkJYmFyLT5sZW5fdmFsID0gLXJlc291cmNlX3NpemUoJnJlc1twb3MgLSAxXSkg Pj4gMzI7CisJCQlyZXR1cm4gYmFyOwogCQl9CiAJfQogCiAJaWYgKCFyZXNbcG9zXS5mbGFncyB8 fAogCSAgICAocmVzW3Bvc10uZmxhZ3MgJiAoSU9SRVNPVVJDRV9ESVNBQkxFRCB8IElPUkVTT1VS Q0VfVU5TRVQgfAogCQkJICAgICAgIElPUkVTT1VSQ0VfQlVTWSkpKQotCQlyZXR1cm47Ci0KLQli YXJfaW5mby0+dmFsID0gcmVzW3Bvc10uc3RhcnQgfAotCQkJKHJlc1twb3NdLmZsYWdzICYgUENJ X1JFR0lPTl9GTEFHX01BU0spOwotCWJhcl9pbmZvLT5sZW5fdmFsID0gLXJlc291cmNlX3NpemUo JnJlc1twb3NdKSB8Ci0JCQkgICAgKHJlc1twb3NdLmZsYWdzICYgUENJX1JFR0lPTl9GTEFHX01B U0spOwotfQorCQlyZXR1cm4gYmFyOwogCi1zdGF0aWMgdm9pZCAqYmFyX2luaXQoc3RydWN0IHBj aV9kZXYgKmRldiwgaW50IG9mZnNldCkKLXsKLQlzdHJ1Y3QgcGNpX2Jhcl9pbmZvICpiYXIgPSBr emFsbG9jKHNpemVvZigqYmFyKSwgR0ZQX0tFUk5FTCk7Ci0KLQlpZiAoIWJhcikKLQkJcmV0dXJu IEVSUl9QVFIoLUVOT01FTSk7Ci0KLQlyZWFkX2Rldl9iYXIoZGV2LCBiYXIsIG9mZnNldCwgfjAp OwotCi0JcmV0dXJuIGJhcjsKLX0KLQotc3RhdGljIHZvaWQgKnJvbV9pbml0KHN0cnVjdCBwY2lf ZGV2ICpkZXYsIGludCBvZmZzZXQpCi17Ci0Jc3RydWN0IHBjaV9iYXJfaW5mbyAqYmFyID0ga3ph bGxvYyhzaXplb2YoKmJhciksIEdGUF9LRVJORUwpOwotCi0JaWYgKCFiYXIpCi0JCXJldHVybiBF UlJfUFRSKC1FTk9NRU0pOwotCi0JcmVhZF9kZXZfYmFyKGRldiwgYmFyLCBvZmZzZXQsIH5QQ0lf Uk9NX0FERFJFU1NfRU5BQkxFKTsKKwliYXItPnZhbCA9IHJlc1twb3NdLnN0YXJ0IHwKKwkJICAg KHJlc1twb3NdLmZsYWdzICYgUENJX1JFR0lPTl9GTEFHX01BU0spOworCWJhci0+bGVuX3ZhbCA9 IC1yZXNvdXJjZV9zaXplKCZyZXNbcG9zXSkgfAorCQkgICAgICAgKHJlc1twb3NdLmZsYWdzICYg UENJX1JFR0lPTl9GTEFHX01BU0spOwogCiAJcmV0dXJuIGJhcjsKIH0KQEAgLTM4Myw3ICszNjAs NyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGNvbmZpZ19maWVsZCBoZWFkZXJfCiAJewkJCQkJCVwK IAkub2Zmc2V0ICAgICA9IHJlZ19vZmZzZXQsCQkJXAogCS5zaXplICAgICAgID0gNCwJCQkJXAot CS5pbml0ICAgICAgID0gcm9tX2luaXQsCQkJCVwKKwkuaW5pdCAgICAgICA9IGJhcl9pbml0LAkJ CQlcCiAJLnJlc2V0ICAgICAgPSBiYXJfcmVzZXQsCQkJXAogCS5yZWxlYXNlICAgID0gYmFyX3Jl bGVhc2UsCQkJXAogCS51LmR3LnJlYWQgID0gYmFyX3JlYWQsCQkJCVwKCgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==