xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
	xen-devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Philip Elcan <pelcan@codeaurora.org>,
	Vikram Sethi <vikrams@codeaurora.org>,
	Wei Chen <wei.chen@linaro.org>
Subject: Re: [PATCH V6 1/3] drivers/pl011: Don't configure baudrate
Date: Tue, 7 Jun 2016 15:00:04 +0100	[thread overview]
Message-ID: <5756D364.7080803@arm.com> (raw)
In-Reply-To: <1465253940-26236-1-git-send-email-shankerd@codeaurora.org>

Hello Shanker,

On 06/06/16 23:58, Shanker Donthineni wrote:
> The default baud and clock_hz configuration parameters are hardcoded
> (commit 60ff9444480995008caf) for Versatile Express. Other platforms,
> these default values may not be valid and might cause problems by
> programming registers IBRD and FBRD incorrectly.
> So, removing driver logic that sets the baudrate to fix the problem.
> The boot firmware is responsible for setting the correct baudrate.

It might be worth to say that the behavior is unchanged because the 
driver was already relying on the boot firmware.

Other than that:

Reviewed-by: Julien Grall <julien.grall@arm.com>


Julien Grall

Xen-devel mailing list

      parent reply	other threads:[~2016-06-07 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 22:58 [PATCH V6 1/3] drivers/pl011: Don't configure baudrate Shanker Donthineni
2016-06-06 22:58 ` [PATCH V6 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS Shanker Donthineni
2016-06-07 13:58   ` Julien Grall
2016-06-07 14:03     ` Shanker Donthineni
2016-06-07 14:09       ` Julien Grall
2016-06-06 22:59 ` [PATCH V6 3/3] arm/acpi: Add Server Base System Architecture UART support Shanker Donthineni
2016-06-07 14:09   ` Julien Grall
2016-06-07 14:00 ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5756D364.7080803@arm.com \
    --to=julien.grall@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=pelcan@codeaurora.org \
    --cc=shankerd@codeaurora.org \
    --cc=sstabellini@kernel.org \
    --cc=vikrams@codeaurora.org \
    --cc=wei.chen@linaro.org \
    --cc=xen-devel@lists.xensource.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).